This seems like a generic problem with jQuery UI dialogs, and so probably breaks other gadgets and extensions.

I note in the skin.json for Vector that jquery.ui styles are not loaded for vector-2022. Is this deliberate @Jdlrobson ?

@Esanders when I split the Vector skin into two I intentionally only copied over non-deprecated libraries as my thinking was that the Vector 2022 should not inherited technical debt and given Vue.js usage inside Vector 2022, jquery.ui usage should be discouraged at all costs since loading jquery.ui, OOUI and Codex in a single page on page load is unnecessary.

I realize in this case it would be simply loading an existing stylesheet, but I worry that sets up an expectation that web team will update the jquery.ui stylesheet as the rest of the interface evolves and that's not happening. [FWIW I would be interested in using my time over the holidays to work towards migrating this UI if you (or anyone else) is interested in doing that as this interface does seem relatively simple.]

Assuming nothing is broken with the Wikilove dialog I'd rather we declined this task and invested effort in moving Wikilove over to Codex or OOUI. Alternatively perhaps this code could be moved into core if another team is happy to maintain it.

Happy to chat through the pros and cons of continuing to support jquery.ui in Vector 2022 in a larger group and documenting the outcome of that decision.

If we want to actually encourage developers to move away from jQuery UI there are better ways than just slowly degrading the user experience (e.g. announcing official sunset dates).

Given there is a very long tail of gadgets and extensions using jQuery UI which I don't expect to get fixed any time soon, I don't think we should make our users suffer.

The whole library is marked as deprecated so I think that should be sufficient to bat away any requests to update and maintain the stylesheet, and I don't think we've had any such requests for classic vector over the past few years.

Note also the highest-profile user of jQuery UI is WikiEditor dialogs, which are also affected by this issue. The editing team definitely does not have time to prioritise migrating these, but we should maintain the existing experience for our users.

Change 855564 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/Vector@master] Add jQuery.UI styles to Vector 2022

https://gerrit.wikimedia.org/r/855564

Chatted to other web team members today (@Jdrewniak @Mabualruz @nray @bwang ). It's our understanding that currently the overlay is at 17px font-size and loading the Vector styles will switch this overlay to 14px font size. However, font size will be changing to 16px in Vector 2022 (T254055). How do users "suffer" with the larger font size?

If we only want to fix the font size, then it may make sense to add a smaller stylesheet which just fixes this problem rather than the entirety of Vector legacy's skin styles. But you have just said "that should be sufficient to bat away any requests to update and maintain the stylesheet".

I'm going to start a thread in Slack to dive into this topic deeper as I worry we shouldn't be caring about jQuery UI at all.

Howdy. Buttons in PageTriage appear to have lost their colors and styling in vector-2022. Please see T323673. A test engineer spotted this while testing a different patch (T311323). Any easy fixes for this?

Change 855564 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add jQuery.UI styles to Vector 2022

https://gerrit.wikimedia.org/r/855564

@ovasileva any QA for this one?

Looks good in beta