Stop spamming SAL with helmfile on scap deployments
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Clement_Goubert
	Nov 17 2022, 5:00 PM

Description

Add a variable to the helmfiles so scap can suppress SAL logging. In the meantime, remove logging completely.

	Subject	Repo	Branch	Lines +/-
	mw-*: Remove sal logging hook	operations/deployment-charts	master	+0 -90

	Title	Reference	Author	Source Branch	Dest Branch
	kubernetes: Fix SAL suppression	repos/releng/scap!32	cgoubert	fix-sal-suppress	master
	Suppress SAL logging when running helmfile	repos/releng/scap!26	cgoubert	sal_helmfile_suppress	master

Status	Subtype	Assigned	Task
Stalled		None	T255792 Quibble runs core:unit tests twice!
Open		None	T328919 Upgrade to PHPUnit 10
Open		None	T338103 Micro-optimize ApiResult::isMetadataKey with str_starts_with once we support PHP8+
Open		None	T328921 Drop PHP 7.4 support from MediaWiki
Stalled		None	T334726 Use return type `never` in Wikibase
Open		None	T328922 Drop PHP 8.0 support from MediaWiki
Stalled		None	T319055 Upgrade to psr/container 2.x
Stalled	Feature	None	T364249 New upstream release for Pygments (2.18.0)
Stalled		Krinkle	T319432 Migrate WMF production from PHP 7.4 to PHP 8.1
Open		None	T291916 Tracking task for Bullseye migrations in production
Stalled		None	T356293 Migrate MW appservers' base images to bullseye
Open		None	T290536 Serve production traffic via Kubernetes
In Progress		Clement_Goubert	T321786 Deploy mediawiki kubernetes services
Resolved		Clement_Goubert	T323296 Stop spamming SAL with helmfile on scap deployments

Clement_Goubert changed the task status from Open to In Progress.Nov 17 2022, 5:01 PM

Clement_Goubert triaged this task as Medium priority.

Change 858360 had a related patch set uploaded (by Clément Goubert; author: Clément Goubert):

[operations/deployment-charts@master] mw-*: Remove sal logging hook

helmfile_log_sal has support for that already:

# Allow to explicitely suppress logging to SAL
SUPPRESS_SAL=${SUPPRESS_SAL:-false}

Merge request on scap to pass the SUPPRESS_SAL variable

Change 858360 abandoned by Clément Goubert:

[operations/deployment-charts@master] mw-*: Remove sal logging hook

Reason:

Abandoned in favor of scap suppressing SAL output https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/26