Page MenuHomePhabricator
Create Task
Maniphest T325580

1.40.0-wmf.17 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
hashar
Release Version
1.40.0-wmf.17
Release Date
Jan 2 2023, 12:00 AM

2023 week 01 1.40-wmf.17 Changes wmf/1.40.0-wmf.17

This MediaWiki Train Deployment is scheduled for the week of Monday, January 2nd:

Monday January 2ndTuesday, January 3rdWednesday, January 4thThursday, January 5thFriday
Backports only.Branch wmf.17 and deploy to Group 0 Wikis.Deploy wmf.17 to Group 1 Wikis.Deploy wmf.17 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.17 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.40.0-wmf.16
Next: 1.40.0-wmf.18
SubjectRepoBranchLines +/-
group0 wikis to 1.40.0-wmf.17operations/mediawiki-configmaster+128 -128
all wikis to 1.40.0-wmf.17operations/mediawiki-configmaster+325 -325
group1 wikis to 1.40.0-wmf.17operations/mediawiki-configmaster+540 -540
group0 wikis to 1.40.0-wmf.17operations/mediawiki-configmaster+128 -128
testwikis wikis to 1.40.0-wmf.17operations/mediawiki-configmaster+4 -4
Branch commit for wmf/1.40.0-wmf.17mediawiki/corewmf/1.40.0-wmf.17+991 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Dec 19 2022, 7:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 19 2022, 7:47 PM
thcipriani assigned this task to jnuche.Dec 19 2022, 7:56 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: hashar.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).
thcipriani reassigned this task from jnuche to dduvall.Dec 19 2022, 7:59 PM
thcipriani added a subscriber: jnuche.
hashar subscribed.Jan 1 2023, 7:19 AM
gerritbot added a comment.Jan 3 2023, 3:07 AM

Change 873923 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.40.0-wmf.17] Branch commit for wmf/1.40.0-wmf.17

https://gerrit.wikimedia.org/r/873923

gerritbot added a project: Patch-For-Review.Jan 3 2023, 3:07 AM
gerritbot added a comment.Jan 3 2023, 3:23 AM

Change 873923 merged by jenkins-bot:

[mediawiki/core@wmf/1.40.0-wmf.17] Branch commit for wmf/1.40.0-wmf.17

https://gerrit.wikimedia.org/r/873923

gerritbot added a comment.Jan 3 2023, 4:01 AM

Change 874446 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.40.0-wmf.17

https://gerrit.wikimedia.org/r/874446

gerritbot added a comment.Jan 3 2023, 4:01 AM

Change 874446 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.40.0-wmf.17

https://gerrit.wikimedia.org/r/874446

Stashbot added a comment.Jan 3 2023, 4:02 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-03T04:02:28Z] <mwpresync@deploy1002> Started scap: testwikis wikis to 1.40.0-wmf.17 refs T325580

Stashbot added a comment.Jan 3 2023, 4:58 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-03T04:58:00Z] <mwpresync@deploy1002> Finished scap: testwikis wikis to 1.40.0-wmf.17 refs T325580 (duration: 55m 31s)

gerritbot added a comment.Jan 3 2023, 7:09 PM

Change 874925 had a related patch set uploaded (by TrainBranchBot; author: Dduvall):

[operations/mediawiki-config@master] group0 wikis to 1.40.0-wmf.17

https://gerrit.wikimedia.org/r/874925

Ladsgroup subscribed.Jan 3 2023, 7:15 PM
gerritbot added a comment.Jan 3 2023, 7:18 PM

Change 874927 had a related patch set uploaded (by TrainBranchBot; author: Dduvall):

[operations/mediawiki-config@master] group0 wikis to 1.40.0-wmf.17

https://gerrit.wikimedia.org/r/874927

gerritbot added a comment.Jan 3 2023, 7:19 PM

Change 874927 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.40.0-wmf.17

https://gerrit.wikimedia.org/r/874927

Jdlrobson added subscribers: Jdlrobson, Tgr.EditedJan 3 2023, 7:20 PM
Risky Patch! 🚂🔥
  • Change: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/867732 (T51541)
  • Summary:
    • We have refactored/generalized code relating to the generation of rollback and thanks on important editor tool pages such as RecentChanges/Contributions/Watchlist to make them operate as they do on the history page.
    • This means more thanks/rollback links in more places including mobile
    • Given we are generating more thanks links that could be a performance problem. There's also a risk that these behave incorrectly as something was missed in the refactor.
  • Test plan:
    • How will it be verified?
  • Places to monitor:
  • Revert plan: Rollback / pause train.

If issues with thanks performance, we should backport https://gerrit.wikimedia.org/r/c/mediawiki/core/+/874928 to turn off the new behaviour.
Issues with revert will be fixed by backport within 12hr period.

  • Affected wikis:

All wikis

Stashbot added a comment.Jan 3 2023, 7:27 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-03T19:27:32Z] <dduvall@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.40.0-wmf.17 refs T325580

gerritbot added a comment.Jan 4 2023, 7:16 PM

Change 875411 had a related patch set uploaded (by TrainBranchBot; author: Dduvall):

[operations/mediawiki-config@master] group1 wikis to 1.40.0-wmf.17

https://gerrit.wikimedia.org/r/875411

gerritbot added a comment.Jan 4 2023, 7:18 PM

Change 875411 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.40.0-wmf.17

https://gerrit.wikimedia.org/r/875411

Stashbot added a comment.Jan 4 2023, 7:25 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-04T19:25:37Z] <dduvall@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.40.0-wmf.17 refs T325580

Stashbot added a comment.Jan 4 2023, 7:32 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-04T19:32:35Z] <dduvall@deploy1002> Synchronized php: group1 wikis to 1.40.0-wmf.17 refs T325580 (duration: 06m 58s)

Umherirrender added a subtask: T326275: TypeError: Argument 6 passed to McrUndoAction::__construct() must be an instance of MediaWiki\CommentFormatter\CommentFormatter, instance of GlobalVarConfig given, called in /srv/mediawiki/php-1.40.0-wmf.17/vendor/wikimedia/obj.Jan 4 2023, 11:09 PM
AmandaNP added a subtask: T326293: CVE-2023-29139: API request timeout - CheckUserLog.Jan 5 2023, 8:24 AM
AmandaNP subscribed.Jan 5 2023, 9:54 AM
Ladsgroup removed a subtask: T326293: CVE-2023-29139: API request timeout - CheckUserLog.Jan 5 2023, 12:37 PM
• taavi closed subtask T326275: TypeError: Argument 6 passed to McrUndoAction::__construct() must be an instance of MediaWiki\CommentFormatter\CommentFormatter, instance of GlobalVarConfig given, called in /srv/mediawiki/php-1.40.0-wmf.17/vendor/wikimedia/obj as Resolved.Jan 5 2023, 7:48 PM
gerritbot added a comment.Jan 5 2023, 7:51 PM

Change 875998 had a related patch set uploaded (by TrainBranchBot; author: Dduvall):

[operations/mediawiki-config@master] all wikis to 1.40.0-wmf.17

https://gerrit.wikimedia.org/r/875998

gerritbot added a comment.Jan 5 2023, 7:51 PM

Change 875998 merged by jenkins-bot:

[operations/mediawiki-config@master] all wikis to 1.40.0-wmf.17

https://gerrit.wikimedia.org/r/875998

Stashbot added a comment.Jan 5 2023, 7:59 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-05T19:59:43Z] <dduvall@deploy1002> rebuilt and synchronized wikiversions files: all wikis to 1.40.0-wmf.17 refs T325580

dduvall closed this task as Resolved.Jan 6 2023, 5:44 PM
gerritbot added a comment.Jun 28 2023, 1:40 PM

Change 874925 abandoned by Reedy:

[operations/mediawiki-config@master] group0 wikis to 1.40.0-wmf.17

Reason:

https://gerrit.wikimedia.org/r/874925

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL