obj
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Zabe
	Jan 4 2023, 10:23 PM

Description

Error

mwversion: 1.40.0-wmf.17
reqId: 3c43d53e-e8e2-4973-9e4c-e643273ea5e5
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   TypeError: Argument 6 passed to McrUndoAction::__construct() must be an instance of MediaWiki\CommentFormatter\CommentFormatter, instance of GlobalVarConfig given, called in /srv/mediawiki/php-1.40.0-wmf.17/vendor/wikimedia/obj

exception.trace

from /srv/mediawiki/php-1.40.0-wmf.17/includes/actions/McrUndoAction.php(67)
#0 /srv/mediawiki/php-1.40.0-wmf.17/vendor/wikimedia/object-factory/src/ObjectFactory.php(247): McrUndoAction->__construct(ImagePage, RequestContext, ReadOnlyMode, MediaWiki\Revision\RevisionStore, MediaWiki\Revision\RevisionRenderer, GlobalVarConfig)
#1 /srv/mediawiki/php-1.40.0-wmf.17/vendor/wikimedia/object-factory/src/ObjectFactory.php(152): Wikimedia\ObjectFactory\ObjectFactory::getObjectFromSpec(array, array)
#2 /srv/mediawiki/php-1.40.0-wmf.17/includes/actions/ActionFactory.php(312): Wikimedia\ObjectFactory\ObjectFactory->createObject(array, array)
#3 /srv/mediawiki/php-1.40.0-wmf.17/includes/actions/ActionFactory.php(370): MediaWiki\Actions\ActionFactory->getAction(string, ImagePage, RequestContext)
#4 /srv/mediawiki/php-1.40.0-wmf.17/includes/context/RequestContext.php(290): MediaWiki\Actions\ActionFactory->getActionName(RequestContext)
#5 /srv/mediawiki/php-1.40.0-wmf.17/includes/context/ContextSource.php(129): RequestContext->getActionName()
#6 /srv/mediawiki/php-1.40.0-wmf.17/extensions/InputBox/includes/InputBoxHooks.php(99): ContextSource->getActionName()
#7 /srv/mediawiki/php-1.40.0-wmf.17/includes/HookContainer/HookContainer.php(160): MediaWiki\Extension\InputBox\InputBoxHooks->onMediaWikiPerformAction(OutputPage, ImagePage, Title, User, WebRequest, MediaWiki)
#8 /srv/mediawiki/php-1.40.0-wmf.17/includes/HookContainer/HookRunner.php(2486): MediaWiki\HookContainer\HookContainer->run(string, array)
#9 /srv/mediawiki/php-1.40.0-wmf.17/includes/MediaWiki.php(516): MediaWiki\HookContainer\HookRunner->onMediaWikiPerformAction(OutputPage, ImagePage, Title, User, WebRequest, MediaWiki)
#10 /srv/mediawiki/php-1.40.0-wmf.17/includes/MediaWiki.php(328): MediaWiki->performAction(ImagePage, Title)
#11 /srv/mediawiki/php-1.40.0-wmf.17/includes/MediaWiki.php(916): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.40.0-wmf.17/includes/MediaWiki.php(571): MediaWiki->main()
#13 /srv/mediawiki/php-1.40.0-wmf.17/index.php(50): MediaWiki->run()
#14 /srv/mediawiki/php-1.40.0-wmf.17/index.php(46): wfIndexMain()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}

Impact

Notes

Details

MediaWiki Version: 1.40.0-wmf.17
Request URL: https://commons.wikimedia.org/w/index.php?action=mcrrestore&restore=*&title=*

	Subject	Repo	Branch	Lines +/-
	actions: Pass CommentFormatter to McrRestoreAction	mediawiki/core	wmf/1.40.0-wmf.17	+1 -0
	actions: Pass CommentFormatter to McrRestoreAction	mediawiki/core	master	+1 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	• dduvall	T325580 1.40.0-wmf.17 deployment blockers
		Resolved	PRODUCTION ERROR	Zabe	T326275 TypeError: Argument 6 passed to McrUndoAction::__construct() must be an instance of MediaWiki\CommentFormatter\CommentFormatter, instance of GlobalVarConfig given, called in /srv/mediawiki/php-1.40.0-wmf.17/vendor/wikimedia/obj

Event Timeline

Zabe created this task.Jan 4 2023, 10:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 4 2023, 10:23 PM

Change 875442 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] actions: Pass CommentFormatter to McrRestoreAction

https://gerrit.wikimedia.org/r/875442

gerritbot added a project: Patch-For-Review.Jan 4 2023, 10:28 PM

Change 875442 merged by jenkins-bot:

[mediawiki/core@master] actions: Pass CommentFormatter to McrRestoreAction

https://gerrit.wikimedia.org/r/875442

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 4 2023, 11:00 PM

Suggest backport, there is no workaround on commons to undo mcr revisions (mostly are files with mediainfo)

Umherirrender added a parent task: T325580: 1.40.0-wmf.17 deployment blockers.Jan 4 2023, 11:09 PM

Change 875379 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@wmf/1.40.0-wmf.17] actions: Pass CommentFormatter to McrRestoreAction

https://gerrit.wikimedia.org/r/875379

Zabe claimed this task.Jan 5 2023, 12:04 AM

Zabe triaged this task as Unbreak Now! priority.

Crtn32002 subscribed.Jan 5 2023, 4:41 AM

thcipriani moved this task from Untriaged to Jan 2023 on the Wikimedia-production-error board.Jan 5 2023, 5:05 PM

Change 875379 merged by jenkins-bot:

[mediawiki/core@wmf/1.40.0-wmf.17] actions: Pass CommentFormatter to McrRestoreAction

https://gerrit.wikimedia.org/r/875379

Mentioned in SAL (#wikimedia-operations) [2023-01-05T19:37:57Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:875379|actions: Pass CommentFormatter to McrRestoreAction (T326275)]]

Mentioned in SAL (#wikimedia-operations) [2023-01-05T19:41:08Z] <taavi@deploy1002> taavi and zabe: Backport for [[gerrit:875379|actions: Pass CommentFormatter to McrRestoreAction (T326275)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-01-05T19:48:08Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:875379|actions: Pass CommentFormatter to McrRestoreAction (T326275)]] (duration: 10m 11s)

taavi closed this task as Resolved.Jan 5 2023, 7:48 PM

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.17; 2023-01-02); removed MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 5 2023, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 5 2023, 8:29 PM

TypeError: Argument 6 passed to McrUndoAction::__construct() must be an instance of MediaWiki\CommentFormatter\CommentFormatter, instance of GlobalVarConfig given, called in /srv/mediawiki/php-1.40.0-wmf.17/vendor/wikimedia/objClosed, ResolvedPublicPRODUCTION ERRORActions