Page MenuHomePhabricator

Recent donations not saved after merging of two CIDs
Open, In Progress, MediumPublic

Description

The CID 52189124 was merged into CID 5989215, however, the donations from 2021 and 2022 attached to the first CID were not recorded after the merge. I had to search using the original CID 52189124 to be able to see it. Can someone please check what could’ve happened?
Ps - we had a similar case last year https://phabricator.wikimedia.org/T319073
Thanks, team!

Event Timeline

greg triaged this task as Medium priority.Feb 14 2023, 9:31 PM
greg subscribed.

Most likely due to DB deadlock issues.

Maybe recover the rows for now?

@SHust we do have these happen from time to time & it happens when server load is super high - in the meantime you can undelete the contact, re-add the email & re-merge them to fix the specific contact (let me know if you want to run through it on a call)

We could probably do a patch to wrap each dedupe in a transaction - it would need upstreaming so maybe a phab on the feature board to do that

@SHust It looks like the 'wrap each dedupe in a transaction' isn't quite what we need to do here. Eileen has suggested instead we run a regular job to alert us to these problems so we can know how frequent they are and fix them.

@SHust It looks like the 'wrap each dedupe in a transaction' isn't quite what we need to do here. Eileen has suggested instead we run a regular job to alert us to these problems so we can know how frequent they are and fix them.

Did Eileen say how the proposed new job should work? Possibly something along the lines of checking recent merges and confirming the closed contact's donations are present on the surviving record.

@jgleeson I believe this issue has been resolved!

jgleeson claimed this task.

thanks @SHust! I'll close this ticket and create a new one for the new job mentioned in the comments.

jgleeson moved this task from Blocked to Done on the Fundraising Tech - Chaos Crew board.