[Regression] (office wiki) Account login menu missing in Vector 22
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

None

Authored By

	Krinkle
	Feb 12 2023, 8:44 PM

Description

Follow up to https://phabricator.wikimedia.org/T289212

https://office.wikimedia.org/
Observe top-right bar contains only dead-end language selector and a three-dot menu. (There was previously a "Create account" link here, which is also a dead-end on private wikis like this one, with the Login link tucked inside the three-dot menu.)
Click "three-dot" menu.

Expected:
Menu opens containing a Login link.

Actual:
Two thin border appears with no visible content between them.

Other details:

Confirmed in latest Firefox, Chrome and Safari, on macOS.

Kapture 2023-02-12 at 20.40.12.gif (288×800 px, 70 KB)

Kapture 2023-02-12 at 20.43.12.gif (745×1 px, 1 MB)

TODO

Fix the issue
Add a test since this has regressed several times now

Details

	Subject	Repo	Branch	Lines +/-
	Fixes missing account login in OfficeWiki	mediawiki/skins/Vector	master	+19 -7

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		ovasileva	T266536 [EPIC] Consolidate user links into a single menu
Resolved		ovasileva	T274428 User Links: Handling of talk page notification
Resolved		ovasileva	T276564 User links: Logged-out user links menu treatment
Resolved	Feature	ovasileva	T289212 Feature request: Make login button appear besides the create account text outside new compact user menu
Resolved		None	T329463 [Regression] (office wiki) Account login menu missing in Vector 22

Event Timeline

Krinkle created this task.Feb 12 2023, 8:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2023, 8:44 PM

JJMC89 merged a task: T329564: OfficeWiki missing login link in header.Feb 13 2023, 6:45 PM

JJMC89 added a project: Web-Team-Backlog.

JJMC89 added a subscriber: bwang.

Jdlrobson renamed this task from [Regression] Account login menu missing in Vector 22 to [Regression] (office wiki) Account login menu missing in Vector 22.Feb 13 2023, 8:17 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 4); removed Web-Team-Backlog.Feb 13 2023, 8:19 PM

Workaround: for now you can zoom in until the language selector disappears. Now he log in and create account buttons will show up inside the ellipsis.

aliu added a parent task: T289212: Feature request: Make login button appear besides the create account text outside new compact user menu.Feb 15 2023, 1:24 PM

Jdlrobson triaged this task as High priority.Feb 16 2023, 6:37 PM

Jdlrobson updated the task description. (Show Details)Feb 16 2023, 6:42 PM

LGoto set the point value for this task to 3.Feb 16 2023, 6:43 PM

LGoto moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 4) board.

LGoto removed a project: Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 4).Feb 24 2023, 6:47 PM

LGoto added a project: Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 4).Feb 24 2023, 7:01 PM

ovasileva lowered the priority of this task from High to Medium.Feb 27 2023, 6:43 PM

ovasileva edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 4).

ovasileva moved this task from Incoming to Current Quarter on the Web-Team-Backlog board.Mar 2 2023, 4:57 PM

Pullling into the board as a potential next ticket for @KSarabia-WMF

KSarabia-WMF claimed this task.Mar 2 2023, 10:03 PM

Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 4) board.Mar 6 2023, 6:26 PM

Change 895852 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/skins/Vector@master] Fixes missing account login in OfficeWiki

https://gerrit.wikimedia.org/r/895852

gerritbot added a project: Patch-For-Review.Mar 8 2023, 7:52 PM

bwang claimed this task.Mar 9 2023, 4:59 PM

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 4) board.

Change 895852 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fixes missing account login in OfficeWiki

https://gerrit.wikimedia.org/r/895852

Maintenance_bot removed a project: Patch-For-Review.Mar 9 2023, 10:10 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 4) board.Mar 9 2023, 10:56 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.27; 2023-03-13).Mar 10 2023, 12:00 AM

bwang removed bwang as the assignee of this task.Mar 10 2023, 9:42 PM

This can't be tested in beta to my knowledge.

ovasileva moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 4) board.Mar 14 2023, 3:19 PM

Test Result - Prod

Status: ❌
Environment: officewiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

https://office.wikimedia.org/
Observe top-right bar contains only dead-end language selector and a three-dot menu. (There was previously a "Create account" link here, which is also a dead-end ❓ on private wikis like this one, with the Login link tucked inside the three-dot menu.)
The language link doesn't appear to be dead-end, but a 3 dot menu does appear

Screenshot 2023-03-20 at 4.15.17 PM.png (906×863 px, 396 KB)

Click "three-dot" menu.
❌ AC1: Expected: Menu opens containing a Login link.
Above 720, the Login link is already present, but the 3-dot menu is empty

Screenshot 2023-03-20 at 4.17.02 PM.png (932×860 px, 589 KB)

Below 720 the Login link does appear in the 3-dot menu, but the Language button is lost. Additionally, for below and above 720px width, the Main Manu contains an "In other languages" section with no links.

Screenshot 2023-03-20 at 4.17.44 PM.png (933×703 px, 176 KB)

Resolving this. The issues above will be addressed in T332743

	F36921035: Screenshot 2023-03-20 at 4.17.44 PM.png
	Mar 20 2023, 11:20 PM

	F36921032: Screenshot 2023-03-20 at 4.17.02 PM.png
	Mar 20 2023, 11:20 PM

	F36921029: Screenshot 2023-03-20 at 4.15.17 PM.png
	Mar 20 2023, 11:20 PM

	F36822788: Kapture 2023-02-12 at 20.43.12.gif
	Feb 12 2023, 8:44 PM

	F36822787: Kapture 2023-02-12 at 20.40.12.gif
	Feb 12 2023, 8:44 PM

[Regression] (office wiki) Account login menu missing in Vector 22Closed, ResolvedPublic3 Estimated Story PointsActions