Change 885405 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Move Log in link to overflow menu

https://gerrit.wikimedia.org/r/885405

@alexhollender_WMF @Jdlrobson I realized one edge case is $wgGroupPermissions['*']['edit'] = false;. When that is set, the anon editor links dont show anymore. With this task this means the dropdown is empty until smaller viewports. Should we just hide the dropdown when anon editor links arent shown on larger viewports? Also note there isnt a great way to handle this case when gadgets add stuff to the dropdown.

In T289212#8580341, @bwang wrote:

@alexhollender_WMF @Jdlrobson I realized one edge case is $wgGroupPermissions['*']['edit'] = false;. When that is set, the anon editor links dont show anymore. With this task this means the dropdown is empty until smaller viewports. Should we just hide the dropdown when anon editor links arent shown on larger viewports? Also note there isnt a great way to handle this case when gadgets add stuff to the dropdown.

I think hiding should be okay/expected. Mostly thinking of ptwiki where anonymous editing is not allowed.

Change 885909 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Rename data-user-menu prefix to data-user-links, matching the template and component naming convention, create UserLinksDropdown.mustache

https://gerrit.wikimedia.org/r/885909

Change 885910 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Build user links dropdown using multiple menus, move user links logic and definitions from SkinVector22 to VectorComponentUserLinks.php

https://gerrit.wikimedia.org/r/885910

Change 885909 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Rename data-user-menu prefix to data-user-links, matching the template and component naming convention, create UserLinksDropdown.mustache

https://gerrit.wikimedia.org/r/885909

Change 886168 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Clean up user links cached HTML code

https://gerrit.wikimedia.org/r/886168

@bwang how does this look like now, one click to log in or 2 clicks to log in?

i tried to read the code, and it looks like you plan to make log-in 2 clicks away, instead of one click as requested in this task and others, like: T328510.

if people ask for something and kind of get the exact opposite creates a little headache so to say :) :)

In T289212#8584221, @ThurnerRupert wrote:

@bwang how does this look like now, one click to log in or 2 clicks to log in?

i tried to read the code, and it looks like you plan to make log-in 2 clicks away, instead of one click as requested in this task and others, like: T328510.

if people ask for something and kind of get the exact opposite creates a little headache so to say :) :)

@ThurnerRupert - this would take the login button out of the current menu and require one click to get to the login screen.

is there any chance to remove "create account" from the top level and let it be on the login page? there is no obvious help why creating an account is cool. i created one to describe it a little better:
https://phabricator.wikimedia.org/T328836

In T289212#8587101, @ThurnerRupert wrote:

is there any chance to remove "create account" from the top level and let it be on the login page? there is no obvious help why creating an account is cool. i created one to describe it a little better:
https://phabricator.wikimedia.org/T328836

Hi @ThurnerRupert - thanks for the question. I mentioned in an earlier comment that may have been for a main reason for highlighting "Create account" is that:

In T289212#8576273, @RHo wrote:

... @TheDJ mentions in T289212#8562811 that many sites do have Log in as the main link, but on Wikipedia it is less expected that one can create an account since not having an account doesn't prevent one from reading or editing, whereas on any other sites people typically have to log in to access something, so I believe this was one of the main reasons for making the Create account more primary.

To elaborate, because Create account on Wikipedia is less required than on say an e-commerce site or even online newspaper which requires subscription for full access, one of the ways to surface the many benefits of having an account is to show it as a main prompt for those who don't yet have an account.

What are the benefits, you ask? Besides ability to customise your UI more via Special:Preferences, and access more features like Dark mode, Reading lists (for app users), etc for readers; those who create and account will now also access features specifically created (by the Growth team) to help people start editing on Wikipedia. There are future plans in place to surface these benefits better on the Special:CreateAccount page by the same Growth team. I will cross post this comment on your feature req't task and channel to Growth team for response.

Change 885405 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Move Log in link to overflow menu

https://gerrit.wikimedia.org/r/885405

Alex I think https://phabricator.wikimedia.org/T289212#8571752 is the source of confusion here. Perhaps such conversations could be kept separate from sprint tickets in future (will add to retro)?

In T289212#8591944, @Jdlrobson wrote:

Alex I think https://phabricator.wikimedia.org/T289212#8571752 is the source of confusion here. Perhaps such conversations could be kept separate from sprint tickets in future (will add to retro)?

I don't understand?

Change 887336 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove button styling from log in link

https://gerrit.wikimedia.org/r/887336

Change 887351 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.40.0-wmf.22] Remove button styling from log in link

https://gerrit.wikimedia.org/r/887351

Change 887336 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove button styling from log in link

https://gerrit.wikimedia.org/r/887336

Change 887351 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.40.0-wmf.22] Remove button styling from log in link

https://gerrit.wikimedia.org/r/887351

Mentioned in SAL (#wikimedia-operations) [2023-02-07T21:20:28Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:887353|Disable languages on history page (T328996)]], [[gerrit:887351|Remove button styling from log in link (T289212)]], [[gerrit:887350|[followup] mediawiki.feedlink: Atom's link icon overlaps the link (T327717)]]

Mentioned in SAL (#wikimedia-operations) [2023-02-07T21:22:20Z] <urbanecm@deploy1002> urbanecm and jdlrobson: Backport for [[gerrit:887353|Disable languages on history page (T328996)]], [[gerrit:887351|Remove button styling from log in link (T289212)]], [[gerrit:887350|[followup] mediawiki.feedlink: Atom's link icon overlaps the link (T327717)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-02-07T21:31:38Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:887353|Disable languages on history page (T328996)]], [[gerrit:887351|Remove button styling from log in link (T289212)]], [[gerrit:887350|[followup] mediawiki.feedlink: Atom's link icon overlaps the link (T327717)]] (duration: 11m 10s)

@Jdlrobson FYI, there's still this patch remaining to be reviewed https://gerrit.wikimedia.org/r/885909. It handles this case here and refactors user links code.

It's also a lower priority followup, so if you prefer i could ask someone else to review the remaining patch

@bwang I think you mean https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/885910 ? If so yes, it's on my radar, I've just been focusing on more time sensitive patches, but yes this task should not be completed without that.

Change 885910 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove custom handling of user links menu items and handle case when anon editor links are disabled

https://gerrit.wikimedia.org/r/885910

I'm drawing a blank, how can this be tested?

I guess

1. Set $wgGroupPermissions['*']['edit'] = false
2. Log out and see if dropdown appears when >720px
3. Change size to <720px and see if dropdown appears

Expected result should be no dropdown at 2. and yes dropdown at 3.

When anon editor links are disabled $wgGroupPermissions['*']['edit'] = false, the dropdown is hidden until 720px

@Edtadros to test this in production https://office.wikimedia.org/wiki/Homepage - which looks like a fail to me.

❓ AC3: The login link should have an ID (pt-login) so that it works with click tracking.

The login link inside the dropdown (viewable on small viewports) has the pt-login id. I chose to name the one viewable on large screens pt-login-2 because thats the same naming convention used for the create account, user page and watchlist links, all of which are also collapsible links. Perhaps we could change the convention for all of these links later but I thought it was best not to introduce that inconsistency.

In T289212#8611164, @Jdlrobson wrote:

When anon editor links are disabled $wgGroupPermissions['*']['edit'] = false, the dropdown is hidden until 720px

@Edtadros to test this in production https://office.wikimedia.org/wiki/Homepage - which looks like a fail to me.

This is handled in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/885910, which was merged last Friday so its not deployed yet.

However, I am seeing an issue in office wiki where there isnt a login link outside of the dropdown for some reason. Tracked in https://phabricator.wikimedia.org/T329564

As this bug is in the way to be solved (today is the first day in a whole year where I didn't need to explain where the button is to a class full of students), I would like note how this topic was tried to be abandoned, closed and ridiculized from the start. The only motive for this to be solved is that Vector 2022 was deployed at English Wikipedia and there was great criticism.

The reason why things are deployed first in smaller projects is to have feedback and try to solve issues before they reach the larger ones. If the sincere and logical feedback is closed, disbanded and those who make it are silenced, then we reach to a situation where no one benefits.

Thanks to those who have been working on this. Let's make the process better in the future.

To streamline the process you might want to catch up on reading on what are subtasks, what are bugs, and what are feature requests. IMO that was the only reason you were scrutinized. If you submitted this as a feature request from the start then the issue wouldn't ever be closed. It's pretty standard protocol that "bug" tasks working as intended are closed.

It is quite unseemly to admonish a user for at worst not dotting the i's and cross the t's, especially so when the issue is something that definitely looks like a bug. The change in subtype after the issue has been resolved appears quite vindictive. The issue was fully understandable from the beginning, and was eventually actioned as a bug report. It is very positive that Theklan brought this issue up for attention years ago, and it is an improvement to the various Wikimedia projects that it was finally solved.

@aliu if something is working in version 1.1 and is not working in version 1.2 I think that is not a feature. Anyway, asking for features doesn't work in this platform, as they have exactly the same treatment: closing them or ignoring them.

Change 886168 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Clean up user links cached HTML code

https://gerrit.wikimedia.org/r/886168