Maniphest T330459

Add wikidata_qid property to metrics_event schema
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cjming
	Feb 24 2023, 12:56 AM

Tags

Referenced Files

None

Subscribers

Description

Background

The current MP schema has the wikidata_id property set as an integer type which does not pass validation since most wikidata IDs are prefixed with a Q (see T327083#8635819 and https://www.wikidata.org/wiki/Wikidata:Identifiers)

Description

Add a new property to the schema called wikidata_qid which has a type of string to capture the full wikidata id.

Acceptance criteria

MP monoschema has a new property wikidata_qid added
Update documentation to include this property

Details

	Subject	Repo	Branch	Lines +/-
	Update metrics_event schema to 1.2.0	schemas/event/secondary	master	+531 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		None	T309013 EditAttemptStep Migration to (monoschema) MP
		Resolved		phuedx	T312016 Increase EditAttemptStep sampling rate(s) to 100%
		Resolved	PRODUCTION ERROR	phuedx	T322758 '.custom_data['mode'].data_type' should be equal to one of the allowed values
		Resolved		phuedx	T332673 Update JS and PHP Metrics Platform Clients to use wikidata_qid context attribute
		Resolved		cjming	T330459 Add wikidata_qid property to metrics_event schema

Event Timeline

cjming created this task.Feb 24 2023, 12:56 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2023, 12:56 AM

cjming claimed this task.Feb 24 2023, 1:00 AM

cjming triaged this task as High priority.

cjming mentioned this in T330460: Fix context values in Java client to pass EventLogging validation.

cjming moved this task from Ready to In Progress on the Metrics Platform Backlog (Metrics Platform Kanban) board.

cjming updated the task description. (Show Details)Feb 24 2023, 1:07 AM

Change 891398 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[schemas/event/secondary@master] Update metrics_event schema

https://gerrit.wikimedia.org/r/891398

gerritbot added a project: Patch-For-Review.Feb 24 2023, 1:13 AM

cjming moved this task from In Progress to In Review on the Metrics Platform Backlog (Metrics Platform Kanban) board.Feb 24 2023, 1:15 AM

phuedx mentioned this in T322758: '.custom_data['mode'].data_type' should be equal to one of the allowed values.Feb 24 2023, 10:56 AM

phuedx added a parent task: T322758: '.custom_data['mode'].data_type' should be equal to one of the allowed values.

Change 891398 merged by jenkins-bot:

[schemas/event/secondary@master] Update metrics_event schema to 1.2.0

https://gerrit.wikimedia.org/r/891398

Maintenance_bot removed a project: Patch-For-Review.Mar 1 2023, 11:31 AM

phuedx added a parent task: T281762: Incorporate librarized Metrics Platform PHP client into EventLogging.Mar 1 2023, 12:15 PM

phuedx removed a parent task: T281762: Incorporate librarized Metrics Platform PHP client into EventLogging.

cjming moved this task from In Review to Sign Off on the Metrics Platform Backlog (Metrics Platform Kanban) board.Mar 4 2023, 12:16 AM

phuedx moved this task from Sign Off to In Progress on the Metrics Platform Backlog (Metrics Platform Kanban) board.Mar 20 2023, 12:42 PM

@cjming: I moved this back to In Progress as we still need to update the JS and PHP MPCs to handle this property.

… I'll submit a follow-on task and move this task along.

Being bold.

https://wikitech.wikimedia.org/w/index.php?title=Metrics_Platform%2FEvent_Schema&diff=2063866&oldid=2016991&diffmode=source