Page MenuHomePhabricator
Create Task
Maniphest T309013

EditAttemptStep Migration to (monoschema) MP
Closed, InvalidPublic
Actions

Description

Goal: Migrate Edit Attempt Step Schema to the Metrics Platform.
Tasks
  • Configured a stream using the Metrics Platform Client to duplicate the data captured by the current EditAttemptStep Schema
 Notes
  1. The instruments in the DiscussionTools and MobileFrontend extensions are very similar and we should be able to migrate them in precisely the same way

Details

Other Assignee
• EChetty
SubjectRepoBranchLines +/-
ext.wikiEditor: Also log EditAttemptStep events via Metrics Platformmediawiki/extensions/WikiEditormaster+100 -48
testwiki: Add mediawiki.edit_attempt streamoperations/mediawiki-configmaster+47 -0
schemaEditAttemptStep: Also log EditAttemptStep events via Metrics Platformmediawiki/extensions/MobileFrontendmaster+29 -4
Also log EditAttemptStep events via Metrics Platformmediawiki/extensions/VisualEditormaster+83 -36
logger: Also log EditAttemptStep events via Metrics Platformmediawiki/extensions/DiscussionToolsmaster+17 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a project: Patch-For-Review.May 24 2022, 4:16 PM
phuedx mentioned this in T309306: Allow a stream to register interest in multiple events more easily.May 26 2022, 12:42 PM
phuedx added a project: DiscussionTools.
Esanders added a subscriber: DLynch.May 31 2022, 3:08 PM
phuedx moved this task from QA/Review to Discussed on the Metrics Platform Backlog board.Jun 1 2022, 11:28 AM
phuedx updated the task description. (Show Details)Jun 1 2022, 12:04 PM
phuedx updated the task description. (Show Details)Jun 1 2022, 2:30 PM
phuedx added a comment.Jun 1 2022, 2:47 PM

Migrate the instrument in the DiscussionTools extension

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/798830

phuedx updated the task description. (Show Details)Jun 1 2022, 4:09 PM
ppelberg reassigned this task from phuedx to DLynch.Jun 2 2022, 3:20 PM
ppelberg added a project: Editing-team (Kanban Board).
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.
ppelberg added a subscriber: phuedx.
phuedx added a comment.EditedJun 6 2022, 11:10 AM

Notes on the EAS instrument's (down)sampling rates:

DiscussionTools
  • Default: 6.25% of all pageviews
  • Currently: 100% of all pageviews ($wgDTEditAttemptStepOversample is truthy on all wikis)
  • Can also be set to 100% of all pageviews by third-party extensions
    • GrowthExperiments does this when the user clicks a suggested edit card on their newcomer homepage.
MobileFrontend
  • 6.25% of all pageviews
  • Can also be set to 100% of all pageviews by third-party extensions
    • GrowthExperiments does this when the user clicks a suggested edit card on their newcomer homepage
  • Can also be when the user is using a certain wikitext editor
    • On some wikis this is the case for all wikitext editors
VisualEditor & WikiEditor
  • 6.25% of all editing sessions
  • Can also be set to 100% of all pageviews by third-party extensions
    • GrowthExperiments does this when the user clicks a suggested edit card on their newcomer homepage
  • The editing session ID can be overridden by third-party extensions
gerritbot added a comment.Jun 6 2022, 5:45 PM

Change 803327 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/MobileFrontend@master] schemaEditAttemptStep: Also log EditAttemptStep events via Metrics Platform

https://gerrit.wikimedia.org/r/803327

VPuffetMichel edited projects, added Editing-team; removed Editing-team (Kanban Board).Jun 6 2022, 7:30 PM
VPuffetMichel moved this task from Kanban Board to Needs Discussion / Investigation on the Editing-team board.
gerritbot added a comment.Jun 8 2022, 10:57 AM

Change 803889 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/VisualEditor@master] Also log EditAttemptStep events via Metrics Platform

https://gerrit.wikimedia.org/r/803889

phuedx moved this task from Discussed to QA/Review on the Metrics Platform Backlog board.Jun 13 2022, 10:22 AM
phuedx mentioned this in T310693: Make Metrics Platform Clients record sampling rate and unit in the event.Jun 15 2022, 12:07 PM
Ottomata subscribed.Jun 29 2022, 1:17 PM
MNeisler subscribed.Jun 30 2022, 2:38 PM
phuedx mentioned this in T312016: Increase EditAttemptStep sampling rate(s) to 100%.Jul 5 2022, 8:26 AM
phuedx added a comment.Jul 26 2022, 5:34 PM

Hey, @DLynch/Editing! The Metrics Platform team (read: @EChetty and myself) would like to move forward with getting data from the Metrics Platform implementations of the EAS instrument. We think that T310693: Make Metrics Platform Clients record sampling rate and unit in the event and T311629: Change agent_client_platform_family context attribute values should be worked on but shouldn't block the review of the patches that have been submitted. Would it be possible to schedule these reviews?

mpopov awarded a token.Aug 2 2022, 4:43 PM
mpopov subscribed.
Mayakp.wiki subscribed.Aug 2 2022, 5:55 PM
gerritbot added a comment.Aug 6 2022, 5:01 AM

Change 798830 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] logger: Also log EditAttemptStep events via Metrics Platform

https://gerrit.wikimedia.org/r/798830

gerritbot added a comment.Aug 6 2022, 5:09 AM

Change 803889 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Also log EditAttemptStep events via Metrics Platform

https://gerrit.wikimedia.org/r/803889

gerritbot added a comment.Aug 6 2022, 5:27 AM

Change 803327 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] schemaEditAttemptStep: Also log EditAttemptStep events via Metrics Platform

https://gerrit.wikimedia.org/r/803327

Maintenance_bot removed a project: Patch-For-Review.Aug 6 2022, 5:30 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 6 2022, 6:00 AM
• EChetty moved this task from QA/Review to Sign-off on the Metrics Platform Backlog board.Aug 11 2022, 12:23 PM
• EChetty moved this task from Sign-off to QA/Review on the Metrics Platform Backlog board.
• EChetty moved this task from QA/Review to Discussed on the Metrics Platform Backlog board.Aug 11 2022, 12:28 PM
• EChetty moved this task from Discussed to Sign-off on the Metrics Platform Backlog board.Aug 16 2022, 12:35 PM
• EChetty moved this task from Sign-off to Discussed on the Metrics Platform Backlog board.
gerritbot added a comment.Aug 24 2022, 10:31 AM

Change 826234 had a related patch set uploaded (by Phuedx; author: Phuedx):

[operations/mediawiki-config@master] testwiki: Add mediawiki.edit_attempt stream

https://gerrit.wikimedia.org/r/826234

gerritbot added a project: Patch-For-Review.Aug 24 2022, 10:31 AM
gerritbot added a comment.Sep 13 2022, 1:14 PM

Change 826234 merged by jenkins-bot:

[operations/mediawiki-config@master] testwiki: Add mediawiki.edit_attempt stream

https://gerrit.wikimedia.org/r/826234

Stashbot added a comment.Sep 13 2022, 1:22 PM

Mentioned in SAL (#wikimedia-operations) [2022-09-13T13:22:03Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:826234|testwiki: Add mediawiki.edit_attempt stream (T309013)]] (1/2) (duration: 03m 39s)

Stashbot added a comment.Sep 13 2022, 1:25 PM

Mentioned in SAL (#wikimedia-operations) [2022-09-13T13:25:48Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings-labs.php: Config: [[gerrit:826234|testwiki: Add mediawiki.edit_attempt stream (T309013)]] (2/2) (duration: 03m 33s)

phuedx removed DLynch as the assignee of this task.Sep 13 2022, 1:26 PM
phuedx moved this task from Discussed to QA/Review on the Metrics Platform Backlog board.
Maintenance_bot removed a project: Patch-For-Review.Sep 13 2022, 1:30 PM
phuedx assigned this task to • EChetty.Sep 23 2022, 8:42 AM

Status update: The instrument was enabled on testwiki ~10 days ago and, as of this morning, the event.mediawiki_edit_attempt Hive table now has 400+ rows in it. Is this enough to double-check the shape of the events that are being logged?

• EChetty moved this task from QA/Review to Metrics Platform Kanban on the Metrics Platform Backlog board.Oct 1 2022, 4:29 PM
• EChetty edited projects, added Metrics Platform Backlog (Metrics Platform Kanban); removed Metrics Platform Backlog.
• EChetty moved this task from Ready to In Review on the Metrics Platform Backlog (Metrics Platform Kanban) board.
• EChetty updated the task description. (Show Details)Oct 5 2022, 6:56 PM
Mayakp.wiki mentioned this in T320281: Instrumentation Data-QA for event.mediawiki_edit_attempt.Oct 7 2022, 5:23 PM
Mayakp.wiki added a subtask: T320281: Instrumentation Data-QA for event.mediawiki_edit_attempt.
SNowick_WMF mentioned this in T313561: Integrate iOS editing data into EditAttmptStep schema.Oct 12 2022, 4:28 PM
phuedx mentioned this in T305491: Deprecate/delete the mw.eventLog.Schema class.Nov 3 2022, 1:30 PM
• EChetty reassigned this task from • EChetty to Mayakp.wiki.Nov 3 2022, 1:32 PM
• EChetty updated Other Assignee, added: • EChetty.
phuedx claimed this task.Nov 11 2022, 10:10 AM
phuedx moved this task from In Review to In Progress on the Metrics Platform Backlog (Metrics Platform Kanban) board.
gerritbot added a comment.Nov 11 2022, 3:11 PM

Change 855990 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/WikiEditor@master] ext.wikiEditor: Also log EditAttemptStep events via Metrics Platform

https://gerrit.wikimedia.org/r/855990

gerritbot added a project: Patch-For-Review.Nov 11 2022, 3:11 PM
phuedx moved this task from In Progress to In Review on the Metrics Platform Backlog (Metrics Platform Kanban) board.Nov 14 2022, 11:37 AM
gerritbot added a comment.Dec 2 2022, 9:14 AM

Change 855990 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] ext.wikiEditor: Also log EditAttemptStep events via Metrics Platform

https://gerrit.wikimedia.org/r/855990

cjming moved this task from In Review to Ready to Deploy on the Metrics Platform Backlog (Metrics Platform Kanban) board.Dec 2 2022, 9:16 AM
• EChetty moved this task from Ready to Deploy to Done on the Metrics Platform Backlog (Metrics Platform Kanban) board.Jan 10 2023, 3:45 PM
SNowick_WMF subscribed.Feb 14 2023, 10:44 PM

Following up on this task - has anyone from Product Analytics been assigned to validate data? @EChetty in your opinion is this schema ready for iOS data integration? Thanks.

DLynch added a comment.Feb 14 2023, 10:54 PM

I think there's validation occurring over in T320281.

SNowick_WMF added a comment.Feb 14 2023, 11:04 PM

Thank you @DLynch! Will follow up with Maya. I am interested in the issue you mentioned there w/r/t edit step event tracking, will follow that ticket.

Maintenance_bot removed a project: Patch-For-Review.Feb 14 2023, 11:10 PM
• EChetty added a comment.Feb 16 2023, 12:07 PM

Hey @SNowick_WMF

In theory, this should be okay to integrate but the events generated will be incomplete.
This task is currently blocked by T281762 to track the sever-side events to complete the loop so to speak. (By blocked - we are stuck currently trying to find someone who is confident they know enough to review the patch - which has proved harder that we realised)
I would personally would wait on this until we are unblocked and @Mayakp.wiki & @phuedx gives the all okay.

matmarex mentioned this in T332438: Centralize EditAttemptStep logging code in WikimediaEvents.Mar 18 2023, 10:32 AM
phuedx closed subtask T312016: Increase EditAttemptStep sampling rate(s) to 100% as Resolved.Mar 22 2023, 2:14 PM
phuedx moved this task from Done to Sign Off on the Metrics Platform Backlog (Metrics Platform Kanban) board.Apr 3 2023, 12:05 PM
phuedx moved this task from Sign Off to Done on the Metrics Platform Backlog (Metrics Platform Kanban) board.Apr 24 2023, 12:35 PM
phuedx moved this task from Done to Sign Off on the Metrics Platform Backlog (Metrics Platform Kanban) board.

☝️ T309985: Migrate WikiEditor EditAttemptStep instrument to Metrics Platform is still in In Review…

phuedx closed subtask T309985: Migrate WikiEditor EditAttemptStep instrument to Metrics Platform as Resolved.Aug 7 2023, 3:29 PM
VirginiaPoundstone moved this task from Sign Off to Done on the Metrics Platform Backlog (Metrics Platform Kanban) board.Aug 14 2023, 12:50 PM
phuedx removed phuedx as the assignee of this task.Aug 14 2023, 1:06 PM
mpopov renamed this task from EditAttemptStep Migration to MP to EditAttemptStep Migration to (monoschema) MP.Feb 5 2024, 8:59 PM
mpopov closed this task as Invalid.
mpopov closed subtask T320281: Instrumentation Data-QA for event.mediawiki_edit_attempt as Invalid.
mpopov updated the task description. (Show Details)
mpopov added subscribers: VirginiaPoundstone, WDoranWMF.Feb 5 2024, 9:05 PM

@VirginiaPoundstone @WDoranWMF I renamed this task to refer to the (now deprecated) monoschema version of Metrics Platform. The partial migrations of the instruments were removed (see T351337, T351335).

EditAttemptStep will need to be migrated to the (new) Core Interaction API version of Metrics Platform eventually but that should probably be a separate ticket (and a hypothesis in the next annual plan).

phuedx awarded a token.Feb 6 2024, 6:59 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL