Remove partial migration of VisualEditorFeatureUse instrument
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

There is a partial migration of the VisualEditorFeatureUse instrument to the MP client library. It uses dispatch(), which is now deprecated in favour of submitInteraction(). We should remove the partial migration of the instrument to minimise our own maintenance burden.

Acceptance criteria

The partial migration is removed
- https://gerrit.wikimedia.org/g/mediawiki/extensions/WikimediaEvents/+/fb849379e991f0163d7ef4c880df93cd2139d78a/modules/ext.wikimediaEvents/editAttemptStep.js#447
Any supporting code is removed
Any supporting documentation is updated
- e.g. see the WikimediaEvents/OWNERS.md file and/or the DocBlocks at the tops of the files listed above
Any associated streams are removed
- https://gerrit.wikimedia.org/g/operations/mediawiki-config/+/213bc5bfaa55cf09e7cf48a3484f95e1fdcc745c/wmf-config/ext-EventStreamConfig.php#1089

Details

	Subject	Repo	Branch	Lines +/-
	Remove partial migration of VisualEditorFeatureUse instrument	operations/mediawiki-config	master	+0 -47
	Remove partial migration of VisualEditorFeatureUse instrument	mediawiki/extensions/WikimediaEvents	master	+0 -12

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T352969 Deprecate and remove MetricsClient#dispatch()
		Resolved		Sfaci	T351337 Remove partial migration of VisualEditorFeatureUse instrument

Event Timeline

phuedx created this task.Nov 15 2023, 6:08 PM

phuedx moved this task from Backlog to Instruments on the Metrics Platform Backlog board.

phuedx updated the task description. (Show Details)Nov 16 2023, 9:44 PM

phuedx added a project: good first task.Nov 24 2023, 6:10 AM

VirginiaPoundstone edited projects, added Data Products (Data Products Sprint 04); removed Data Products.Nov 27 2023, 3:07 PM

Sfaci claimed this task.Nov 27 2023, 4:59 PM

Sfaci moved this task from Sprint Backlog to In Process on the Data Products (Data Products Sprint 04) board.

Change 977986 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/mediawiki-config@master] Remove partial migration of VisualEditorFeatureUse instrument

https://gerrit.wikimedia.org/r/977986

gerritbot added a project: Patch-For-Review.Nov 28 2023, 7:48 AM

Sfaci added a comment.Nov 28 2023, 7:55 AM

This comment was removed by Sfaci.

Change 977989 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[mediawiki/extensions/WikimediaEvents@master] Remove partial migration of VisualEditorFeatureUse instrument

https://gerrit.wikimedia.org/r/977989

Change 977989 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Remove partial migration of VisualEditorFeatureUse instrument

https://gerrit.wikimedia.org/r/977989

Sfaci moved this task from In Process to To Deploy on the Data Products (Data Products Sprint 04) board.Nov 28 2023, 11:25 AM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Nov 28 2023, 12:00 PM

phuedx mentioned this in T309602: VisualEditorFeatureUse Migration to MP.Nov 28 2023, 12:28 PM

phuedx updated the task description. (Show Details)Nov 28 2023, 12:31 PM

Change 977986 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove partial migration of VisualEditorFeatureUse instrument

https://gerrit.wikimedia.org/r/977986

Mentioned in SAL (#wikimedia-operations) [2023-11-28T14:41:49Z] <lucaswerkmeister-wmde@deploy2002> Started scap: Backport for [[gerrit:977986|Remove partial migration of VisualEditorFeatureUse instrument (T351337)]]

Mentioned in SAL (#wikimedia-operations) [2023-11-28T14:43:10Z] <lucaswerkmeister-wmde@deploy2002> sfaci and lucaswerkmeister-wmde: Backport for [[gerrit:977986|Remove partial migration of VisualEditorFeatureUse instrument (T351337)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-11-28T14:52:07Z] <lucaswerkmeister-wmde@deploy2002> Finished scap: Backport for [[gerrit:977986|Remove partial migration of VisualEditorFeatureUse instrument (T351337)]] (duration: 10m 17s)

Maintenance_bot removed a project: Patch-For-Review.Nov 28 2023, 3:10 PM

phuedx moved this task from To Deploy to Done on the Data Products (Data Products Sprint 04) board.Nov 29 2023, 9:54 AM

phuedx set the point value for this task to 3.

phuedx updated the task description. (Show Details)Dec 7 2023, 10:57 AM

phuedx added a parent task: T352969: Deprecate and remove MetricsClient#dispatch().

phuedx updated the task description. (Show Details)Dec 7 2023, 11:02 AM

Being bold.

mpopov mentioned this in T320281: Instrumentation Data-QA for event.mediawiki_edit_attempt.Feb 5 2024, 8:59 PM

mpopov mentioned this in T309013: EditAttemptStep Migration to (monoschema) MP.Feb 5 2024, 9:05 PM