Page MenuHomePhabricator
Create Task
Maniphest T351335

Remove partial migration of EditAttemptStep instrument
Closed, ResolvedPublic
Actions

Description

Description

There is a partial migration of the EditAttemptStep instrument to the MP client library. It uses dispatch(), which is now deprecated in favour of submitInteraction(). We should remove the partial migration of the instrument to minimise our own maintenance burden.

Acceptance criteria

Completion checklist

  • Documentation updated and conforms to the accessiblity guide?
    • e.g. see the WikimediaEvents/OWNERS.md file and/or the DocBlocks at the tops of the files listed above
  • Mark mediawiki.edit_attempt event stream as deprecated in DataHub
  • Mark event.mediawiki_edit_attempt Hive table as deprecated in DataHub

Details

SubjectRepoBranchLines +/-
Remove partial migration of EditAttemptStep instrumentoperations/mediawiki-configmaster+0 -47
Remove partial migration of EditAttemptStep instrumentmediawiki/extensions/WikimediaEventsmaster+0 -45
Remove partial migration of EditAttemptStep instrumentmediawiki/extensions/WikiEditormaster+0 -38
Customize query in gerrit

Related Objects
Search...

Event Timeline

phuedx created this task.Nov 15 2023, 6:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2023, 6:00 PM
phuedx updated the task description. (Show Details)Nov 15 2023, 6:00 PM
phuedx updated the task description. (Show Details)Nov 15 2023, 6:07 PM
phuedx moved this task from Backlog to Instruments on the Metrics Platform Backlog board.
phuedx updated the task description. (Show Details)Nov 16 2023, 9:44 PM
phuedx added a project: good first task.Nov 24 2023, 6:10 AM
VirginiaPoundstone edited projects, added Data Products (Data Products Sprint 04); removed Data Products.Nov 27 2023, 3:08 PM
VirginiaPoundstone triaged this task as Medium priority.Nov 27 2023, 8:09 PM
phuedx edited projects, added Data Products (Data Products Sprint 05); removed Data Products (Data Products Sprint 04).Dec 7 2023, 10:54 AM
phuedx added a parent task: T352969: Deprecate and remove MetricsClient#dispatch().
Sfaci claimed this task.Dec 12 2023, 9:02 AM
Sfaci moved this task from Sprint Backlog to In Process on the Data Products (Data Products Sprint 05) board.
gerritbot added a comment.Dec 12 2023, 5:03 PM

Change 982438 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[mediawiki/extensions/WikimediaEvents@master] Remove partial migration of EditAttemptStep instrument

https://gerrit.wikimedia.org/r/982438

gerritbot added a project: Patch-For-Review.Dec 12 2023, 5:03 PM

Change 982439 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[mediawiki/extensions/WikiEditor@master] Remove partial migration of EditAttemptStep instrument

https://gerrit.wikimedia.org/r/982439

Sfaci updated the task description. (Show Details)Dec 12 2023, 7:35 PM
Sfaci updated the task description. (Show Details)Dec 12 2023, 8:36 PM
gerritbot added a comment.Dec 12 2023, 8:41 PM

Change 982467 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/mediawiki-config@master] Remove partial migration of EditAttemptStep instrument

https://gerrit.wikimedia.org/r/982467

Sfaci added a comment.Dec 12 2023, 8:47 PM

The following are the changes that have been done and are pending review:

Partial migration was removed from WikimediaEvents and WikiEditor extensions:

The related stream (mediawiki.edit_attempt) was removed from mediawiki-config:

Sfaci reassigned this task from Sfaci to phuedx.Dec 12 2023, 8:48 PM
Sfaci moved this task from In Process to Code Review / Tech Input on the Data Products (Data Products Sprint 05) board.
Sfaci subscribed.
phuedx updated the task description. (Show Details)Dec 13 2023, 8:55 AM
gerritbot added a comment.Dec 13 2023, 8:57 AM

Change 982438 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Remove partial migration of EditAttemptStep instrument

https://gerrit.wikimedia.org/r/982438

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Dec 13 2023, 9:00 AM
phuedx updated the task description. (Show Details)Dec 13 2023, 9:02 AM
phuedx moved this task from Code Review / Tech Input to To Deploy on the Data Products (Data Products Sprint 05) board.Dec 13 2023, 9:04 AM
gerritbot added a comment.Dec 13 2023, 9:13 AM

Change 982439 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Remove partial migration of EditAttemptStep instrument

https://gerrit.wikimedia.org/r/982439

gerritbot added a comment.Jan 8 2024, 2:08 PM

Change 982467 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove partial migration of EditAttemptStep instrument

https://gerrit.wikimedia.org/r/982467

Stashbot mentioned this in T353680: Android Metrics Platform Migration Data Validation - first pass - first 4 tables.Jan 8 2024, 2:12 PM
Stashbot mentioned this in T353297: Empty tables for mediawiki_web_ui_scroll_migrated and mediawiki_web_ui_actions.

Mentioned in SAL (#wikimedia-operations) [2024-01-08T14:12:57Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:987159|Add agent.app_install_id to android.product_metrics.* streams (T353680)]], [[gerrit:982467|Remove partial migration of EditAttemptStep instrument (T351335)]], [[gerrit:982903|Add new stream names to the config variable (T353297)]]

Stashbot added a comment.Jan 8 2024, 2:14 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T14:14:43Z] <urbanecm@deploy2002> urbanecm and phuedx and ksarabia and sfaci: Backport for [[gerrit:987159|Add agent.app_install_id to android.product_metrics.* streams (T353680)]], [[gerrit:982467|Remove partial migration of EditAttemptStep instrument (T351335)]], [[gerrit:982903|Add new stream names to the config variable (T353297)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

phuedx updated the task description. (Show Details)Jan 8 2024, 2:28 PM
phuedx moved this task from To Deploy to Done on the Data Products (Data Products Sprint 05) board.
Maintenance_bot removed a project: Patch-For-Review.Jan 8 2024, 2:31 PM
Stashbot added a comment.Jan 8 2024, 2:35 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T14:35:48Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:987159|Add agent.app_install_id to android.product_metrics.* streams (T353680)]], [[gerrit:982467|Remove partial migration of EditAttemptStep instrument (T351335)]], [[gerrit:982903|Add new stream names to the config variable (T353297)]], [[gerrit:988504|agent.app_ -> agent_app_ in android.product_metrics.* streams (T353680)]]

Stashbot added a comment.Jan 8 2024, 2:37 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T14:37:14Z] <urbanecm@deploy2002> urbanecm and phuedx and ksarabia and sfaci: Backport for [[gerrit:987159|Add agent.app_install_id to android.product_metrics.* streams (T353680)]], [[gerrit:982467|Remove partial migration of EditAttemptStep instrument (T351335)]], [[gerrit:982903|Add new stream names to the config variable (T353297)]], [[gerrit:988504|agent.app_ -> agent_app_ in android.product_metrics.* streams (T353680)]] synce

Stashbot added a comment.Jan 8 2024, 2:46 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T14:46:11Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:987159|Add agent.app_install_id to android.product_metrics.* streams (T353680)]], [[gerrit:982467|Remove partial migration of EditAttemptStep instrument (T351335)]], [[gerrit:982903|Add new stream names to the config variable (T353297)]], [[gerrit:988504|agent.app_ -> agent_app_ in android.product_metrics.* streams (T353680)]] (duration: 10m 22s)

phuedx closed this task as Resolved.Jan 9 2024, 5:03 PM

Being bold.

MNeisler mentioned this in T353911: iOS and Android - Explore adding app_install_id with edit data sent to Editattemptstep.Jan 10 2024, 8:52 PM
mpopov mentioned this in T320281: Instrumentation Data-QA for event.mediawiki_edit_attempt.Feb 5 2024, 8:59 PM
mpopov mentioned this in T309013: EditAttemptStep Migration to (monoschema) MP.Feb 5 2024, 9:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL