| kostajh | |
| Mar 15 2023, 8:59 PM |
| F36916950: Screen Shot 2023-03-17 at 1.58.33 PM.png | |
| Mar 17 2023, 9:25 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
What should have happened instead?:
Software version (skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | KStoller-WMF | T248330 [EPIC] Growth: Positive reinforcement | |||
| Open | None | T317813 [EPIC] Positive Reinforcement: Leveling Up | |||
| Resolved | kostajh | T322386 Leveling up: "Try a new task" dialog | |||
| Resolved | BUG REPORT | Tgr | T332227 Leveling up: Try new task panel does not display for edits made with source editor |
Change 899929 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Leveling up: always set wgGELevelingUpEnabledForUser
Change 899929 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Leveling up: always set wgGELevelingUpEnabledForUser
Change 899605 had a related patch set uploaded (by Kosta Harlan; author: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.27] Leveling up: always set wgGELevelingUpEnabledForUser
Change 899605 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.27] Leveling up: always set wgGELevelingUpEnabledForUser
Mentioned in SAL (#wikimedia-operations) [2023-03-16T08:27:42Z] <kharlan@deploy2002> Started scap: Backport for [[gerrit:900126|SuggestedEditSession: Fix handling of post-save data refresh]], [[gerrit:899605|Leveling up: always set wgGELevelingUpEnabledForUser (T332227)]]
Mentioned in SAL (#wikimedia-operations) [2023-03-16T08:29:15Z] <kharlan@deploy2002> kharlan: Backport for [[gerrit:900126|SuggestedEditSession: Fix handling of post-save data refresh]], [[gerrit:899605|Leveling up: always set wgGELevelingUpEnabledForUser (T332227)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet
Mentioned in SAL (#wikimedia-operations) [2023-03-16T08:40:13Z] <kharlan@deploy2002> Finished scap: Backport for [[gerrit:900126|SuggestedEditSession: Fix handling of post-save data refresh]], [[gerrit:899605|Leveling up: always set wgGELevelingUpEnabledForUser (T332227)]] (duration: 12m 30s)
Testing on testwiki wmf.27 - the post-edit dialog is not displayed after the 5th wiki text edit; the Console displays the following warning:
jQuery.Deferred exception: Cannot read properties of null (reading 'indexOf') TypeError: Cannot read properties of null (reading 'indexOf')
at Object.setupTryNewTaskPanel (<anonymous>:5:803)
at <anonymous>:9:525
at mightThrow (https://test.wikipedia.org/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cvue&skin=vector-2022&version=cnj1r:49:881)
at process (https://test.wikipedia.org/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cvue&skin=vector-2022&version=cnj1r:50:544) undefinedIn the addition to the above comment - the scenarios when no post-edit dialog would be displayed (kind of cumbersome to reproduce).
| Scenario | Post-edit dialog displayed? | Console warning |
|---|---|---|
| (1) Five Suggested edits made with wikitext editor | the post-edit dialog is displayed after each of four edits; after the fifth edit - the post-edit dialog is not displayed | TypeError: Cannot read properties of null (reading 'indexOf')... |
| (2) after performing scenario (1) perform a wikitext edit for the same task type | Not displayed | the same |
| (3) mix of VE edits (the post-edit dialog is displayed after VE edits) and a wikitext edit as the last one (the fifth) | Not displayed | the same |
Testing notes (to check after the fix):
That appears to be the same issue as T332309: Uncaught TypeError: can't access property "difficulty", this.taskType is undefined.
The original issue reported here was fixed by the above patch. The issue @Etonkovidova has documented is tracked in T332309: Uncaught TypeError: can't access property "difficulty", this.taskType is undefined and is already fixed, just awaiting a backport to wmf.27, which I'll do later today.
Checked all scenarios in https://phabricator.wikimedia.org/T332227#8706581 on testwiki wmf.27 - all works as expected. Thx, @kostajh!