Uncaught TypeError: can't access property "difficulty", this.taskType is undefined
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	kostajh
	Mar 16 2023, 1:11 PM

Description

Steps to replicate the issue (include links if applicable):

Complete 5 copyedit tasks on testwiki
Click "Try new task" when prompted to try "links"

What happens?:

Uncaught TypeError: can't access property "difficulty", this.taskType is undefined
   buildCard https://test.wikipedia.org/w/index.php?title=Wright_&_Wright_Architects&gesuggestededit=1 line 10 > injectedScript:28
   SmallTaskCard https://test.wikipedia.org/w/index.php?title=Wright_&_Wright_Architects&gesuggestededit=1 line 10 > injectedScript:26
   getCard https://test.wikipedia.org/w/index.php?title=Wright_&_Wright_Architects&gesuggestededit=1 line 10 > injectedScript:15
   updateTask https://test.wikipedia.org/w/index.php?title=Wright_&_Wright_Architects&gesuggestededit=1 line 10 > injectedScript:16
   updateNextTask https://test.wikipedia.org/w/index.php?title=Wright_&_Wright_Architects&gesuggestededit=1 line 10 > injectedScript:17

The failing code:

$taskType = $('<span>').addClass('mw-ge-small-task-card-tasktype').addClass('mw-ge-small-task-card-tasktype-difficulty-' + this.taskType.difficulty).prepend(new OO.ui.IconWidget({
              icon: 'difficulty-' + this.taskType.difficulty
            }).$element);

The post-edit dialog appears in a "loading" state.

What should have happened instead?:

The post-edit dialog should contain "links" tasks.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

	Subject	Repo	Branch	Lines +/-
	LevelingUpManager: Handle links/link-recommendation collision	mediawiki/extensions/GrowthExperiments	wmf/1.40.0-wmf.27	+46 -4
	LevelingUpManager: Handle links/link-recommendation collision	mediawiki/extensions/GrowthExperiments	master	+46 -4

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		KStoller-WMF	T248330 [EPIC] Growth: Positive reinforcement
Open		None	T317813 [EPIC] Positive Reinforcement: Leveling Up
Resolved		kostajh	T322386 Leveling up: "Try a new task" dialog
Resolved	BUG REPORT	kostajh	T332309 Uncaught TypeError: can't access property "difficulty", this.taskType is undefined

Event Timeline

kostajh created this task.Mar 16 2023, 1:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2023, 1:11 PM

kostajh triaged this task as High priority.Mar 16 2023, 1:11 PM

kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

kostajh updated the task description. (Show Details)

Seems like a consequence of rEGREf323bd17781e: Post edit panel: do not wait for tasks request to show the panel; this.taskType is only set if config.task is supplied, and that is now optional, but in buildCard, we only check for config.task.

In T332309#8702171, @kostajh wrote:

Seems like a consequence of rEGREf323bd17781e: Post edit panel: do not wait for tasks request to show the panel; this.taskType is only set if config.task is supplied, and that is now optional, but in buildCard, we only check for config.task.

Hmm, maybe it is not related to that, because I can't reproduce locally. One thing that is suspicious is that I am being prompted to try "links", but that is not an active task type on testwiki:

The query (https://test.wikipedia.org/w/api.php?action=query&format=json&meta=growthnextsuggestedtasktype&formatversion=2&gnsttactivetasktype=copyedit) to get the next suggested task type looks at all task types, but I suspect needs to be modified to ensure that it only returns active task types as suggestions:

{
    "batchcomplete": true,
    "query": {
        "growthnextsuggestedtasktype": null,
        "editcountbytasktype": {
            "copyedit": 10,
            "expand": 0,
            "image-recommendation": 7,
            "link-recommendation": 25,
            "links": 0,
            "references": 0,
            "update": 0
        }
    }
}

In T332309#8702524, @kostajh wrote:
In T332309#8702171, @kostajh wrote:

Seems like a consequence of rEGREf323bd17781e: Post edit panel: do not wait for tasks request to show the panel; this.taskType is only set if config.task is supplied, and that is now optional, but in buildCard, we only check for config.task.

Hmm, maybe it is not related to that, because I can't reproduce locally. One thing that is suspicious is that I am being prompted to try "links", but that is not an active task type on testwiki:

The query (https://test.wikipedia.org/w/api.php?action=query&format=json&meta=growthnextsuggestedtasktype&formatversion=2&gnsttactivetasktype=copyedit) to get the next suggested task type looks at all task types, but I suspect needs to be modified to ensure that it only returns active task types as suggestions:
{
    "batchcomplete": true,
    "query": {
        "growthnextsuggestedtasktype": null,
        "editcountbytasktype": {
            "copyedit": 10,
            "expand": 0,
            "image-recommendation": 7,
            "link-recommendation": 25,
            "links": 0,
            "references": 0,
            "update": 0
        }
    }
}

Ah, I think this is happening because we don't mark links as disabled, but instead swap it out with link-recommendation when that is available. (We did that for A/B testing purposes.) So when PageConfigurationLoader::parseTaskTypesFromConfig gets the config, it adds the disabled task type to the list.

We either need to make links disabled everywhere that link-recommendation is enabled, or find some other way to special case the way we handle links / link-recommendation in LevelingUpManager.

kostajh added a parent task: T332317: Leveling Up: Release blockers.Mar 16 2023, 2:43 PM

MShilova_WMF subscribed.Mar 16 2023, 2:44 PM

After going through the steps to reproduce once and seeing the described error I'm not longer able to reproduce the error because I get a different one:

jQuery.Deferred exception: Cannot read properties of null (reading 'indexOf') TypeError: Cannot read properties of null (reading 'indexOf')
    at Object.setupTryNewTaskPanel (<anonymous>:5:803)
    at <anonymous>:9:525
    at mightThrow (https://test.wikipedia.org/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cvue&skin=vector-2022&version=cnj1r:49:881)
    at process (https://test.wikipedia.org/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cvue&skin=vector-2022&version=cnj1r:50:544) undefined

Might be unrelated or not worth investigating since it happens after the first exception but pasting it for awareness.

In T332309#8702729, @Sgs wrote:
After going through the steps to reproduce once and seeing the described error I'm not longer able to reproduce the error because I get a different one:
jQuery.Deferred exception: Cannot read properties of null (reading 'indexOf') TypeError: Cannot read properties of null (reading 'indexOf')
    at Object.setupTryNewTaskPanel (<anonymous>:5:803)
    at <anonymous>:9:525
    at mightThrow (https://test.wikipedia.org/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cvue&skin=vector-2022&version=cnj1r:49:881)
    at process (https://test.wikipedia.org/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cvue&skin=vector-2022&version=cnj1r:50:544) undefined
Might be unrelated or not worth investigating since it happens after the first exception but pasting it for awareness.

That should be fixed by rEGREd38c4566b2de: TryNewTask: Set an array fallback if TryNewTaskOptOuts is null.

Change 900418 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] LevelingUpManager: Handle links/link-recommendation collision

https://gerrit.wikimedia.org/r/900418

gerritbot added a project: Patch-For-Review.Mar 16 2023, 6:38 PM

kostajh claimed this task.Mar 16 2023, 6:38 PM

kostajh moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Tgr mentioned this in T332348: Clean up Add Link / Add Image A/B test logic in GrowthExperiments.Mar 16 2023, 6:51 PM

KStoller-WMF moved this task from Backlog to Week 7 (Mar 13 - Mar 17) on the GrowthExperiments-LevelingUp board.Mar 17 2023, 6:07 PM

Change 900418 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] LevelingUpManager: Handle links/link-recommendation collision

https://gerrit.wikimedia.org/r/900418

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 17 2023, 8:52 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 17 2023, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 17 2023, 9:10 PM

Change 900684 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.27] LevelingUpManager: Handle links/link-recommendation collision

https://gerrit.wikimedia.org/r/900684

gerritbot added a project: Patch-For-Review.Mar 20 2023, 6:56 AM

kostajh mentioned this in T332227: Leveling up: Try new task panel does not display for edits made with source editor.Mar 20 2023, 8:14 AM

Change 900684 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.27] LevelingUpManager: Handle links/link-recommendation collision

https://gerrit.wikimedia.org/r/900684

Maintenance_bot removed a project: Patch-For-Review.Mar 20 2023, 8:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-03-20T20:47:50Z] <kharlan@deploy2002> Started scap: Backport for [[gerrit:901146|TryNewTask: Set an array fallback if TryNewTaskOptOuts is null]], [[gerrit:900685|PostEdit: Increment the edit-count-for-task-type count (T332319)]], [[gerrit:900684|LevelingUpManager: Handle links/link-recommendation collision (T332309)]]

Mentioned in SAL (#wikimedia-operations) [2023-03-20T20:49:27Z] <kharlan@deploy2002> kharlan: Backport for [[gerrit:901146|TryNewTask: Set an array fallback if TryNewTaskOptOuts is null]], [[gerrit:900685|PostEdit: Increment the edit-count-for-task-type count (T332319)]], [[gerrit:900684|LevelingUpManager: Handle links/link-recommendation collision (T332309)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmn

Mentioned in SAL (#wikimedia-operations) [2023-03-20T20:58:18Z] <kharlan@deploy2002> Finished scap: Backport for [[gerrit:901146|TryNewTask: Set an array fallback if TryNewTaskOptOuts is null]], [[gerrit:900685|PostEdit: Increment the edit-count-for-task-type count (T332319)]], [[gerrit:900684|LevelingUpManager: Handle links/link-recommendation collision (T332309)]] (duration: 10m 28s)

This change is now in wmf.27, so removing from release blockers. cc @Etonkovidova

kostajh removed a parent task: T332317: Leveling Up: Release blockers.Mar 20 2023, 9:00 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.27; 2023-03-13).Mar 20 2023, 9:00 PM

In T332309#8711851, @kostajh wrote:

This change is now in wmf.27, so removing from release blockers. cc @Etonkovidova

Thx, @kostajh! Checked on testwiki wmf.27 (along with T332227) - the issue has been fixed.

Urbanecm_WMF removed a subscriber: MShilova_WMF.Jul 31 2023, 6:02 PM

	F36914562: image.png
	Mar 16 2023, 2:34 PM

Uncaught TypeError: can't access property "difficulty", this.taskType is undefinedClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related ObjectsSearch...

Event Timeline

Uncaught TypeError: can't access property "difficulty", this.taskType is undefined
Closed, ResolvedPublicBUG REPORT
Actions

Related Objects
Search...