Page MenuHomePhabricator
Create Task
Maniphest T343920

Minerva Codex migration: Use Codex
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To
None
Authored By
Jdlrobson
Aug 9 2023, 7:07 PM
Tags
Referenced Files
F37670750: screenshot 12.png
Sep 8 2023, 12:57 AM
F37670749: screenshot 13.png
Sep 8 2023, 12:57 AM
F37670745: screenshot 3.mov.gif
Sep 8 2023, 12:57 AM
F37670746: screenshot 2.mov.gif
Sep 8 2023, 12:57 AM
F37641661: Screen Recording 2023-08-29 at 9.27.27 AM.mov.gif
Aug 30 2023, 2:11 AM
F37641660: Screen Recording 2023-08-29 at 9.26.23 AM.mov.gif
Aug 30 2023, 2:11 AM
F37641659: Screen Recording 2023-08-29 at 9.25.36 AM.mov.gif
Aug 30 2023, 2:11 AM
F37641658: Screen Recording 2023-08-29 at 9.26.00 AM.mov.gif
Aug 30 2023, 2:11 AM
Subscribers
Aklapper
bwang
Edtadros
Jdlrobson
Jdrewniak
Masumrezarock100

Description

Following the preparation work done in the previous sprint we should be in a good place to update Minerva to use Codex

TODO

  • Update icon packs to target the new icon selectors as well as the existing selectors.
  • Drop mw-ui-icon-with-label-desktop selector. It doesn't apply in the new mode.
  • Update SkinMinerva::getSkinStyles() - Make sure mediawiki.ui.button and mediawiki.ui.icon are not added to the page and codex-search-styles is.
  • Ensure elements are flushed correctly (the flush selectors were tied to the old selectors)
  • Update Button.mustache
  • Remove IconLegacy and update existing references to Icon.mustache

QA

  • Check the section toggles work
  • Check the edit section button works
  • Test T343919 and resolve the ticket if fixed.
  • Make sure you have notifications and the red circle shows with a white number inside. Make sure this looks correct.

QA Results - Beta

ACStatusDetails
1✅T343920#9129352
2✅T343920#9129352
3✅T343920#9129352
4✅T343920#9143574

QA Results - Prod

ACStatusDetails
1✅T343920#9151431
2✅T343920#9151431
3✅T343920#9151431
4✅T343920#9151431

Details

SubjectRepoBranchLines +/-
Make menuGroup.mustache use togglelist classes, ensuring ToggleList HTML is consistent. Remove duplicated CSSmediawiki/skins/MinervaNeuemaster+44 -90
Use !important for removing aftermediawiki/skins/MinervaNeuemaster+2 -1
WIP: Switch Minerva to Codexmediawiki/skins/MinervaNeuemaster+27 -19
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Aug 9 2023, 7:07 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptAug 9 2023, 7:07 PM
Jdlrobson triaged this task as High priority.Aug 9 2023, 7:07 PM
Jdlrobson mentioned this in T343919: Performance regression: reflow of section headings.Aug 9 2023, 7:10 PM
Jdlrobson updated the task description. (Show Details)Aug 9 2023, 9:31 PM
Jdlrobson updated the task description. (Show Details)Aug 9 2023, 9:44 PM
gerritbot added a comment.Aug 9 2023, 10:31 PM

Change 947472 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Use !important for removing after

https://gerrit.wikimedia.org/r/947472

gerritbot added a project: Patch-For-Review.Aug 9 2023, 10:31 PM

Change 947475 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] WIP: Switch Minerva to Codex

https://gerrit.wikimedia.org/r/947475

gerritbot added a comment.Aug 9 2023, 10:55 PM

Change 947475 abandoned by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] WIP: Switch Minerva to Codex

Reason:

See https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/940251/

https://gerrit.wikimedia.org/r/947475

Izno added a project: MinervaNeue.Aug 10 2023, 12:53 AM
Jdlrobson renamed this task from Minerva should use Codex to Minerva Codex migration: Use Codex.Aug 10 2023, 4:59 PM
Jdlrobson mentioned this in T344006: Minerva Codex migration: Add support for gadget developers with new Codex markup.
Jdlrobson mentioned this in T344007: Minerva Codex migration: section edit buttons should use Button template.
ovasileva set the point value for this task to 5.Aug 10 2023, 5:20 PM
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4) board.
gerritbot added a comment.Aug 10 2023, 9:10 PM

Change 947472 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Use !important for removing after

https://gerrit.wikimedia.org/r/947472

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2023, 9:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 10 2023, 10:01 PM
Jdlrobson updated the task description. (Show Details)Aug 10 2023, 11:25 PM
Jdlrobson lowered the priority of this task from High to Medium.Aug 11 2023, 10:22 PM
bwang claimed this task.Aug 16 2023, 10:13 PM
bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4) board.
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4) board.Aug 18 2023, 5:10 PM
bwang removed bwang as the assignee of this task.Aug 18 2023, 5:16 PM
bwang subscribed.
bwang updated the task description. (Show Details)Aug 18 2023, 5:22 PM
ovasileva raised the priority of this task from Medium to High.Aug 22 2023, 4:36 PM
bwang assigned this task to Jdrewniak.Aug 22 2023, 4:37 PM
gerritbot added a comment.Aug 25 2023, 5:57 PM

Change 950043 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Make menuGroup.mustache use togglelist classes, ensuring ToggleList HTML is consistent. Remove duplicated CSS

https://gerrit.wikimedia.org/r/950043

gerritbot added a project: Patch-For-Review.Aug 25 2023, 5:57 PM
bwang added a comment.Aug 25 2023, 6:00 PM

I tagged the wrong ticket on the associated patches, they were:

https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/940251
https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/950044
https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/950043

gerritbot added a comment.Aug 25 2023, 6:19 PM

Change 950043 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Make menuGroup.mustache use togglelist classes, ensuring ToggleList HTML is consistent. Remove duplicated CSS

https://gerrit.wikimedia.org/r/950043

Maintenance_bot removed a project: Patch-For-Review.Aug 25 2023, 6:30 PM
Jdrewniak reassigned this task from Jdrewniak to Edtadros.Aug 28 2023, 3:54 PM
Jdrewniak moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4) board.
Jdrewniak subscribed.
Edtadros reassigned this task from Edtadros to Jdrewniak.EditedAug 30 2023, 2:11 AM
Edtadros subscribed.

Test Result - Beta

Status: ❌ FAIL
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Check the section toggles work

Screen Recording 2023-08-29 at 9.26.00 AM.mov.gif (914×866 px, 602 KB)

Screen Recording 2023-08-29 at 9.25.36 AM.mov.gif (914×866 px, 370 KB)

✅ AC2: Check the edit section button works

Screen Recording 2023-08-29 at 9.26.23 AM.mov.gif (914×866 px, 1 MB)

✅ AC3: Test T343919 and resolve the ticket if fixed.
See T343919#9112004

❌ AC4: Make sure you have notifications and the red circle shows with a white number inside. Make sure this looks correct.
There is no red around the notifications

Screen Recording 2023-08-29 at 9.27.27 AM.mov.gif (914×866 px, 1 MB)

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.25; 2023-09-05); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 30 2023, 3:01 AM
Jdlrobson moved this task from QA to QA in Production on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4) board.Sep 5 2023, 5:35 PM

AC4: This is tracked in https://phabricator.wikimedia.org/T345483

Edtadros claimed this task.Sep 5 2023, 5:40 PM
Edtadros closed this task as Resolved.Sep 8 2023, 12:57 AM
Edtadros removed Edtadros as the assignee of this task.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Check the section toggles work

screenshot 2.mov.gif (1×2 px, 3 MB)

✅ AC2: Check the edit section button works

screenshot 3.mov.gif (1×2 px, 1 MB)

✅ AC3: Test T343919 and resolve the ticket if fixed.
See T343919#9112004

✅ AC4: Make sure you have notifications and the red circle shows with a white number inside. Make sure this looks correct.

screenshot 13.png (1×2 px, 416 KB)

screenshot 12.png (1×2 px, 613 KB)

Edtadros updated the task description. (Show Details)Sep 8 2023, 1:00 AM
Edtadros closed subtask T344006: Minerva Codex migration: Add support for gadget developers with new Codex markup as Resolved.Sep 8 2023, 9:08 PM
Jdlrobson closed subtask T344007: Minerva Codex migration: section edit buttons should use Button template as Resolved.Sep 8 2023, 11:54 PM
Edtadros reopened subtask T344007: Minerva Codex migration: section edit buttons should use Button template as Open.Sep 9 2023, 12:04 AM
Jdlrobson closed subtask T344007: Minerva Codex migration: section edit buttons should use Button template as Resolved.Sep 11 2023, 5:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL