Delete technischewuensche tool code repository in Diffusion
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Aklapper
	Oct 26 2023, 5:05 PM

Description

The codebase for https://toolsadmin.wikimedia.org/tools/id/technischewuensche at https://phabricator.wikimedia.org/diffusion/3019/ cannot be viewed by public due to having been moved to a private Phabricator Space.

IMO this violates the spirit that "The Toolforge rules include publishing your code under an OSI approved open source license.", and probably blocked migration of the code repository to GitLab in T315706#8219209.

Are there particular reasons this code is not public?
If not, could you please set the View Policy shown as "Visible To" on https://phabricator.wikimedia.org/diffusion/3019/manage/policies/ to "S1 Public"? Thanks in advance!

(Note to myself: Found while looking into T191182: Migrate active repositories in Phabricator Differential to GitLab)

Related Objects
Search...

Status	Assigned	Task
Open	None	T330844 Avoid to have too much different places (like Gerrit, GitHub, Differential, GitLab, ...) where code review may take place to help newcomers
Resolved	Aklapper	T342041 Remove custom src/customfields/DifferentialApplyPatchWithOnlyGitField.php
Resolved	Aklapper	T330797 Uninstall Differential (Phabricator application)
Resolved	Aklapper	T324131 Remove "Active Differential users" stats from monthly community_metrics.sh email
Resolved	Aklapper	T191182 Migrate active repositories in Phabricator Differential to GitLab
Resolved	Aklapper	T349847 Delete technischewuensche tool code repository in Diffusion
Resolved	None	T350352 Check technischewuensche tool code and publish in a public repo

Event Timeline

Aklapper created this task.Oct 26 2023, 5:05 PM

Aklapper mentioned this in T191182: Migrate active repositories in Phabricator Differential to GitLab.Oct 27 2023, 12:54 PM

WMDE-Fisch added a project: WMDE-TechWish-Maintenance-2023.Oct 30 2023, 5:56 PM

WMDE-Fisch moved this task from Incoming to In progress on the WMDE-TechWish-Maintenance board.

WMDE-Fisch claimed this task.Nov 1 2023, 11:11 AM

WMDE-Fisch moved this task from Backlog to Doing on the WMDE-TechWish-Maintenance-2023 board.

Hej @Aklapper and thanks for the ping. Honestly the repo is not really actively used by WMDE-TechWish . A former colleague once backed-up the state of the tool there and I guess we set it private because we were unsure if there's private data that should not be shared publicly.

The information that there's this repo got lost somehow and the last updates and changes to the tool completely ignored the repo.

Because of all this I would rather want the Phab repo to be wiped and start using GitLab in the first place with a new re-viewed submission of the code that can be shared.

So if that's understandable and possible, would you be so kind to do the former? Then we'll take care of the latter.

WMDE-Fisch added subscribers: JStrodt_WMDE, awight, thiemowmde.Nov 1 2023, 11:22 AM

Dzahn subscribed.Nov 1 2023, 5:17 PM

@WMDE-Fisch: Before I attempt to delete (not sure if being in a Space will get into the way though I think it's unlikely), can you explicitly confirm that you have a (more recent) codebase located anywhere else (as I won't have a backup)? Thanks!

and start using GitLab in the first place with a new re-viewed submission of the code that can be shared.

Let's make that a separate task please :)

I think there is only the live copy on https://technischewuensche.toolforge.org. Might be better to push it to GitLab first (to the WMF instance?) before we delete it here.

It would be easy to import it into WMF Gitlab just by pasting the URL... IF... we could make it public.

If there are concerns about making it public.. then we can't import it into GitLab, right?

If there are no concerns about making it public.. then we don't need to delete it on Phab.

How large is it? Is it really that much work to check for private data?

How large is it? Is it really that much work to check for private data?

I'd say that's irrelevant. Statement was that folks are unsure if there's private data. So that's about to get checked. No matter how much work that might be.

We're taking care if it. I created a subticket and when that's done we can delete the deprecated source. Thanks again for bringing this to our attention :-).

WMDE-Fisch moved this task from Doing to Watching / Epic on the WMDE-TechWish-Maintenance-2023 board.Nov 2 2023, 10:08 AM

Aklapper changed the task status from Open to Stalled.Nov 26 2023, 3:13 PM

This can be done now. Please go forward with it. The relevant code is backed up and moved to different repos. Feel free to skip some steps and uninstall Differential if that has the same effect and we're the only leftovers.

thanks for that, WMDE-Fisch

Thanks!

Per https://wikitech.wikimedia.org/wiki/Phabricator#Remove_a_repo ,

aklapper@phab1004:~$ sudo /srv/phab/phabricator/bin/remove destroy R3019
This object will be destroyed forever:
    - R3019 (PhabricatorRepository) R3019 tool-technischewuensche
    Are you absolutely certain you want to destroy this object? [y/N] y
Destroying objects...
Destroying PhabricatorRepository R3019...
Permanently destroyed 1 object.
      - Database records for repository "tool-technischewuensche" were
        destroyed, but this script does not remove working copies on disk. If
        you also want to destroy the repository working copy, manually remove
        "/srv/repos/3019/".
aklapper@phab1004:~$

WMDE-Fisch closed subtask T350352: Check technischewuensche tool code and publish in a public repo as Resolved.Dec 20 2023, 12:38 PM

Delete technischewuensche tool code repository in DiffusionClosed, ResolvedPublicActions

Description

Related ObjectsSearch...

Event Timeline

Delete technischewuensche tool code repository in Diffusion
Closed, ResolvedPublic
Actions

Related Objects
Search...