[Zebra] Make vector-column-start element cache compatible
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdrewniak
	Nov 22 2023, 4:46 PM

Description

In T323141 we created a new layout container called .vector-column-start for the TOC and Main menu.
This however, was only implemented for compatibility with the Zebra CSS module.
Before merging the zebra module, we should make this new container compatible with the cached, non-zebra version of the HTML.

A/C

When zebra is disabled (?vectorzebradesign=0) and the element .vector-column-start exists in the DOM, the ToC and sidebar still behave as expected
When zebra is disabled (?vectorzebradesign=0) and the element .vector-column-start does not exist in the DOM, the ToC and sidebar still behave as expected

QA steps

not sure how what QA steps are for testing different cached versions of the HTML

Details

	Subject	Repo	Branch	Lines +/-
	[Zebra] Make .vector-column-start cache compatible	mediawiki/skins/Vector	wmf/1.42.0-wmf.7	+6 -12
	[Zebra] Make .vector-column-start cache compatible	mediawiki/skins/Vector	master	+6 -12

Customize query in gerrit

Related Objects

Mentioned In: T347712: [Zebra] remove feature flag & merge Zebra into default styles
T352464: Non zebra scrollable indicators on sticky pinnable elements (toc, page tools, client prefs) are broken
T352432: ToC overlaps with footer in Vector 2022 again
Mentioned Here: T347712: [Zebra] remove feature flag & merge Zebra into default styles
T352464: Non zebra scrollable indicators on sticky pinnable elements (toc, page tools, client prefs) are broken
T323141: [Grid] Combine mainMenu and toc grid areas into columnStart grid areas (toc in sidebar overlaps footer)

Event Timeline

Jdrewniak created this task.Nov 22 2023, 4:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 22 2023, 4:46 PM

Change 976708 had a related patch set uploaded (by Jdrewniak; author: Mabualruz):

[mediawiki/skins/Vector@master] [Zebra] Make .vector-column-start cache compatible

https://gerrit.wikimedia.org/r/976708

gerritbot added a project: Patch-For-Review.Nov 22 2023, 4:47 PM

ovasileva triaged this task as Medium priority.Nov 27 2023, 6:24 PM

ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4); removed Web-Team-Backlog.

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q2 Sprint 5); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4).Nov 30 2023, 5:53 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.Nov 30 2023, 6:11 PM

Will require a backport next week.

ovasileva set the point value for this task to 1.Nov 30 2023, 6:31 PM

bwang mentioned this in T352432: ToC overlaps with footer in Vector 2022 again.Nov 30 2023, 6:43 PM

Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.Dec 4 2023, 8:47 PM

Change 976708 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [Zebra] Make .vector-column-start cache compatible

https://gerrit.wikimedia.org/r/976708

Maintenance_bot removed a project: Patch-For-Review.Dec 4 2023, 11:30 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Dec 5 2023, 1:00 AM

Change 979704 had a related patch set uploaded (by Jdlrobson; author: Mabualruz):

[mediawiki/skins/Vector@wmf/1.42.0-wmf.7] [Zebra] Make .vector-column-start cache compatible

https://gerrit.wikimedia.org/r/979704

gerritbot added a project: Patch-For-Review.Dec 5 2023, 5:47 PM

This will be needed for the Zebra deploy so should be rolled out this week. It improves the footer overlap issue. Kim will backport this today.

Change 979704 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.42.0-wmf.7] [Zebra] Make .vector-column-start cache compatible

https://gerrit.wikimedia.org/r/979704

Mentioned in SAL (#wikimedia-operations) [2023-12-05T21:27:42Z] <jforrester@deploy2002> Started scap: Backport for [[gerrit:979704|[Zebra] Make .vector-column-start cache compatible (T347712 T351830)]], [[gerrit:980467|Fix nonzebra sticky container scrolling behavior and scrollable indicator (T352464)]]

Mentioned in SAL (#wikimedia-operations) [2023-12-05T21:30:00Z] <jforrester@deploy2002> jdlrobson and jforrester and jdrewniak: Backport for [[gerrit:979704|[Zebra] Make .vector-column-start cache compatible (T347712 T351830)]], [[gerrit:980467|Fix nonzebra sticky container scrolling behavior and scrollable indicator (T352464)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Dec 5 2023, 9:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-05T21:40:32Z] <jforrester@deploy2002> Finished scap: Backport for [[gerrit:979704|[Zebra] Make .vector-column-start cache compatible (T347712 T351830)]], [[gerrit:980467|Fix nonzebra sticky container scrolling behavior and scrollable indicator (T352464)]] (duration: 12m 50s)

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.7; 2023-11-28); removed MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Dec 5 2023, 10:00 PM

Jdlrobson reassigned this task from KSarabia-WMF to Edtadros.Dec 6 2023, 1:06 AM

Jdlrobson moved this task from Doing to QA on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.

Jdlrobson added a subscriber: KSarabia-WMF.

@Jdlrobson , I can check the ACs, but unsure what to do regarding the caching mentioned in the QA steps. Please advise.

This can skip QA now as Zebra has been in production for a week with no bug reports.

[Zebra] Make vector-column-start element cache compatibleClosed, ResolvedPublic1 Estimated Story PointsBUG REPORTActions