Page MenuHomePhabricator

Move the reference previews code to Cite extension
Open, LowPublic

Description

Previously: T326692

Now that Popups supports extensibility and has clearly defined stable APIs it would make sense to move reference previews to its own extension - the Cite extension.

TODO

  • Make a decision around whether Webpack should be added to Cite extension or whether the code should be rewritten in ES6-compatible way. Rewrite code if necessary
  • Move module off of Webpack https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/995292/1
  • Prepare module for moving to Cite https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/995312
  • Add new module to Cite. If the module is called ext.cite.referencePreviews, Popups will know to check for it and disable its code when it exists.
  • Define PopupPlugins attribute in Cite extension rather than Popups, pointing to the new module ext.cite.referencePreviews
  • Delete old module in Popups once we're sure we no longer need it.
  • Clean up configuration, messages, and styles which include hardcoded "Popups" identifiers.

Event Timeline

Change 990257 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Drop reference previews from Popups, move to Cite

https://gerrit.wikimedia.org/r/990257

Jdlrobson added a subscriber: awight.

@awight do you have any opinions around whether we should continue using Webpack in the reference previews code? If so, adding Webpack to Cite extension would be a precursor. Once you've made a decision there, I can revise the WIP patch accordingly.

Change 990256 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Cite@master] WIP: Move reference previews to Cite extension

https://gerrit.wikimedia.org/r/990256

@awight @WMDE-Fisch could you provide some guidance on whether you intend to continue to use Webpack in Extension:Cite going forward? Once I know the answer to that, I can make the final preparations in the Popups extension. Thanks in advance.

@awight @WMDE-Fisch could you provide some guidance on whether you intend to continue to use Webpack in Extension:Cite going forward? Once I know the answer to that, I can make the final preparations in the Popups extension. Thanks in advance.

Hey @Jdlrobson, we would like to avoid Webpack as dependency there. So feel free to go on without it.

Change 995292 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Reference previews should no longer use Webpack

https://gerrit.wikimedia.org/r/995292

Change 995312 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Allow Cite to define the reference preview module instead

https://gerrit.wikimedia.org/r/995312

There's a request that our team drive the work forward for a bit, so I'm moving the task to our internal backlog column to make this clear. (Still needs to be discussed and formally prioritized.)

Change 995292 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Reference previews should no longer use Webpack

https://gerrit.wikimedia.org/r/995292

Change 995312 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Allow Cite to define the reference preview module instead

https://gerrit.wikimedia.org/r/995312

Thanks @awight - reach out if you need any help!

Change 1004099 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[integration/config@master] Add Popups to Cite jobs

https://gerrit.wikimedia.org/r/1004099

Change 1004099 merged by jenkins-bot:

[integration/config@master] Add Popups to Cite jobs

https://gerrit.wikimedia.org/r/1004099

Change 990257 abandoned by Jdlrobson:

[mediawiki/extensions/Popups@master] Drop reference previews from Popups, move to Cite

Reason:

WMDE is working on this now.

https://gerrit.wikimedia.org/r/990257

Change 990256 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Move reference previews to Cite extension

https://gerrit.wikimedia.org/r/990256

Change 1012371 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Popups@master] Remove referencePreviews tests

https://gerrit.wikimedia.org/r/1012371

Change 1012371 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Remove referencePreviews tests

https://gerrit.wikimedia.org/r/1012371