Page MenuHomePhabricator

Remove reference previews support from Popups extension
Closed, ResolvedPublic

Description

This should already be migrated to the equivalent module in the Cite extension. However, we need to check some things before migrating:

  • Confirm that the Cite module is used on production. Look for any evidence (eg. Grafana ResourceLoader dashboards) that the Popups module is still being loaded.
  • Check whether the Popups reference previews module is providing any of the necessary styles or other assets. ( some will be dealt with in follow ups )
  • Perhaps use a configuration flag or other mechanism to gradually drop the Popups reference previews module on the Beta Cluster before production.

Event Timeline

Change #1019676 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Internal config variables renamed from Popups to Cite

https://gerrit.wikimedia.org/r/1019676

Change #1019677 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Popups@master] Remove deprecated copy of referencePreviews module

https://gerrit.wikimedia.org/r/1019677

Looks like the usages have successfully been switched over already, so let's just try to drop the Popups duplicate module and see what happens.

Change #1019677 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Remove deprecated copy of referencePreviews module

https://gerrit.wikimedia.org/r/1019677

Change #1019676 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Internal config variables renamed from Popups to Cite

https://gerrit.wikimedia.org/r/1019676

I consider the code work done here. There's more to do but this is about removing the main module. When 1.43.0-wmf.2 is rolled out this will be live and we have some more reassurance .

Nice job y'all! Thanks for prioritizing this!

Yeah we currently run this as a side project but making progress one patch at a time ;-).

Tested on test.wikipedia. Seems all fine. Moving to done for the last sign off.

WMDE-Fisch claimed this task.