Page MenuHomePhabricator

Incorrect Financial Types
Closed, ResolvedPublic

Description

Hi. Been doing some QC on the coding changes we made for this fiscal year.

Financial Type= Endowment Gift should have been retired. The only types we currently use are Cash, In Kind, Stock, Recurring Gift, and Recurring Gift- Cash

Event Timeline

greg triaged this task as Medium priority.Feb 12 2024, 11:26 PM
greg moved this task from Backlog to User Bug Backlog on the Fundraising Tech - Chaos Crew board.

We're still checking for financial_type=Endowment Gift to decide

  • which TY template to send
  • who to notify on large donations
  • how to list donations in the EOY email
  • which fund to count the donation toward in the wmf_donor rollup columns

If we're not using financial type, what is the new way to determine whether a donation is for the Endowment or the annual fund?

@NNichols can you point to some discussion about removing the 'Endowment Gift' financial type? We're using that in a bunch of places to decide how to treat endowment donations.

https://phabricator.wikimedia.org/T343756

Endowment Gift was to be removed and that would be indicated in the Restrictions field on a gift

Hi @NNichols on that ticket it looks like after some back and forth you came around to the idea of keeping the financial type ID: https://phabricator.wikimedia.org/T343756#9120225

I see! Reading is truly fundamental :)
Thank you Elliot. All of those fun conversations about custom fields and tables are coming back to me. My apologies; we did not document this issue in the coding changes briefings.
@Eileenmcnaughton What would it take for this type of change in the future?

@NNichols if we want to remove endowment gift as a financial type we need some other field to denote if a gift is endowment. Importantly this must be a field on the contribution table that is NOT a custom field (as long as we want to consider the value when calculating wmf donor fields then it needs to be populated before we do that calculation). Also it would probably if it were the source field as I think that being a text field not an options field it would be slow

Dwisehaupt set Final Story Points to 1.