Page MenuHomePhabricator

Change line height on Minerva to 1.65 for "Standard" font size
Closed, ResolvedPublic1 Estimated Story Points

Description

Following the outcome of T357770:

Acceptance criteria

  • Change the line-height: 1.5; rule in resources/mobile.init.styles/mobile.less so it only applies to regular and large mode

QA

  • Choose the standard font size in the settings. Check line height of paragraphs - it should be 1.65
  • Choose the medium font size in the settings. Check line height of paragraphs - it should be 1.5
  • Choose the large font size in the settings. Check line height of paragraphs - it should be 1.5

QA Results - Beta

ACStatusDetails
1T358498#9588069
2T358498#9588069
3T358498#9588069

QA Results - Prod

ACStatusDetails
1T358498#9589618
2T358498#9589618
3T358498#9589618

Event Timeline

Jdlrobson renamed this task from Change line height on Minerva to 1.65em to Change line height on Minerva to 1.65.Feb 26 2024, 5:49 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson renamed this task from Change line height on Minerva to 1.65 to Change line height on Minerva to 1.65 for "Standard" font size.Feb 26 2024, 6:26 PM

Change 1006580 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Revert line height in "Standard" mode, apply to all content in other

https://gerrit.wikimedia.org/r/1006580

Change 1006580 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Revert line height in "Standard" mode, apply to all content in other

https://gerrit.wikimedia.org/r/1006580

Edtadros subscribed.

Test Result - Beta

Status:
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Choose the standard font size in the settings. Check line height of paragraphs - it should be 1.65

screenshot 590.png (923×1 px, 463 KB)

❌ AC2: Choose the medium font size in the settings. Check line height of paragraphs - it should be 1.5
it shows 1.4
screenshot 591.png (923×1 px, 472 KB)

❌ AC3: Choose the large font size in the settings. Check line height of paragraphs - it should be 1.5
it shows 1.4
screenshot 592.png (923×1 px, 470 KB)

@Edtadros please check the line height on #bodyContent element instead.

Thanks @Jdlrobson

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Choose the standard font size in the settings. Check line height of paragraphs - it should be 1.65

screenshot 593.png (1×1 px, 728 KB)

✅ AC2: Choose the medium font size in the settings. Check line height of paragraphs - it should be 1.5
screenshot 595.png (1×1 px, 733 KB)

✅ AC3: Choose the large font size in the settings. Check line height of paragraphs - it should be 1.5
screenshot 594.png (1×1 px, 729 KB)

Hello @Edtadros,
For Tech News - What wording would you suggest as the content, and When should it be included? Thanks!

Hello @Edtadros,
For Tech News - What wording would you suggest as the content, and When should it be included? Thanks!

@UOzurumba , I'm not sure I understand the context or the question. Ping me on slack to discuss.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Choose the standard font size in the settings. Check line height of paragraphs - it should be 1.65

screenshot 596.png (979×1 px, 398 KB)

✅ AC2: Choose the medium font size in the settings. Check line height of paragraphs - it should be 1.5
screenshot 597.png (989×1 px, 337 KB)

✅ AC3: Choose the large font size in the settings. Check line height of paragraphs - it should be 1.5
screenshot 598.png (862×1 px, 267 KB)

Hello @Edtadros,
For Tech News - What wording would you suggest as the content, and When should it be included? Thanks!

@UOzurumba - I would suggest: "After consulting with various communities, the line height of the text on the Minerva skin will be increased to its previous value of 1.65. Different options for typography can also be set using the options in the menu, as needed."

Hello @Edtadros,
For Tech News - What wording would you suggest as the content, and When should it be included? Thanks!

@UOzurumba - I would suggest: "After consulting with various communities, the line height of the text on the Minerva skin will be increased to its previous value of 1.65. Different options for typography can also be set using the options in the menu, as needed."

Thanks!