Migrate MediaWiki.media.thumbnail.* to statslib
Open, Needs TriagePublic
Actions

Assigned To

Authored By

	lmata
	Mar 6 2024, 1:22 PM

Description

Follow the migration process as outlined below.

Secure/Conduct code review(s).
Deploy the changes to production via the train (https://wikitech.wikimedia.org/wiki/Deployments/Train).
Verify that the changes have been successfully implemented.
Update the relevant dashboard(s) by replacing the old Graphite metric(s) with the new Prometheus metric(s).
Please follow the guidelines and standards outlined in the provided documentation:

https://www.mediawiki.org/wiki/Manual:Stats for detailed guidance on the conversion process.
https://drive.google.com/file/d/12yQEuOapkML1vb9MgCaX1QzbLBdXE6X2/view for a video tutorial on the conversion process.
https://docs.google.com/presentation/d/1SZWf_D3mWNX-XHN8PHYI84LDZr6GUQC2AMhZ9mQXCI0/edit#slide=id.g2795460c956_0_23 for slides on the best practices for converting metrics to statslib.

MediaWiki.media.thumbnail.stream.* source code
MediaWiki.media.thumbnail.generate.* source code

Details

Subject	Repo	Branch	Lines +/-
Migrate media.thumbnail.stream to statslib	mediawiki/core	master	+4 -2
Migrate media.thumbnail.generate.transform to statslib	mediawiki/core	master	+9 -6
Migrate media.thumbnail.generate.bucket to statslib	mediawiki/core	master	+8 -5
Migrate media.thumbnail.generate.fetchoriginal to statslib	mediawiki/core	master	+11 -4
Migrate media.thumbnail.generate.store to statslib	mediawiki/core	master	+7 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T343020 Converting MediaWiki Metrics to StatsLib
Resolved	herron	T350591 Audit legacy mediawiki stats used in production dashboards
Open	None	T350592 EPIC: migrate in use metrics and dashboards to statslib
Open	Tarrow	T359344 Migrate MediaWiki.media.thumbnail.* to statslib

Event Timeline

lmata created this task.Mar 6 2024, 1:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2024, 1:22 PM

lmata mentioned this in T350592: EPIC: migrate in use metrics and dashboards to statslib.Mar 6 2024, 1:31 PM

colewhite updated the task description. (Show Details)Fri, Apr 26, 4:33 PM

colewhite mentioned this in T363584: Hackathon 2024: Stats!.

colewhite merged a task: T359379: Migrate MediaWiki.media.thumbnail to statslib.Fri, Apr 26, 11:05 PM

Tarrow claimed this task.Sat, May 4, 3:06 PM

Change #1027205 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/core@master] Migrate media.thumbnail.stream to statslib

https://gerrit.wikimedia.org/r/1027205

gerritbot added a project: Patch-For-Review.Sat, May 4, 3:35 PM

Adding file management folks for visibility.

We found during migration that the metric is fed seconds (to microsecond precision) when the function expects milliseconds. To fix, the graphs will look like latency has increased 1000x, when in reality we've been underreporting for a long time.

Since we're here, we might as well fix the data as well as migrate to StatsLib.

Made a ticket to specifically track it T364238

Tarrow merged a task: T364238: media.thumbnail.stream is erroneously writing seconds to statsd.Sat, May 4, 5:02 PM

Tarrow subscribed.

Maintenance_bot added a project: Commons.Sat, May 4, 5:30 PM

Change #1027264 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/core@master] Migrate media.thumbnail.generate.fetchoriginal to statslib

https://gerrit.wikimedia.org/r/1027264

Change #1027268 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/core@master] Migrate media.thumbnail.generate.transform to statslib

https://gerrit.wikimedia.org/r/1027268

Change #1027272 had a related patch set uploaded (by Tarrow; author: Tarrow):