Page MenuHomePhabricator

Remove "<a href" from DonationInterface messages
Open, Needs TriagePublicBUG REPORT

Description

The DonationInterface extension has 22 messages that include <a href. All of them are in DonationInterface/gateway_common/i18n/interface/en.json:

  1. donate_interface-processing-error
  2. donate_interface-donor-opt_in_explain
  3. donate_interface-donor-opt_in_explain_001
  4. donate_interface-error-msg-invalid-country
  5. donate_interface-error-msg-limit
  6. donate_interface-error-msg-apple_pay_unsupported
  7. donate_interface-error-msg-google_pay_unsupported
  8. donate_interface-donate-error-try-a-different-card-html
  9. donate_interface-donate-error-try-again-html
  10. donate_interface-donation-cancelled
  11. donate_interface-error-no-form-html
  12. donate_interface-question-comment
  13. donate_interface-otherways
  14. donate_interface-otherways-in
  15. donate_interface-otherways-alt
  16. donate_interface-did-you-mean
  17. donate_interface-email-unsub-fail
  18. donate_interface-email-unsub-warning
  19. donate_interface-email-optin-fail
  20. donate_interface-informationsharing
  21. donate_interface-taxded-msg-x
  22. donate_interface-photo-license

Translations of messages with <a href have to be manually reviewed when they are imported from translatewiki to Gerrit. This is time-consuming for the translatewiki volunteers and maintainers. It's error-prone, too. It would be nice to get rid of them.

As far I can see, all of those DonationInterface messages have href values of three types:

  1. mailto:$1 (or some other number after $)
  2. $1 (or some other number after $)
  3. #

So none of them need any customizations by translators. This is good, and probably makes things easier to fix.

For example, donate_interface-donor-opt_in_explain is currently *Your information is handled in accordance with our <a href="$1">Donor Privacy Policy</a>. Each email you receive will include easy unsubscribe options. The words "Donor Privacy Policy" can probably be moved to a different message, then it can be wrapped in run-time in <a href="$1">...</a>, and inserted into donate_interface-donor-opt_in_explain as a parameter.

Finally, the original message will become something like *Your information is handled in accordance with our $1. Each email you receive will include easy unsubscribe options. (And the qqq must say that $1 is that other message, but that's the easiest part.)

I appreciate any help with completing this. Once this is achieved, localizing donation interface will be more streamlined and secure. Thanks! <3

Related Objects

Event Timeline

@Pcoombe potentially an opportunity to also review the messages and discard any outdated ones.

Change #1027139 had a related patch set uploaded (by Cstone; author: Cstone):

[mediawiki/extensions/DonationInterface@master] WIP: Remove <a hrefs from translation messages

https://gerrit.wikimedia.org/r/1027139

Change #1027155 had a related patch set uploaded (by Cstone; author: Cstone):

[mediawiki/extensions/DonationInterface@master] Remove unused messages

https://gerrit.wikimedia.org/r/1027155

Change #1027155 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Remove unused messages

https://gerrit.wikimedia.org/r/1027155