Page MenuHomePhabricator
Create Task
Maniphest T360634

Bitu not importing key changes directly in LDAP
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Newly added key is missing.

What should have happened instead?:
Newly added key shows up.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Keymanagement: Bypass job queue for ssh key operations.operations/software/bitumaster+1 -1
Let Bitu be a little more aggressive with loading SSH keys from LDAP.operations/software/bitumaster+40 -20
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedPRODUCTION ERRORTgrT195253 Special:Notifications gives a consistent PHP exception on load ("The trash icon is not registered") for users with OpenStackManager notifications
 OpenNoneT106123 Extensions needing to be removed from Wikimedia wikis
 OpenNoneT189531 All Wikimedia developer services should use single sign-on
 OpenNoneT363125 sustainability of wikitech.wikimedia.org
 OpenNoneT161859 Make Wikitech an SUL wiki
 Open• taaviT161553 Remove OpenStackManager from Wikitech
 ResolvedAndrewT150091 Support project creation without OpenStackManager
 ResolvedAndrewT159021 Wikitech error when adding users to projects
 ResolvedAndrewT162097 Create a Horizon panel for managing per-project sudo policies
 ResolvedAndrewT194191 Allow projectadmins to change project roles in Horizon
 ResolvedMarcoAurelioT194670 Copy maintenance/attachLdapUser.php to another extension
 ResolvedAndrewT194794 Add new users to Bastion group whenever they join a project
 Resolved• taaviT196171 Developer account creation without OpenStackManager
 DeclinedNoneT179463 Create a single application to provision and manage developer (LDAP) accounts
 DuplicateNoneT189639 Separate LDAP account creation bits from Striker to create a new identity management platform
 OpenNoneT319405 Create an IDM for Wikimedia developer accounts
 ResolvedSLyngshede-WMFT319407 IDM milestone 1 "Initial development work"
 ResolvedNoneT319409 Pick a name for the IDM
 ResolvedSLyngshede-WMFT319410 Initial Django project setup
 ResolvedSLyngshede-WMFT319415 Evaluate Striker codebase
 ResolvedMarosteguiT320426 Figure out where/how to store IDM internal data
 ResolvedSLyngshede-WMFT320427 Design and implement async LDAP operations
 ResolvedSLyngshede-WMFT320428 Initial IDM puppetisation
 ResolvedSLyngshede-WMFT320430 Create an initial IDM/LDAP image for tests and CI
 ResolvedSLyngshede-WMFT320431 IDM: Central logging on all changes
 ResolvedSLyngshede-WMFT320603 IDM milestone 2 "Initial limited deployment"
 ResolvedSLyngshede-WMFT320604 Decide on model for serving idm.wikimedia.org
 ResolvedNoneT320605 Figure out an HA setup for the IDM
 ResolvedSLyngshede-WMFT320794 Extend LDAP to allow storing all necessary attributes
 ResolvedSLyngshede-WMFT320795 Implement a staging setup for the IDM
 ResolvedSLyngshede-WMFT320797 Initial production deployment of the IDM
 ResolvedSLyngshede-WMFT320799 IDM integration into CAS SSO
 ResolvedSLyngshede-WMFT320807 Implement OAuth account validation for linking an account to a wiki account
 ResolvedSLyngshede-WMFT320808 Implement email address validation workflow
 OpenNoneT148048 Store Wikimedia unified account name (SUL) in LDAP directory
 Open• taaviT359428 Striker should use ID instead of username to identify SUL accounts
 ResolvedSLyngshede-WMFT335091 Determine which sender address to use for email notification
 ResolvedSLyngshede-WMFT340721 Build Debian packages for Bookworm
 ResolvedSLyngshede-WMFT340722 Update IDM servers to Bookworm
 OpenSLyngshede-WMFT320801 Build-out for self service
 ResolvedSLyngshede-WMFT320802 Create a mockup and involve designers
 ResolvedBUG REPORTSLyngshede-WMFT338824 Bitu is not responsive
 InvalidNoneT320805 Define the core attribute list managed in the IDM with all stakeholders
 ResolvedSLyngshede-WMFT320806 Consider reusing some wiki data sources for signup/restrictions
 ResolvedSLyngshede-WMFT320809 Figure out a captcha option for IDM
 OpenNoneT335478 Automatic detection of inactive LDAP account
 OpenNoneT335485 Automatically deploy documentation to docs.wikimedia.org
 ResolvedSLyngshede-WMFT340636 Implement "Forgot my username" feature
 ResolvedSLyngshede-WMFT340637 Implement "update email" functionality
 OpenSLyngshede-WMFT340717 Implement "source" field on user objects
 OpenSLyngshede-WMFT345168 Live validation of usernames
 ResolvedSLyngshede-WMFT345226 Switch developer account creation to Bitu
 OpenSLyngshede-WMFT347572 SSH Key type expiry
 Open• taaviT338477 `Nova Resource:` namespace should be declared in wmf-config, not in Extension:OpenStackManager
 Open• taaviT359544 Disable SSH key management on Wikitech
 ResolvedBUG REPORTSLyngshede-WMFT360634 Bitu not importing key changes directly in LDAP
 Resolvedbd808T53642 Get rid of SemanticMediaWiki/SRF/SF from wikitech.wikimedia.org
 ResolvedyuvipandaT103995 Build a simple tool to query which instances have which roles / puppet variables
 Resolvedbd808T161662 Replace SMW data on project instances with a tool using the OpenStack APIs
 Resolvedbd808T162508 Implement Tool Labs membership application and processing in Striker
 Resolvedbd808T164787 Keystone permissions exception when trying to approve Tool Labs membership request via Striker
 OpenSLyngshede-WMFT163478 Allow viewing/searching LDAP account creations including date
 ResolvedNoneT153821 wikitech.wikimedia.org missing from pageviews API
 OpenNoneT237773 Move Wikitech onto the production MW cluster
 ResolvedMarosteguiT167973 Move database for wikitech (labswiki) to a main cluster section
 ResolvedAndrewT188029 Move labswiki database to m5
ResolvedMarosteguiT282074 Audit labswiki grants
 ResolvedAndrewT282209 Enable connection from labweb1001/labweb1002 to s6
 DeclinedAndrewT282573 Move labweb/cloudweb hosts to private IPs
 ResolvedAndrewT284106 Replicate & sanitize wikitech data
 ResolvedAndrewT284108 Bring labswiki database tables up to date
 ResolvedLadsgroupT269348 wikitech database has almost all of its varbinary fields wrong
 DuplicateNoneT284736 Create views on labswiki on clouddb* hosts
 Resolved• BstormT287442 Create views for labswiki (wikitech)
 DeclinedNoneT237889 Install php-ldap on all MW appservers
 Resolved• taaviT237890 Remove and empty useless user groups
 ResolvedJdforrester-WMFT196466 Remove 'shell user' right on wikitech
 DeclinedNoneT246405 On wikitech, make sysops unable to edit site JS, and then retire contentadmin
 OpenjijikiT292707 Migrate Wikitech to Kubernetes
 OpenNoneT359551 Replace wikitech as source of two-factor auth protection for developer accounts
 OpenFeatureNoneT359554 Use IDP for authentication in Striker
 StalledFeatureNoneT359590 Use IDP for authentication in Horizon
 OpenFeatureSLyngshede-WMFT359552 Enable self-service IDP two-factor authentication management
 OpenNoneT359820 Add developer account (un)blocking support to Bitu
 OpenAndrewT360795 Set up a bitu instance for codfw1dev
 OpenSLyngshede-WMFT362128 Site: 1 VM for codfw1dev bitu deployment
 ResolvedABran-WMFT362619 Database request for Bitu Cloud DEV installation
 Resolved• taaviT360883 Disable email address changes in Wikitech
 OpenNoneT364605 Move Striker to Bitu username validation API
 In ProgressSLyngshede-WMFT362318 Add Bitu container to Striker development environment

Event Timeline

• taavi created this task.Mar 21 2024, 1:42 PM
• taavi edited projects, added Bitu; removed cloud-services-team, wikitech.wikimedia.org.Mar 21 2024, 1:53 PM
Restricted Application added a project: Infrastructure-Foundations. · View Herald TranscriptMar 21 2024, 1:53 PM
SLyngshede-WMF changed the task status from Open to In Progress.Mar 21 2024, 2:09 PM
SLyngshede-WMF claimed this task.
SLyngshede-WMF triaged this task as High priority.
SLyngshede-WMF added a comment.Mar 21 2024, 2:29 PM

Okay, I see the issue. In order to not hit LDAP to much, keys are cached, but that's honestly no good as that gives the users a false impression of what keys are active.

gerritbot added a comment.Mar 22 2024, 7:15 AM

Change #1013442 had a related patch set uploaded (by Slyngshede; author: Slyngshede):

[operations/software/bitu@master] Let Bitu be a little more aggressive with loading SSH keys from LDAP.

https://gerrit.wikimedia.org/r/1013442

gerritbot added a project: Patch-For-Review.Mar 22 2024, 7:15 AM
gerritbot added a comment.Mar 22 2024, 8:09 AM

Change #1013442 merged by jenkins-bot:

[operations/software/bitu@master] Let Bitu be a little more aggressive with loading SSH keys from LDAP.

https://gerrit.wikimedia.org/r/1013442

SLyngshede-WMF added a comment.Mar 22 2024, 8:29 AM

That fixed the synchronization with other services, but makes it slightly trigger to actually delete keys.

There will be a followup patch.

gerritbot added a comment.Mar 22 2024, 9:48 AM

Change #1013507 had a related patch set uploaded (by Slyngshede; author: Slyngshede):

[operations/software/bitu@master] Keymanagement: Bypass job queue for ssh key operations.

https://gerrit.wikimedia.org/r/1013507

gerritbot added a comment.Mar 22 2024, 11:18 AM

Change #1013507 merged by jenkins-bot:

[operations/software/bitu@master] Keymanagement: Bypass job queue for ssh key operations.

https://gerrit.wikimedia.org/r/1013507

bd808 mentioned this in T360966: The workflow for managing an ssh key via Bitu is cumbersome.Mar 26 2024, 12:10 AM
SLyngshede-WMF moved this task from Backlog to Pending Release on the Bitu board.Mar 26 2024, 11:24 AM
SLyngshede-WMF closed this task as Resolved.Apr 11 2024, 10:41 AM
SLyngshede-WMF moved this task from Pending Release to Resolved on the Bitu board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL