The databasefield recentchanges.rc_new is marked as obsolete in RecentChanges.php
Please drop this field to clean up the table.
The problem is, that this field is used at many places in core. You can remove it with a check of the field "rc_source" against the const RecentChange::SRC_NEW.
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| feat(featureset): fall back to default quality thresholds for unseen wikis | repos/research/knowledge_integrity!37 | mnz | mnz/supported-wikis | main |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Feature | None | T18660 Database table cleanup (tracking) | ||
| Stalled | None | T36320 Remove obsolete recentchanges.rc_new database field | |||
| Open | None | T244080 Add index to recentchanges.rc_source |
changed some rc_new with gerrit 17622, but the field is part of an index, that makes it not easy to remove.
Can we please keep such fields for a while, it makes very difficult to test older MediaWiki versions with the same database as the one for master.
(In reply to comment #2)
Can we please keep such fields for a while, it makes very difficult to test
older MediaWiki versions with the same database as the one for master.
Yes, that sounds good. Keeping the field at least one release after the last usage was removed. Than it is possible to rollback a upgrade without errors.
Maybe adding @deprecated in tables.sql as a comment near the field can make that clearer, because some fields left over in the past.
It appears this task doesn't have much movement on it so we are de-prioritizing it at this time.
Basic code search for use:
https://codesearch.wmflabs.org/search/?q=rc_new%5B%5E_%5D&i=nope&files=%5C.php%24&repos=
Change 567531 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlockAndNuke@master] Replace use of rc_new field with rc_source
Change 567532 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceSmartList@master] Replace use of rc_new field with rc_source
Change 567536 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralNotice@master] Replace use of rc_new field with rc_source
Change 567537 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@master] Replace use of rc_new field with rc_source
Change 567539 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MobileFrontend@master] Replace use of rc_new field with rc_source
Change 567540 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] Replace use of rc_new field with rc_source
Change 567541 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SiteScout@master] Replace use of rc_new field with rc_source
Change 567542 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SocialProfile@master] Replace use of rc_new field with rc_source
Change 567532 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceSmartList@master] Replace use of rc_new field with rc_source
Change 567542 merged by Jack Phoenix:
[mediawiki/extensions/SocialProfile@master] Replace use of rc_new field with rc_source
Change 567541 merged by Jack Phoenix:
[mediawiki/extensions/SiteScout@master] Replace use of rc_new field with rc_source
Change 568080 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[translatewiki@master] Replace use of rc_new field with rc_source
Change 568080 merged by jenkins-bot:
[translatewiki@master] Replace use of rc_new field with rc_source
Change 567539 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Replace use of rc_new field with rc_source
Change 569282 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace use of rc_new field with rc_source (part 1)
Change 567536 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Replace use of rc_new field with rc_source
Change 567531 merged by jenkins-bot:
[mediawiki/extensions/BlockAndNuke@master] Replace use of rc_new field with rc_source
Change 567537 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Replace use of rc_new field with rc_source
Change 577735 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Nuke@master] Replace use of rc_new with rc_source, clean up query
Stalled pending addition of new index in T244080: Add index to recentchanges.rc_source
Change 567540 abandoned by Kosta Harlan:
[mediawiki/extensions/PageTriage@master] Replace use of `rc_new` field with `rc_source`
Reason:
Cleaning up the code review queue; if you'd like to keep working on this, please restore it!
There are several places in Wikimedia deployed code where rc_new is still used in queries:
// rc_new is not an ENUM, but adding a redundant rc_new IN (0,1) gives mysql enough // knowledge to use an index merge if it wants (it may use some other index though). $conds += [ 'rc_new' => [ 0, 1 ] ];
They are hard to deal with because queries with rc_new might already use the existing rc_new_name_timestamp index, but there is no index on rc_source (T244080). There is an index on rc_type, though, but it's a bit different:
INDEX rc_new_name_timestamp ( rc_new, rc_namespace, rc_timestamp ), INDEX rc_name_type_patrolled_timestamp ( rc_namespace, rc_type, rc_patrolled, rc_timestamp )
If we still want to do this, maybe we should change the direction a bit and look into finding ways to replace them with rc_type = RC_NEW first. We may need to fiddle with the indices, though.
Change #1027138 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):
[mediawiki/extensions/Nuke@master] Replace rc_new for rc_type in DB query
Change #1027147 had a related patch set uploaded (by Samwalton9; author: Samwalton9):
[mediawiki/core@master] Update documentation for rc_new
Change #577735 abandoned by Scardenasmolinar:
[mediawiki/extensions/Nuke@master] Replace use of rc_new with rc_source, clean up query
Reason:
Abandoning in favor of 1027138
Change #1027147 merged by jenkins-bot:
[mediawiki/core@master] Update documentation for rc_new
Change #1027138 merged by jenkins-bot:
[mediawiki/extensions/Nuke@master] Replace rc_new for rc_source in DB query
