We should be able to switch to rc_source now that the schema change is complete and populated. Mostly this means changing queries in core and throughout mediawiki to use the rc_source column instead of rc_type when querying the recentchanges table and marking the appropriate things deprecated.
Description
Description
Details
Details
- Reference
- bz72157
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use original recent change type when injecting it to the client | mediawiki/extensions/Wikibase | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T90435 [Epic] Wikidata watchlist improvements (client) | |||
| Declined | None | T74157 [Story] Use rc_source and drop RC_TYPE | |||
| Resolved | aude | T44289 [Task] Use rc_source for filtering Wikibase recent changes and watchlist entries in the client |
Event Timeline
Comment Actions
Not sure which team this belongs to anymore, but it is not in any way collaboration specific. What happened is we wanted to use the existing rc_type field and various people on wikitech said that was a bad idea because it was based on numbers instead of strings. I added a string field to the database and started populating it, but we have never gone around to actually change the queries to use this string field.
Comment Actions
I think dropping RC_TYPE would be a follow up task.
sadly, while Wikibase populates rc_source, we don't use it yet in a meaningful way and think places like ChangesList also still need to be adapted to use rc_source (e.g. the various filters)
Comment Actions
adding Wikidata to this and raising priority, as it is important for us improving watchlist integration. Marked as a "Story" as I imagine this needs to be broken into sub tasks.
Comment Actions
Change 415902 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Use original recent change type when injecting it to the client
Comment Actions
Is it still valid in that sense that you want to drop rc_type? This has been used everywhere.
Comment Actions
I see no clear product / user facing impact that this change will have right now.
It looks like this was originally created as a flow ticket (looking at the trello link), but also covers wikidata / wikibase.
Closing for now due to the vagueness etc.
We may do something on this area in the future if something needs or something else happens (like rc_type being dropped?)
Comment Actions
Change 415902 abandoned by Addshore:
[mediawiki/extensions/Wikibase@master] Use original recent change type when injecting it to the client
Reason:
Abandoning, this code I think is being touched again by Ladsgroup right now, feel free to reopen if you want this patch!