Page MenuHomePhabricator
Create Task
Maniphest T43351

Nuke should be capable of deleting pages which have been moved
Closed, ResolvedPublic
Actions

Description

When a page has been moved, Nuke lists+deletes only the original name (now containing only the redirect), keeping the real content intact. It is probably related to the fact moved pages are not listed on Special:Newpages either.

Version: unspecified
Severity: normal

Details

Reference
bz41351
SubjectRepoBranchLines +/-
Query current page name for moved pagesmediawiki/extensions/Nukemaster+5 -4
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:12 AM
• bzimport added a project: MediaWiki-extensions-Nuke.
• bzimport set Reference to bz41351.
• bzimport added a subscriber: Unknown Object (MLST).
Mormegil created this task.Oct 24 2012, 3:17 PM
Nemo_bis subscribed.Mar 6 2015, 11:35 AM

This would be solved by using the revision table as T33858 proposes

GTrang mentioned this in T215696: RecentChanges should update entries when user move a page.Feb 25 2019, 6:47 PM
DannyS712 subscribed.Mar 7 2020, 8:58 AM

Or by tracking pageid instead of title?

gerritbot added a comment.Jul 6 2022, 9:13 AM

Change 811669 had a related patch set uploaded (by A2093064; author: A2093064):

[mediawiki/extensions/Nuke@master] Query current page name for moved pages

https://gerrit.wikimedia.org/r/811669

gerritbot added a project: Patch-For-Review.Jul 6 2022, 9:13 AM
Xiplus subscribed.Jul 6 2022, 9:13 AM
• Samwalton9-WMF renamed this task from Nuke ignores page moves to Nuke should be capable of deleting pages which have been moved.Apr 15 2024, 8:09 AM
• Samwalton9-WMF merged a task: T196831: On English Wikinews, Special:Nuke shows original names after renames; deletion log shows multiple deletion for single files.
• Samwalton9-WMF added subscribers: Cromium, Aklapper, Teles.
Johannnes89 subscribed.Apr 15 2024, 8:12 AM
Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 15 2024, 6:04 PM
Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptApr 15 2024, 6:04 PM
• Samwalton9-WMF moved this task from Inbox to Triaged on the Moderator-Tools-Team board.Apr 16 2024, 8:13 AM
• Samwalton9-WMF mentioned this in T361258: [Hackathon 2024] Improve the Nuke extension.May 3 2024, 5:24 AM
Chlod claimed this task.May 3 2024, 10:30 AM
Chlod subscribed.

I've updated Xiplus' patch to work on the latest revision of Nuke for Wikimedia-Hackathon-2024. Nuke was migrated to query builder some time ago so I've changed it up to use that.

gerritbot added a comment.May 3 2024, 11:46 AM

Change #811669 merged by jenkins-bot:

[mediawiki/extensions/Nuke@master] Query current page name for moved pages

https://gerrit.wikimedia.org/r/811669

Scardenasmolinar edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.May 3 2024, 11:52 AM
Scardenasmolinar moved this task from Ready to Done on the Moderator-Tools-Team (Kanban) board.
• Samwalton9-WMF edited projects, added Moderator-Tools-Team, User-notice; removed Moderator-Tools-Team (Kanban).May 3 2024, 11:54 AM
• Samwalton9-WMF subscribed.

I think this is worth putting in Tech News:

Nuke will now correctly delete pages which were moved to another title.

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).May 3 2024, 12:00 PM
Chlod added a comment.May 3 2024, 12:05 PM
In T43351#9767132, @Samwalton9-WMF wrote:

I think this is worth putting in Tech News:

Nuke will now correctly delete pages which were moved to another title.

Sounds good!

I did notice something while I was testing this on enbetawiki: redirects created from page moves don't seem to be detected by Nuke (see screenshot). This sounds like T46318, but the text of that task makes me think it means something else. Should this be filed as a new task?

Screenshot_26.png (193×700 px, 18 KB)

• Samwalton9-WMF added a comment.May 3 2024, 12:39 PM
In T43351#9767193, @Chlod wrote:
In T43351#9767132, @Samwalton9-WMF wrote:

I think this is worth putting in Tech News:

Nuke will now correctly delete pages which were moved to another title.

Sounds good!

I did notice something while I was testing this on enbetawiki: redirects created from page moves don't seem to be detected by Nuke (see screenshot). This sounds like T46318, but the text of that task makes me think it means something else. Should this be filed as a new task?

Screenshot_26.png (193×700 px, 18 KB)

Good catch! Yeah I think this is basically covered by T46318 (which should probably be split into two tickets - subpages and redirects)

matej_suchanek removed a project: Patch-Needs-Improvement.May 3 2024, 2:43 PM
• Samwalton9-WMF edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.May 4 2024, 1:33 PM

Putting this on our board so we remember to close it out once it's live.

Quiddity moved this task from To Triage to Not ready to announce on the User-notice board.Fri, May 10, 12:39 AM
Quiddity subscribed.Fri, May 10, 12:45 AM
In T43351#9767132, @Samwalton9-WMF wrote:

I think this is worth putting in Tech News:

Nuke will now correctly delete pages which were moved to another title.

Thanks for the draft! I suggest tweaking it to something like this (assuming it's still accurate):

The Nuke feature, which enables administrators to mass delete pages, will now correctly delete pages which were moved to another title, along with their redirect.

Please edit that further, if needed.
Please also either comment here when it's ready to be announced, or add it to the next edition directly at that time. Thanks!

• Samwalton9-WMF closed this task as Resolved.Wed, May 15, 10:17 AM
In T43351#9784964, @Quiddity wrote:
In T43351#9767132, @Samwalton9-WMF wrote:

I think this is worth putting in Tech News:

Nuke will now correctly delete pages which were moved to another title.

Thanks for the draft! I suggest tweaking it to something like this (assuming it's still accurate):

The Nuke feature, which enables administrators to mass delete pages, will now correctly delete pages which were moved to another title, along with their redirect.

Please edit that further, if needed.
Please also either comment here when it's ready to be announced, or add it to the next edition directly at that time. Thanks!

Added!

Quiddity moved this task from Not ready to announce to In current Tech/News draft on the User-notice board.Wed, May 15, 6:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL