Page MenuHomePhabricator

rollback/undo link for a page move should revert the move
Open, LowPublic

Description

The rollback link next to an entry in your watchlist and in a contributions list
for a page move should rollback the page move. Currently the rollback link has
no effect as it just attempts to rollback the null edit. To rollback the page
move you have to use the link from the page move log.

This will make the behaviour inline with what you expect a rollback button to do

  • rollback the change.

(see also bug T5185 that I guess may be easy to fix at the same time as this one)


See Also:
T30488: Implement revisionized properties table
T5185: Page move rollback should not leave a redirect

Details

Reference
bz4433

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 9:01 PM
bzimport set Reference to bz4433.
bzimport added a subscriber: Unknown Object (MLST).

Those move entries are actually just dummy edits, so (revert) links could not be
made for them.

ayg wrote:

Of course they can. They'd just have to be implemented differently, which may
or may not be tricky.

(In reply to comment #2)

Of course they can. They'd just have to be implemented differently, which may
or may not be tricky.

Well yeah, you can always do schema changes. But that goes without saying :)

mike.lifeguard+bugs wrote:

hopefully a better summary

We seriously need a true rollback function for page moves. We have vandals who do nothing but move pages because they know it's such a pain in the ass for admins to undo that (and because ONLY admins can, if undoing the move requires deletion of a redirect). Ideally, some rollback function for pagemoves should exist that simply puts things back the way they were before the vandal made his move.

mike.lifeguard+bugs wrote:

(In reply to comment #1)

Those move entries are actually just dummy edits, so (revert) links could not be
made for them.

Well, we have revert links on the page move log, so I'm not clear how it is significantly different to have the rollback link do the same thing in the various locations is appears.

mike.lifeguard+bugs wrote:

*** Bug 6984 has been marked as a duplicate of this bug. ***

  • Bug 21359 has been marked as a duplicate of this bug. ***

Fix it or remove the link. It's confusing :/

  • Bug 21359 has been marked as a duplicate of this bug. ***
Beta16 set Security to None.

Maybe we should just remove the undo/rollback links for null edits.

Can we not detect null edits by comparing the Sha1 of the revisions ?
Would this have a performance impact ?

It is very strange, the bug report exists already since 2005 (also on T5909). It should be simple to fix.
I am in favor of keeping the link and converting him to what it is intended (like on Special:Log/move). (At the moment this problem got attention again on the DeWP Forum from experienced users: @NordNordWest, @Tsungam)

From a countervandalism point of view, using rollback to revert malicious page moves would be great. Abuse of the feature for page-move wars is a possibility that, well, already exists with the current not-so-automatic system we've got.

@MarcoAurelio: Indeed, this should include an higher attention for the user. Special user right check and prompt (not as the common single one click).