Allow links to phabricator comments from gerrit messages.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	daniel
	Dec 2 2014, 12:44 PM

Description

In comments on gerrit, ticket IDs like T12345 are automatically linked to phabricator tickets.
It would be useful to link comment IDs like T12345#65432 to the respective comment.

Details

Subject	Repo	Branch	Lines +/-
Gerit: Rewrite outdated comment about Gerrit-Phabricator linking	operations/puppet	production	+1 -4
Gerrit: Support linking to phabricator comments	operations/puppet	production	+2 -2
gerrit: support linking to a phabricator comment	operations/puppet	production	+2 -2
gerrit: support linking to a phabricator comment	operations/puppet	production	+2 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Paladox	T76459 Allow links to phabricator comments from gerrit messages.
		Resolved		Paladox	T75997 Full Phabricator links are being expanded weirdly in gerrit

Event Timeline

daniel created this task.Dec 2 2014, 12:44 PM

daniel raised the priority of this task from to Needs Triage.

daniel updated the task description. (Show Details)

daniel added projects: Gerrit, Phabricator.

daniel changed Security from none to None.

daniel subscribed.

Aklapper triaged this task as Lowest priority.Dec 2 2014, 1:09 PM

Aklapper added a subscriber: QChris.

Liuxinyu970226 subscribed.Jan 13 2015, 8:13 AM

Liuxinyu970226 unsubscribed.Mar 1 2015, 3:27 PM

Ricordisamoa subscribed.Jul 21 2015, 10:25 PM

Restricted Application added a subscriber: scfc. · View Herald TranscriptJul 21 2015, 10:25 PM

• RobLa-WMF mentioned this in T75997: Full Phabricator links are being expanded weirdly in gerrit.Jan 2 2016, 5:56 PM

I tried working around this, and failed. See my attempt to link to T119209#1912745 from https://gerrit.wikimedia.org/r/#/c/254440/

Assuming we stay with Gerrit, we need to fix T75997 to fix this one, I think. Note: I'm not recommending we stay on Gerrit. ;-)

Restricted Application added a subscriber: Luke081515. · View Herald TranscriptJan 2 2016, 6:00 PM

• RobLa-WMF added a subtask: T75997: Full Phabricator links are being expanded weirdly in gerrit.Jan 2 2016, 6:00 PM

Change 256663 had a related patch set uploaded (by Tim Landscheidt):
Avoid breaking full phabricator URLs

https://gerrit.wikimedia.org/r/256663

gerritbot added a project: Patch-For-Review.Jan 2 2016, 7:04 PM

(No, I just linked Thiemo's patch to this task as it would resolve it.)

Aklapper mentioned this in T137562: Gerrit autolinker to Phabricator incorrectly expands links with anchors.Jun 10 2016, 6:11 PM

Danny_B subscribed.Jun 10 2016, 9:52 PM

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJun 10 2016, 9:52 PM

• mmodell mentioned this in rOPUP28a86d08f542: Avoid breaking full phabricator URLs.Jun 17 2016, 6:05 PM

Change 301580 had a related patch set uploaded (by Paladox):
Support linking to a phabricator comment

https://gerrit.wikimedia.org/r/301580

Paladox mentioned this in rOPUPbf363cc012b6: Support linking to a phabricator comment.Jul 28 2016, 11:51 AM

Paladox mentioned this in rOPUPe6e2318900ac: Support linking to a phabricator comment.

Paladox mentioned this in rOPUPb68924b2979b: Avoid breaking full phabricator URLs.Jul 28 2016, 12:11 PM

Paladox mentioned this in rOPUP3fe5be34a6d6: Support linking to a phabricator comment.Jul 28 2016, 3:22 PM

Paladox mentioned this in rOPUP1b7b1b2df236: Support linking to a phabricator comment.

Paladox mentioned this in rOPUP1ed5ea27de0c: Support linking to a phabricator comment.Jul 28 2016, 5:24 PM

Paladox mentioned this in rOPUPe70deb727d21: Support linking to a phabricator comment.

Paladox mentioned this in rOPUP38368aa8299d: gerrit: support linking to a phabricator comment.Jul 28 2016, 5:34 PM

Dzahn mentioned this in rOPUPf2fbcfd5f50b: gerrit: support linking to a phabricator comment.Jul 28 2016, 5:34 PM

Paladox mentioned this in rOPUP40cb4102c644: gerrit: support linking to a phabricator comment.Jul 28 2016, 5:49 PM

Paladox mentioned this in rOPUP3dfb80802b8d: gerrit: support linking to a phabricator comment.

Change 301580 merged by Dzahn:
gerrit: support linking to a phabricator comment

https://gerrit.wikimedia.org/r/301580

Dzahn mentioned this in rOPUP7e4b6d5b5a78: gerrit: support linking to a phabricator comment.Jul 28 2016, 6:14 PM

This should now work.

Please reopen if it is still a problem.

Danny_B unsubscribed.Jul 28 2016, 8:31 PM

Change 301673 had a related patch set uploaded (by Paladox):
gerrit: support linking to a phabricator comment

https://gerrit.wikimedia.org/r/301673

Paladox mentioned this in rOPUP29b1963b6627: gerrit: support linking to a phabricator comment.Jul 28 2016, 8:40 PM

Paladox mentioned this in rOPUP91ad11368644: gerrit: support linking to a phabricator comment.

Paladox reopened this task as Open.Jul 28 2016, 9:43 PM

• MZMcBride subscribed.Jul 31 2016, 5:09 AM

Change 301673 abandoned by Paladox:
gerrit: support linking to a phabricator comment

https://gerrit.wikimedia.org/r/301673

Change 302229 had a related patch set uploaded (by Paladox):
Gerrit: Support having phab commits as links

https://gerrit.wikimedia.org/r/302229

Paladox mentioned this in rOPUPbc0aecf7d91f: Gerrit: Support having phab commits as links.Aug 2 2016, 12:53 AM

Paladox mentioned this in rOPUP696c4355abd5: Gerrit: Support having phab commits as links.Aug 2 2016, 9:14 PM

Paladox mentioned this in rOPUP1acd7b4168ab: Gerrit: Support having phab commits as links.Aug 2 2016, 9:25 PM

Paladox mentioned this in rOPUP0fb541064eb6: Gerrit: Support having phab commits as links.Aug 3 2016, 8:46 AM

Paladox mentioned this in rOPUP952679de26ab: Gerrit: Support having phab commits as links.

Paladox mentioned this in rOPUP00df70799c9f: Gerrit: Support having phab commits as links.Aug 4 2016, 10:29 PM

Paladox mentioned this in rOPUP9caecf34331f: Gerrit: Support having phab commits as links.Aug 4 2016, 10:46 PM

Paladox mentioned this in rOPUP7b765cfb0691: Gerrit: Support having phab commits as links.Aug 6 2016, 11:53 PM

Paladox mentioned this in rOPUPfa558fc1f9ec: Gerrit: Support having phab commits as links.

Paladox mentioned this in rOPUP98a524103e37: Gerrit: Support having phab commits as links.

Paladox mentioned this in rOPUPee82db9cf0f2: Gerrit: Support having phab commits as links.Aug 7 2016, 12:21 AM

Paladox merged a task: T55321: Turn comments such as "bug 999 comment 999" into links on Gerrit.Aug 7 2016, 1:39 PM

Paladox added subscribers: He7d3r, • wikibugs-l-list.

Paladox edited subscribers, added: • demon, • mmodell; removed: • wikibugs-l-list.

@daniel @RobLa-WMF I wonder what you think of https://gerrit.wikimedia.org/r/#/c/302229/

In T76459#2548158, @Dzahn wrote:

@daniel @RobLa-WMF I wonder what you think of https://gerrit.wikimedia.org/r/#/c/302229/

For starters, \o/ From my skim, it looks like progress.

What should I keep an eye on, though? The test commit has a bit that looks like this:

T12345#1" target="_blank">https://phabricator.wikimedia.org/T12345#1

Why is that there?

@RobLa-WMF hi that is a test for something else, but also related. I fixed the links breaking for plain tasks but if you do a task with #1 it breaks the link again. But want he is referring to is T1#1 for example, that should be working for you.