Loading indicator for more topics (ToC and on page)
Open, MediumPublic1 Estimated Story Points
Actions

Assigned To

None

Authored By

	• Spage
	Dec 3 2014, 11:30 AM

Description

As a Flow user it is apparent when a Flow board or TOC is loading more content, when it is finished, and when there is no more content to load.

Per MediaWiki.ui card 'Consistent "Load more" animation in core', we should use @Pginer-WMF's pulsing dots instead of the gear icon.

Other related cards

Trello card: tMfu5gzS

Details

	Subject	Repo	Branch	Lines +/-
	Standardize loading indicator appearance	mediawiki/extensions/Flow	master	+50 -53

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T75972 Loading indicators / Progress indicators are inconsistent.
		Open		None	T76587 Loading indicator for more topics (ToC and on page)

Event Timeline

• Spage raised the priority of this task from to Medium.Dec 3 2014, 11:30 AM

• Spage added a project: Collaboration-Team-Triage.

• Spage moved this task from Untriaged to Blocked with questions on the Collaboration-Team-Triage board.Dec 3 2014, 11:31 AM

• Mattflaschen-WMF updated the task description. (Show Details)Dec 3 2014, 7:44 PM

• Mattflaschen-WMF set Security to None.

Here's my understanding.

Flow used to show an explicit 'Older topics' link. If you scrolled down to infinite scroll would activate and the API request would trigger the mediawiki.feedback.spinner.gif in the link. On a slow computer I think you would see it animate.
- We never implemented Kaity's awesome https://trello.com/c/H7EHlNTD which animated the topic switcher indicaor state (expanded, collapsed, small).
This changed in the front-end rewrite. No more "Older topics" link (*bug*? we still have the message key flow-paging-fwd). There is a [Load more] button at the bottom, but it's only visible if JS is disabled. (I guess the theory is since JS triggers infinite scroll before you reach the bottom, there's no sense to have an Older topics link since the API request should already be in progress before you click it.) No animation is shown.
@shahyarghobadpour 's "J-2d.III Load more revamp and jumpTo support" for https://trello.com/c/CdKLx3ud restored the animation, the comment is *When the load more wrapper is being processed, show the spinning loading icon*. Its CSS rotates the wikiglyph-gear glyph (the "Settings" gear icon).

I'm moving this into the current sprint in case @pauginer wants to make any design tweaks. ContentTranslation uses pulsing dots, I made https://trello.com/c/2u8W6qn8 onMediawiki.ui board

• Mattflaschen-WMF claimed this task.Dec 3 2014, 7:44 PM

• Spage updated the task description. (Show Details)Dec 3 2014, 8:01 PM

• Spage updated the task description. (Show Details)

• Spage added a subscriber: Pginer-WMF.

In T76587#808248, @Spage wrote:

(*bug*? we still have the message key flow-paging-fwd).

Good catch. Fixed in https://gerrit.wikimedia.org/r/#/c/177306/

• Spage moved this task from Blocked with questions to Sprint O (ends Jan 27) on the Collaboration-Team-Triage board.Dec 3 2014, 9:24 PM

• Jaredzimmerman-WMF added a subtask: T75972: Loading indicators / Progress indicators are inconsistent. .Dec 9 2014, 8:55 PM

• Mattflaschen-WMF removed a subtask: T75972: Loading indicators / Progress indicators are inconsistent. .Dec 10 2014, 1:57 AM

• Spage edited projects, added Collaboration-Team-Sprint-M-2014-12-17; removed Collaboration-Team-Triage.Dec 18 2014, 6:03 PM

• Spage added a project: Collaboration-Team-Triage.Dec 19 2014, 3:36 AM

• DannyH moved this task from Sprint O (ends Jan 27) to Ready for next sprint on the Collaboration-Team-Triage board.Jan 6 2015, 7:14 PM

• DannyH renamed this task from L106. Loading indicator for more topics (ToC) to Loading indicator for more topics (ToC).Jan 6 2015, 7:20 PM

• DannyH moved this task from Ready for next sprint to Team discussion on the Collaboration-Team-Triage board.Jan 8 2015, 10:28 PM

• DannyH renamed this task from Loading indicator for more topics (ToC) to Loading indicator for more topics (ToC v2).Jan 9 2015, 12:45 AM

Here's info from Pau: http://codepen.io/anon/pen/BmzHn

Gerrit patch: https://gerrit.wikimedia.org/r/#/c/144873/

• DannyH renamed this task from Loading indicator for more topics (ToC v2) to Loading indicator for more topics (ToC and on page).Jan 9 2015, 7:44 PM

• DannyH renamed this task from Loading indicator for more topics (ToC and on page) to [1] Loading indicator for more topics (ToC and on page).

• DannyH moved this task from Team discussion to Ready for next sprint on the Collaboration-Team-Triage board.Jan 9 2015, 8:07 PM

• DannyH moved this task from Ready for next sprint to Team discussion on the Collaboration-Team-Triage board.Jan 12 2015, 8:16 PM

• DannyH moved this task from Team discussion to Ready for next sprint on the Collaboration-Team-Triage board.Jan 20 2015, 7:27 PM

• Mattflaschen-WMF renamed this task from [1] Loading indicator for more topics (ToC and on page) to Loading indicator for more topics (ToC and on page).Feb 2 2015, 8:02 PM

• Mattflaschen-WMF edited a custom field.

• Mattflaschen-WMF added a project: StructuredDiscussions.Feb 20 2015, 7:56 PM

Pginer-WMF mentioned this in T90764: S5. Flow: Integrate VE toolbar in Flow entry fields .Mar 23 2015, 2:19 PM

• Spage unsubscribed.Apr 6 2015, 8:35 PM

Pginer-WMF mentioned this in T102884: Standardize "Loading..." animation.Jun 18 2015, 9:06 AM

• Mattflaschen-WMF removed • Mattflaschen-WMF as the assignee of this task.Jun 25 2015, 10:38 PM

Pginer-WMF added a project: good first task.Jul 31 2015, 2:58 PM

• Mattflaschen-WMF moved this task from Ready for next sprint to Near-Term Interest on the Collaboration-Team-Triage board.Aug 7 2015, 10:05 PM

• DannyH moved this task from Near-Term Interest to Freezer on the Collaboration-Team-Triage board.Aug 21 2015, 9:18 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 4 2018, 2:50 PM

Change 517367 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Flow@master] Standardize loading indicator appearance

https://gerrit.wikimedia.org/r/517367

gerritbot added a project: Patch-For-Review.Jun 17 2019, 6:20 AM

• Demian subscribed.Jun 17 2020, 1:42 PM

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 7:05 PM

Aklapper removed a project: Collaboration-Team-Triage.May 25 2021, 9:10 PM

Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 1 2023, 8:24 PM