Page MenuHomePhabricator
Create Task
Maniphest T85932

Links created by selecting text in target and clicking on source link may be a red link in target wiki
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Currently you can create a new link in the translation column by selecting text and clicking on any source link, even if the source link is really a missing link or the source link cannot be adapted. Links created in this manner turn red when you click on them and cannot be removed. No target card is shown when clicking on these links.

Details

SubjectRepoBranchLines +/-
Prevent creation of unadapted link in targetmediawiki/extensions/ContentTranslationmaster+16 -2
Do not allow creation of link to selection by clicking red link in sourcemediawiki/extensions/ContentTranslationmaster+7 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Jsahleen created this task.Jan 6 2015, 4:26 PM
• Jsahleen raised the priority of this task from to Needs Triage.
• Jsahleen updated the task description. (Show Details)
• Jsahleen added projects: LE-Sprint-81, ContentTranslation-Release3, Technical-Debt, ContentTranslation.
• Jsahleen added subscribers: Aklapper, • Jsahleen.
• santhosh renamed this task from It is possible to create a new link in the translation column by selecting text and clicking on a source link that is a missing link or cannot be adapted. to Links created by selecting text in target and clicking on source link may be a red link in target wiki.Jan 7 2015, 4:04 AM
• santhosh triaged this task as Medium priority.
• santhosh removed a project: Technical-Debt.
• santhosh set Security to None.
• santhosh added subscribers: Pginer-WMF, • santhosh.

I removed technical-debt tag because this is a bug- more precisely an interaction scenario that need a definition. and not a technical debt.

@Jsahleen, what is the proposed expected result in this case?
@Pginer-WMF, what do you recommend?

• santhosh merged a task: T85927: Links added by selecting text and clicking on a source link cannot be removed if the link does not exist in target wiki.Jan 7 2015, 4:19 AM

If the link created does not exist in target wiki, target link card also wont be shown as reported in T85927

Pginer-WMF added a comment.EditedJan 7 2015, 8:42 AM

We should avoid creating a link the user cannot remove.

Creating a redlink automatically has some issues*, so I would suggest not generating a link in that case but showing the missing link card if (and only if) the link does not exist in the target language (and there is no other article with that name) in order to allow the user to create a red link if they want.

( * The issue of creating a red link automatically is about which should be the target. If the target is the current selected text, there may be an article with that title (which won't be equivalent to the source link) and we can generate a link to the wrong article. )

Pginer-WMF mentioned this in T85992: Red links in the target adapted from source links are not clearly identified as red links.Jan 7 2015, 9:51 AM
Arrbee merged a task: T85992: Red links in the target adapted from source links are not clearly identified as red links.Jan 7 2015, 9:55 AM
Arrbee subscribed.
• santhosh mentioned this in T85987: in ContentTranslation, clicking a link in source while plain text in target is selected inserts the target of the source link.Jan 12 2015, 6:30 AM
Amire80 subscribed.Jan 12 2015, 2:12 PM
Arrbee lowered the priority of this task from Medium to Low.Jan 12 2015, 2:34 PM
Arrbee merged a task: T85987: in ContentTranslation, clicking a link in source while plain text in target is selected inserts the target of the source link.Jan 12 2015, 2:50 PM
Arrbee edited projects, added ContentTranslation-Release4; removed ContentTranslation-Release3, LE-Sprint-81.Jan 13 2015, 3:11 PM
Arrbee moved this task from Needs Triage to Long term on the ContentTranslation board.Feb 2 2015, 8:12 AM
• santhosh moved this task from Backlog to Proposed for next release on the ContentTranslation-Release4 board.Mar 18 2015, 8:06 AM
Arrbee added a project: ContentTranslation-Release5.Mar 18 2015, 8:21 AM
Arrbee removed a project: ContentTranslation-Release4.
Arrbee moved this task from Backlog to Links on the ContentTranslation-Release5 board.Mar 18 2015, 8:27 AM
Arrbee moved this task from Long term to CX5 on the ContentTranslation board.Apr 20 2015, 6:06 AM
Amire80 added a comment.Jun 12 2015, 1:28 PM
This comment was removed by Amire80.
Amire80 raised the priority of this task from Low to High.Jul 2 2015, 3:47 PM
Amire80 edited projects, added ContentTranslation-Release6; removed ContentTranslation-Release5.
Amire80 moved this task from Backlog to Links on the ContentTranslation-Release6 board.
Amire80 moved this task from CX5 to CX6 on the ContentTranslation board.Jul 2 2015, 4:32 PM
Amire80 added a project: LE-CX6-Sprint 2.Aug 5 2015, 8:04 AM
Arrbee edited a custom field.Aug 12 2015, 7:22 AM
Arrbee edited projects, added LE-CX6-Sprint 3; removed LE-CX6-Sprint 2.Aug 25 2015, 7:29 AM
Arrbee edited projects, added LE-CX6-Sprint 4; removed LE-CX6-Sprint 3.Sep 8 2015, 7:50 AM
Amire80 mentioned this in T106084: Source link card pointing to the wrong article.Sep 9 2015, 5:30 AM
Amire80 mentioned this in T105876: Source link card is missing when a new link is added in the translation.
Amire80 mentioned this in T102116: when selecting plain text in the target column, show a source link card only if an article exists in the source wiki that corresponds to the target topic.
Amire80 mentioned this in T102605: Clicking a link in source section that does not exist in target creates a link which is displayed as a working link.
Nikerabbit claimed this task.Sep 9 2015, 12:45 PM
Nikerabbit raised the priority of this task from High to Unbreak Now!.
Nikerabbit lowered the priority of this task from Unbreak Now! to High.
Nikerabbit moved this task from Backlog to In Progress on the LE-CX6-Sprint 4 board.
Nikerabbit added a project: Essential-Work.
gerritbot subscribed.Sep 9 2015, 1:04 PM

Change 237095 had a related patch set uploaded (by Nikerabbit):
Do not allow creation of link to selection by clicking red link in source

https://gerrit.wikimedia.org/r/237095

gerritbot added a project: Patch-For-Review.Sep 9 2015, 1:04 PM
gerritbot added a comment.Sep 14 2015, 9:06 AM

Change 237095 merged by jenkins-bot:
Do not allow creation of link to selection by clicking red link in source

https://gerrit.wikimedia.org/r/237095

Nikerabbit mentioned this in rECTX6bb3a9e35d26: Do not allow creation of link to selection by clicking red link in source.Sep 14 2015, 9:06 AM
Diffusion mentioned this in rMEXTb61ade4b35c6: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Sep 14 2015, 9:06 AM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 14 2015, 10:00 AM
Nikerabbit moved this task from In Progress to In Review on the LE-CX6-Sprint 4 board.Sep 15 2015, 7:10 AM
Nikerabbit mentioned this in rECTX235f59e27ab8: Do not show missing target link card when clicking red link on source.Sep 17 2015, 8:07 AM
Nikerabbit mentioned this in rMEXTa5ed8e34d76f: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….
Nikerabbit moved this task from In Review to In Progress on the LE-CX6-Sprint 4 board.Sep 17 2015, 12:42 PM
gerritbot added a comment.Sep 17 2015, 1:46 PM

Change 239102 had a related patch set uploaded (by Nikerabbit):
Prevent creation of unadapted link in target

https://gerrit.wikimedia.org/r/239102

Nikerabbit moved this task from In Progress to In Review on the LE-CX6-Sprint 4 board.Sep 17 2015, 1:46 PM
gerritbot added a comment.Sep 18 2015, 3:04 PM

Change 239102 merged by jenkins-bot:
Prevent creation of unadapted link in target

https://gerrit.wikimedia.org/r/239102

Amire80 mentioned this in rECTXda4188c59c36: Prevent creation of unadapted link in target.Sep 18 2015, 3:04 PM
Nikerabbit mentioned this in rMEXTe94bc7ec466f: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Sep 18 2015, 3:04 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 18 2015, 5:00 PM
Amire80 mentioned this in T113132: CX - Multiple damages to created article.Sep 19 2015, 11:17 AM
Arrbee moved this task from In Review to QA on the LE-CX6-Sprint 4 board.Sep 21 2015, 7:09 AM
Arrbee added a comment.Sep 21 2015, 12:28 PM

Verified.

Arrbee moved this task from QA to Done on the LE-CX6-Sprint 4 board.Sep 21 2015, 2:14 PM
Liuxinyu970226 subscribed.Sep 30 2015, 10:15 AM
Amire80 closed this task as Resolved.Oct 2 2015, 2:47 PM
Liuxinyu970226 unsubscribed.Oct 3 2015, 2:38 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL