Page MenuHomePhabricator
Create Task
Maniphest T86812

MassMessage notifies you when posting specifically to Flow boards
Closed, ResolvedPublic
Actions

Description

I recently used Special:MassMessage to send a notification to 1,800+ talk pages. Rather than have the posts signed as "MediaWiki message delivery," I opted to have it signed under my own name by doing the usual [[User:Harej|Harej]]. I ended up getting two notifications about "MediaWiki message delivery" pinging me, even though they were just my own comments. But I only got two notifications, not over 1,800. Both of the notifications were from posts to Flow boards:

https://en.wikipedia.org/w/index.php?title=Topic:S9votlzzkv0yz49e&topic_showPostId=s9votmaguo7uw9jm&fromnotif=1#flow-post-s9votmaguo7uw9jm

https://en.wikipedia.org/w/index.php?title=Topic:S9vousecxfm7f5kk&topic_showPostId=s9vousj93cqgo8hg&fromnotif=1#flow-post-s9vousj93cqgo8hg

In the long term, the way MassMessage messages are attributed should be revisited (T71954: Add support to MassMessage to allow using the sender's username for deliveries), but in the meantime, it shouldn't ping me over my own message.

Details

SubjectRepoBranchLines +/-
MassMessage flow mention fixedmediawiki/extensions/MassMessagemaster+3 -2
Customize query in gerrit

Related Objects

Event Timeline

Harej created this task.Jan 14 2015, 8:21 PM
Harej raised the priority of this task from to Needs Triage.
Harej updated the task description. (Show Details)
Harej added projects: StructuredDiscussions, Notifications.
Harej added subscribers: Harej, Legoktm.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2015, 8:21 PM
Legoktm added a project: MassMessage.Jan 14 2015, 9:28 PM
Legoktm set Security to None.
Quiddity triaged this task as Medium priority.Jan 14 2015, 9:45 PM
Quiddity added a project: Collaboration-Team-Triage.
Quiddity updated the task description. (Show Details)Feb 24 2015, 5:28 PM
Harej mentioned this in T90383: give willing people an easy way to volunteer their user talk pages as a testing ground for Flow.Mar 12 2015, 2:19 PM
wctaiwan subscribed.Mar 24 2015, 8:49 PM
Legoktm moved this task from Backlog to Needs code on the Notifications board.Jul 6 2015, 7:45 AM
Quiddity merged a task: T144754: MassMessage sends notifications to message sender when that message is signed and posted on a Flow board.Sep 19 2016, 9:28 PM
Quiddity added subscribers: Trizek-WMF, Etonkovidova, Catrope, Lea_Lacroix_WMDE.
Quiddity subscribed.Sep 19 2016, 9:44 PM

Comments from merged task:

In T144754#2614164, @Trizek-WMF wrote:

On my way to distribute the survey about Flow, I'm receiving notifications and emails. Fortunately, I'm only targeting 1300 pages .

In T144754#2630954, @Catrope wrote:

Idea: perhaps the delivery bot is on the user blacklist for mentions, and Flow mentions don't respect this blacklist while wikitext mentions do? If that's true, this would be a general bug not related to MassMessage.

In T144754#2650341, @Etonkovidova wrote:

Tested in betalabs: when a message via Special:MassMessage is posted on a Flow board, a new topic is created. If a sender has this Flow board on his watchlist - the user will get notification.

Plus here's a link to the Blacklist config details, which still need to be better understood:
https://www.mediawiki.org/wiki/Extension:Echo#Usage
(AFAIK, the only wiki which utilises this is Enwiki - https://en.wikipedia.org/wiki/MediaWiki:Echo-blacklist ) (and I don't know how to search for the existence of local versions elsewhere, per T129698: Example quarry query for searching multiple wikis for locally customized mediawiki:foo pages)

Catrope claimed this task.Sep 19 2016, 11:52 PM
Catrope edited projects, added Collab-Team-Q1-July-Sep-2016; removed Collaboration-Team-Triage.
Catrope moved this task from Untriaged to In Development on the Collab-Team-Q1-July-Sep-2016 board.
In T86812#2650538, @Quiddity wrote:
In T144754#2630954, @Catrope wrote:

Idea: perhaps the delivery bot is on the user blacklist for mentions, and Flow mentions don't respect this blacklist while wikitext mentions do? If that's true, this would be a general bug not related to MassMessage.

I was wrong, it's just a simple hack in MassMessage: https://github.com/wikimedia/mediawiki-extensions-MassMessage/blob/master/MassMessage.hooks.php#L138 . That needs to be updated to add 'flow-mention', I'll do that now.

Catrope reassigned this task from Catrope to • KMuthu.Sep 20 2016, 6:48 PM
gerritbot subscribed.Sep 20 2016, 10:49 PM

Change 311854 had a related patch set uploaded (by Kmuthu):
MassMessage flow mention fixed

https://gerrit.wikimedia.org/r/311854

gerritbot added a project: Patch-For-Review.Sep 20 2016, 10:49 PM
Catrope moved this task from In Development to QA Review on the Collab-Team-Q1-July-Sep-2016 board.Sep 21 2016, 12:49 AM
gerritbot added a comment.Sep 21 2016, 12:49 AM

Change 311854 merged by jenkins-bot:
MassMessage flow mention fixed

https://gerrit.wikimedia.org/r/311854

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)).Sep 21 2016, 1:00 AM
Trizek-WMF awarded a token.Sep 21 2016, 8:08 AM
Etonkovidova added a comment.Sep 21 2016, 10:48 PM

Checked in betalabs - no extra notificaitons (self-mention notifications as described in the ticket).

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-Q1-July-Sep-2016 board.Sep 21 2016, 10:48 PM
• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016); removed Collab-Team-Q1-July-Sep-2016.Oct 5 2016, 6:34 PM
• jmatazzoni moved this task from Untriaged to Product Review on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.
• jmatazzoni closed this task as Resolved.Oct 5 2016, 6:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL