Page MenuHomePhabricator
Create Task
Maniphest T88250

Create tag list / tokenizer / capsule controls widget
Closed, ResolvedPublic
Actions

Description

We have a custom implementation in VE-MW settings for adding categories, but this should be genericised and improved. Phabricator's widget is a pretty good implementation to copy:

pasted_file (102×279 px, 9 KB)

Details

SubjectRepoBranchLines +/-
CapsuleMultiSelectWidget: Introduceoojs/uimaster+1 K -11
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT96906 Refactor UploadWizard to be maintainable
 DeclinedmatmarexT96520 Rewrite UploadWizard with mustache templates
 ResolvedmatmarexT97169 [EPIC] Enable UploadWizard on mobile
 ResolvedJdlrobsonT97188 Mustache templates in core do not support partials (client side)
 OpenNoneT49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
 OpenNoneT100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
 OpenNoneT100161 Convert all of MediaWiki core to OOUI PHP (tracking)
 OpenNoneT107037 Convert all MW core special pages to OOUI
 OpenNoneT117793 Convert Special:EditTags to OOUI
 ResolvedFlorianT39932 VisualEditor: Upload-by-insertion of images via copy-paste
 ResolvedEsandersT40031 VisualEditor: Initiate file upload by drag-and-drop
 ResolvedEsandersT40030 Way in VisualEditor to initiate Commons file uploading, and insert image on completion
 OpenFeatureNoneT35234 Image uploading social workflow and motivation - display result on context pages!
 Resolved• PrtksxnaT115748 Allow uploading files directly from the wikitext editor
 Resolved• PrtksxnaT91717 Be able to embed an upload dialog so that other extensions (e.g. WikiEditor, VisualEditor) can provide it to users
 ResolvedmatmarexT39128 Category adder should have "X" to remove additional categories
 OpenFeatureNoneT42076 UploadWizard: Implement interface like HotCat for suggesting categories
 ResolvedmatmarexT49052 Categories marked as not existing when copy/pasted
 OpenNoneT96911 Improve UploadWizard UX (tracking)
 ResolvedmatmarexT96914 Migrate UploadWizard UI elements to OOjs UI
 InvalidmatmarexT39124 Clarify that the (each) category field doesn't accept a list of categories
 ResolvedmatmarexT112764 Replace CoolCats with mw.widgets.CategorySelector
 OpenNoneT29312 Implement visual interface for changing the categories a page is in
 Resolved• PrtksxnaT111791 Create mw.widgets.CategorySelector
 ResolvedAnomieT88250 Create tag list / tokenizer / capsule controls widget

Event Timeline

Esanders created this task.Feb 1 2015, 9:29 PM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: OOUI.
Esanders subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2015, 9:29 PM
Jdforrester-WMF triaged this task as Medium priority.Feb 2 2015, 3:36 AM
Jdforrester-WMF subscribed.
matmarex renamed this task from Create tag list / tokenizer widget to Create tag list / tokenizer / capsule controls widget.EditedFeb 19 2015, 9:15 PM
matmarex set Security to None.
matmarex added subscribers: matmarex, • Jaredzimmerman-WMF.

Apparently has a design proposed way back. https://trello.com/c/eAl3YdVu/32-capsule-controls

Screenshot_2014-06-30_20.55.49.png (234×676 px, 29 KB)

• Jaredzimmerman-WMF added projects: UI-Standardization, Design.Feb 19 2015, 9:18 PM
• Jaredzimmerman-WMF added subscribers: • violetto, • Prtksxna.

Yep, we have designs for this. @matmarex

matmarex mentioned this in T91147: Create a generalised multi-select widget (aka CapsuleMultiselectWidget).Feb 28 2015, 2:11 AM
Ricordisamoa subscribed.Feb 28 2015, 2:27 AM
matmarex merged a task: T92261: Generalise VE's category input to a "Capsule input" widget in OOjs-UI core.Mar 10 2015, 6:17 PM
matmarex added subscribers: • werdna, • TrevorParscal.
• Jaredzimmerman-WMF moved this task from Incoming to Triaged on the Design board.Mar 12 2015, 2:19 AM
Ricordisamoa mentioned this in T53443: Replace Chosen with select2.Mar 26 2015, 3:41 AM
Rillke merged a task: T53443: Replace Chosen with select2.Mar 26 2015, 8:54 AM
Rillke added subscribers: Krinkle, Ciencia_Al_Poder, Rillke.
Anomie subscribed.Apr 10 2015, 2:34 PM

Phabricator's widget is a pretty good implementation to copy

Except for the part where it only shows you 5 possibilities, so if you want to browse the available options you're out of luck. When there's a known list of values I'd rather see something that displays the full (filtered) list in the popup instead of the top 5.

Jdforrester-WMF added a comment.Apr 10 2015, 3:23 PM
In T88250#1197955, @Anomie wrote:

Phabricator's widget is a pretty good implementation to copy

Except for the part where it only shows you 5 possibilities

Yes, poorly-configured widgets suck. However, I don't see anyone suggesting we should configure it the same way in real-world applications as Phabricator's maintainers have.

• werdna added a comment.Apr 10 2015, 3:24 PM

I needed one of these for my other job this week. Selectize.js is an outstanding choice if we can get over the NIH.

Ciencia_Al_Poder added a comment.Apr 10 2015, 4:29 PM

There's also select2.

Note that select2 is already being used in 2 extensions:

Semantic Forms: rESFO396bacb6bd5d555821c274760993b54d5d32dbf0
fundraising?: rWFDB8ff1cd8e1c1b1257a3c01e268799737207dd8f0b

is it worth adding to MediaWiki core?

matmarex added a comment.Apr 10 2015, 4:36 PM

MediaWiki core has Chosen, which is yet another implementation of the same thing. It is used at least by some OpenStackManager stuff.

gerritbot subscribed.Jul 15 2015, 10:38 PM

Change 224966 had a related patch set uploaded (by Anomie):
Add a capsule select widget

https://gerrit.wikimedia.org/r/224966

gerritbot added a project: Patch-For-Review.Jul 15 2015, 10:38 PM
Jdforrester-WMF assigned this task to Anomie.Jul 30 2015, 12:48 AM
Jdforrester-WMF moved this task from Backlog to Doing on the OOUI board.
gerritbot added a comment.Aug 10 2015, 12:27 PM

Change 224966 merged by jenkins-bot:
CapsuleMultiSelectWidget: Introduce

https://gerrit.wikimedia.org/r/224966

Jdforrester-WMF mentioned this in rGOJUa00578b46dc9: CapsuleMultiSelectWidget: Introduce.Aug 10 2015, 12:30 PM
Jdforrester-WMF closed this task as Resolved.Aug 10 2015, 3:01 PM
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.12.3), WMF-deploy-2015-08-18_(1.26wmf19); removed OOjs-UI-next-release.Aug 12 2015, 11:50 PM
Ryasmeen added a project: Verified-in-Phase0.Aug 19 2015, 9:47 PM
Ryasmeen added a project: Verified-in-Phase2.Aug 20 2015, 9:08 PM
Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.Aug 26 2015, 1:38 AM
matmarex added a parent task: T111791: Create mw.widgets.CategorySelector.Sep 18 2015, 12:52 PM
Ricordisamoa mentioned this in T117793: Convert Special:EditTags to OOUI.Jan 13 2016, 2:08 PM
Ricordisamoa added a parent task: T117793: Convert Special:EditTags to OOUI.
Danny_B moved this task from Unsorted to OOUI on the UI-Standardization board.May 20 2016, 8:59 PM
Aklapper removed subscribers: Anomie, • TrevorParscal, • werdna and 2 others.Oct 16 2020, 5:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL