Remove url endpointRemove mwDeprecated formatRemove extra field "publicationTitle" in itemType 'webpage' in Scraper.Update MAJOR version
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove deprecated endpoint and format | mediawiki/services/citoid | master | +19 -131 | |
| Fully restore Zotero data type integrity | mediawiki/services/citoid | master | +85 -79 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Duplicate | Mvolz | T93512 Remove incorrect field 'publicationTitle' for itemType 'webpage' in lib/scraper.js | |||
| Resolved | Mvolz | T93514 Update MAJOR version and remove mwDeprecated, url endpoint, and duplicate itemType: 'webpage' field publicationTitile | |||
| Resolved | Mvolz | T93518 Convert front facing page of citoid to use api instead of url endpoint | |||
| Resolved | Mvolz | T75993 Promisify Citoid and base it on service-template-node / service-runner | |||
| Resolved | Mvolz | T96363 Promisify html-metadata |
Event Timeline
Comment Actions
If we are going to make such breaking changes, IMHO, we should start versioning the API to provide for earlier versions for a longer period of time. So, instead of citoid.wm.org/api, I'd like to see citoid.wm.org/v2/api and possibly citoid.wm.org/{v1/}url/ redirecting to the new version.
Comment Actions
At the very least I'd like to get rid of the duplicate field ASAP; I care less about the other bits and bobs.
Currently citoid is at 0.0.0 so we could simply release this as 1.0.0, which is the first public API versioning according to semvar.org (even a 0.1.0 version has no expectation of public API consistency.)
But yes, going forward, any non-backwards compatible changes should be versioned off in some way.
I'm not totally set on removing the url endpoint, or the mwdeprecated format, but the reality is I think only one user gadget is using it now, and they're using the labs version (which pops up with a warning!) which I can just not update for as long as it takes for them to move over to the production service.
Comment Actions
Change 222898 had a related patch set uploaded (by Mvolz):
Fully restore Zotero data type integrity
Comment Actions
Change 347352 merged by Mobrovac:
[mediawiki/services/citoid@master] Remove deprecated endpoint and format
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2017-05-01T16:17:01Z] <mobrovac@naos> Started deploy [citoid/deploy@747777f]: Remove mwDeprecated - T93514
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2017-05-01T16:19:21Z] <mobrovac@naos> Finished deploy [citoid/deploy@747777f]: Remove mwDeprecated - T93514 (duration: 02m 19s)