This will probably roll forward to the next sprint, i just added it to Sprint-T so it doesn't get lost.

To be clear:

• This needs to apply on echo_target_page in every wiki on x1-master
• I can deploy this anytime now, without breaking code

Right?

Yes, that's correct.

Friendly bump. This is blocking T95860: A6. Notifications resulting from a conversation in flow do not disappear after visiting the page. .

Converting right now the schema. This is faster than I expected, even if I am doing the changes slowly. It should be done within an hour. I will update with details when finished.

@Mattflaschen May 22 14:49:48 UTC all tables named echo_target_page on x1 where successfully converted to:

CREATE TABLE `echo_target_page` (
  `etp_user` int(10) unsigned NOT NULL DEFAULT '0',
  `etp_page` int(10) unsigned NOT NULL DEFAULT '0',
  `etp_event` int(10) unsigned NOT NULL DEFAULT '0',
  `etp_id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  PRIMARY KEY (`etp_id`),
  KEY `echo_target_page_user_page_event` (`etp_user`,`etp_page`,`etp_event`),
  KEY `echo_target_page_user_event` (`etp_user`,`etp_event`)
) ENGINE=InnoDB AUTO_INCREMENT=N DEFAULT CHARSET=latin1`

Please note the new column position, so that it can be as compatible as posible.

3 wikis could not be converted because the table didn't exist on those schemas. As I suspect they can be private or special wikis, please ask me in private if clarification is needed.

If all this is valid for you, please close the ticket as Resolved. Thank you!

In T94427#1189486, @Springle wrote:

To be clear:

• This needs to apply on echo_target_page in every wiki on x1-master

My mistake. I did not realize that it also has to be applied on the four wikis listed at https://git.wikimedia.org/blob/operations%2Fmediawiki-config/20e51990e4775c1fffa0380aab5b94b2ba1c109e/wmf-config%2FInitialiseSettings.php#L14509 .

I believe this is now causing T107835: Fix new topic notification on MediaWiki.org . Sorry about that.

I performed an online ALTER TABLE, with the same structure as the original one, but on the core databases of mediawikiwiki, metawiki and officewiki. And a regular alter table on labswiki, on silver.

CREATE TABLE `echo_target_page` (
  `etp_user` int(10) unsigned NOT NULL DEFAULT '0',
  `etp_page` int(10) unsigned NOT NULL DEFAULT '0',
  `etp_event` int(10) unsigned NOT NULL DEFAULT '0',
  `etp_id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  PRIMARY KEY (`etp_id`),
  KEY `echo_target_page_user_page_event` (`etp_user`,`etp_page`,`etp_event`),
  KEY `echo_target_page_user_event` (`etp_user`,`etp_event`)
) ENGINE=InnoDB AUTO_INCREMENT=256 DEFAULT CHARSET=binary

Please indicate if we need to perform it on any more host (there were mentions of test[2]wiki, but those are not in the list you indicated).

In T94427#1570177, @jcrespo wrote:

Please indicate if we need to perform it on any more host (there were mentions of test[2]wiki, but those are not in the list you indicated).

I got one success 8 hours ago, but I'm still testing.

In T94427#1570177, @jcrespo wrote:

Please indicate if we need to perform it on any more host (there were mentions of test[2]wiki, but those are not in the list you indicated).

No. My testing and log search indicates it's fixed, and the only affected wikis should be the ones I linked. The test/test2 was based on suspecting a different cause.

Thanks again, and sorry for overlooking this earlier.

Checked general Echo functionality in betalabs.
Checked in db betalabs for enwiki - the changes seem to be applied.

MariaDB [enwiki]>  SHOW CREATE TABLE echo_target_page\G
*************************** 1. row ***************************
       Table: echo_target_page
Create Table: CREATE TABLE `echo_target_page` (
  `etp_user` int(10) unsigned NOT NULL DEFAULT '0',
  `etp_page` int(10) unsigned NOT NULL DEFAULT '0',
  `etp_event` int(10) unsigned NOT NULL DEFAULT '0',
  `etp_id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  PRIMARY KEY (`etp_id`),
  KEY `echo_target_page_user_page_event` (`etp_user`,`etp_page`,`etp_event`),
  KEY `echo_target_page_user_event` (`etp_user`,`etp_event`)
) ENGINE=InnoDB AUTO_INCREMENT=144246 DEFAULT CHARSET=binary
1 row in set (0.00 sec)

Does not look as they much used though - could be specific to betalbs@enwiki env

[enwiki]> select * from information_schema.INDEX_STATISTICS WHERE TABLE_SCHEMA='enwiki' and TABLE_NAME='echo_target_page' ORDER BY Rows_read DESC;
+--------------+------------------+----------------------------------+-----------+
| TABLE_SCHEMA | TABLE_NAME       | INDEX_NAME                       | ROWS_READ |
+--------------+------------------+----------------------------------+-----------+
| enwiki       | echo_target_page | echo_target_page_user_event      |         2 |
| enwiki       | echo_target_page | echo_target_page_user_page_event |         1 |
+--------------+------------------+----------------------------------+-----------+
2 rows in set (0.01 sec)