Page MenuHomePhabricator
Create Task
Maniphest T99351

Review and deploy Wikibase-Quality on wikidata.org
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

https://www.mediawiki.org/wiki/WikidataQuality

Please install Wikibase-Quality (Branch v1 on Gerrit) on wikidata.org
Thank you very much!

See also: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/WikibaseQuality

Details

SubjectRepoBranchLines +/-
Enable WikibaseQuality and WikibaseQualityConstraints on wikidataoperations/mediawiki-configmaster+1 -5
Default wmgUseWikibaseQuality on beta to true.operations/mediawiki-configmaster+5 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedLydia_PintscherT99351 Review and deploy Wikibase-Quality on wikidata.org
 InvalidAndreasburmeisterT99353 Performance review of Wikibase-Quality
 Resolved• csteippT99352 Security review of Wikibase-Quality
 Resolved• csteippT102649 Ex:WikibaseQuality - Needs to escape output by default
 ResolveddanielT100991 General code-review of WikidataQuality extension
 InvalidNoneT103817 [Epic] version 2 of the quality extensions
Restricted Task
 ResolvedNoneT103311 [Task] Assure Security for everything not in v1
 Declined• csteippT103818 [Task] Security review of Wikibase-Quality master
 Declined• csteippT103819 [Task] Security review of Wikibase-Quality-Constraints - master branch
 Declined• csteippT103822 [Task] Security review of Wikibase-Quality-External-Validation branch master
 DeclinedNoneT99357 [Story] Review and deploy Wikibase-Quality-External-Validation on wikidata.org
 InvalidAndreasburmeisterT99359 Performance review of Wikibase-Quality-External-Validation
 DeclinedNoneT99358 [Task] Security review of Wikibase-Quality-External-Validation branch master
 Resolvedsoeren.oldagT103438 Ex:WikibaseQualityExternalValidation - don't use .tar / phar to transfer files to production
 Resolved• csteippT103439 Ex:WikibaseQualityExternalValidation - DumpMetaInformationRepo needs to strictly validate table names
 Resolved• csteippT103633 Ex:WikibaseQualityExternalValidation - SpecialExternalDbs escape or don't use raw cells
 ResolvedJonas.keutelT103905 Ex:WikibaseQualityExternalValidation - rate limit Special:CrossCheck
 DeclinedNoneT103912 [Task] Ex:WikibaseQualityExternalValidation - performance review of Special:CrossCheck
 ResolvedJanZerebeckiT97423 (Re-)Naming our extension(s)
 ResolveddanielT100993 General code-review of WikidataQualityExternalValidation extension
 ResolvedNoneT103814 enable quality extensions on test.wikidata.org
 ResolvedJanZerebeckiT103815 enable quality extensions on www.wikidata.org
 ResolveddanielT102992 [Task] Review WikidataQuality DB schema
 ResolvedAddshoreT112096 [Task] Rename Special:ExternalDbs to Special:ExternalDatabases
 ResolvedaudeT112451 [Task] Include WikibaseQualityExternalValidation in the Wikidata build (enabled for jenkins only, pending security + performance review)
 DeclinedNoneT113036 [Story] Improve WikibaseQualityExternalValidation dump download scripts
 DeclinedNoneT113219 [Task] Use settings instead of constants for Wikidata property and item ids
 ResolvedLucas_Werkmeister_WMDET102759 [Story] Migrate constraints from property talk pages to statements on properties
 ResolvedLucas_Werkmeister_WMDET102760 [Task] Hooks to keep constraint table up to date.
 ResolvedLucas_Werkmeister_WMDET167106 Import type and value type constraints from statements
 ResolvedLucas_Werkmeister_WMDET167107 Import inverse constraints from statements
 ResolvedLucas_Werkmeister_WMDET167108 Import item constraints from statements
 ResolvedLucas_Werkmeister_WMDET167109 Import target required claim constraints from statements
 ResolvedLucas_Werkmeister_WMDET167110 Import conflicts with constraints from statements
 ResolvedLucas_Werkmeister_WMDET167111 Import one of constraints from statements
 ResolvedLucas_Werkmeister_WMDET167399 Translate constraint type Q-IDs into strings
 ResolvedLucas_Werkmeister_WMDET167413 Import range constraints from statements
 ResolvedLucas_Werkmeister_WMDET167414 Import diff within range constraints from statements
 ResolvedLucas_Werkmeister_WMDET167415 Import qualifiers constraints from statements
 ResolvedLucas_Werkmeister_WMDET167416 Import mandatory qualifiers constraints from statements
 ResolvedLucas_Werkmeister_WMDET167417 Import commons link constraints from statements
 ResolvedLucas_Werkmeister_WMDET167418 Import format constraints from statements
 ResolvedLucas_Werkmeister_WMDET169430 Import constraint exceptions from constraint statements
 ResolvedhooT169647 Enable constraint statements on Wikidata
 ResolvedLucas_Werkmeister_WMDET169218 Create maintenance script to run constraintsTableUpdate jobs for all properties
 ResolvedLydia_PintscherT97018 [Story] Integrate violations into Wikidata UI
 InvalidLydia_PintscherT103259 [Story] Improve constraint UI for item page
 InvalidNoneT103109 [Task] UI Tests for all JavaScripts Modules
 InvalidLydia_PintscherT103260 [Task] Format long message for external Mismatch
 ResolvedLucas_Werkmeister_WMDET95403 [Task] Investigation: Find a good place where to put icons for violation indication
 ResolvedLucas_Werkmeister_WMDET180120 Snakview value is overflowing edit toolbar
 Resolvedsoeren.oldagT96859 Parse additional information depending on type of violation
 DeclinedNoneT110039 [Story] Unified API and SpecialPage for internal and external constraint violations
 ResolvedLydia_PintscherT118273 [Task] add a tab to the top tab bar to initiate quality check
 ResolvedLydia_PintscherT118274 [Story] Show the quality indicators
 ResolvedLydia_PintscherT118275 [Task] Remove the quality indicator icon after saving a statement
 ResolvedLydia_PintscherT164051 [Task] Allow translation of the messages
 ResolvedLucas_Werkmeister_WMDET164065 Pattern parameter in detailHTML for format constraint is HTML-escaped twice
 InvalidNoneT164143 [Bug] Conflict with the "drag'n'drop" gadget
 ResolvedLydia_PintscherT164353 UX Design and functionality for Wikidata Value/Property constraint checks/Violations
 ResolvedJan_DittrichT164352 UI Design for Constraint Checks/Violations
 ResolvedLucas_Werkmeister_WMDET164829 Fix alignment constraint check notification headline and close button
ResolvedJan_DittrichT164831 Investigate Design of the Icon
 OpenNoneT167127 Standard UI for including statements in constraint violation messages
 ResolvedLucas_Werkmeister_WMDET169121 Add tests for ConstraintParameterRenderer
 ResolvedLadsgroupT164351 Add helpful links to constraint reports
 ResolvedLydia_PintscherT164354 Check wording of messages/constraint check results
 ResolvedLydia_PintscherT164746 Check wordings with users to improve messages before releasing them to translation
 ResolvedLucas_Werkmeister_WMDET164360 Name/Wording of the function: Alternative to "Constraint violations"

Event Timeline

Tamslo created this task.May 16 2015, 10:50 AM
Tamslo raised the priority of this task from to Needs Triage.
Tamslo updated the task description. (Show Details)
Tamslo added a project: Wikibase-Quality.
Tamslo added subscribers: Wikibase-Quality, Lydia_Pintscher.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 16 2015, 10:50 AM
Tamslo renamed this task from Review and deploy Wikibase Quality on wikidata.org to Review and deploy Wikibase-Quality on wikidata.org.May 16 2015, 10:53 AM
Tamslo added subtasks: T99353: Performance review of Wikibase-Quality, T99352: Security review of Wikibase-Quality, T97423: (Re-)Naming our extension(s).
Tamslo set Security to None.
Tamslo added a parent task: T33235: [DO NOT USE] Extensions awaiting code review to be deployed on Wikimedia wikis (tracking) [superseded by #wikimedia-extension-review-queue].
Tamslo updated the task description. (Show Details)May 16 2015, 11:10 AM
Ricordisamoa subscribed.May 16 2015, 1:21 PM
Reedy subscribed.EditedMay 16 2015, 4:24 PM

For sake of stating the obvious, this is something that is wanted (and probably more applicably, ready?) to be deployed to Wikidata? And the WMDE dev team have OK'd this?

Also, who is going to be doing most of the review? WMDE or WMF? As we all know, Chris doesn't have a lot of free time for large security reviews, and similar can probably be said for Ori and Aaron...

hoo triaged this task as High priority.May 16 2015, 4:25 PM
hoo added a project: Wikidata.
hoo subscribed.
hoo added subscribers: greg, • mmodell.May 16 2015, 4:27 PM

I think WMDE should handle most of the code review here, also we are should probably be the ones that deploy this extension.

Lydia_Pintscher added a comment.May 16 2015, 9:30 PM

Yes we'll do the basic code review at WMDE. Security and performance review should come from WMF.
The extension is ok'd and wanted from WMDE. The functionality is productizing and extending existing functionality the Wikidata community has built so we're all good there as well.

Liuxinyu970226 subscribed.May 17 2015, 10:23 PM
dominic.sauer closed subtask T97423: (Re-)Naming our extension(s) as Resolved.May 18 2015, 9:08 AM
JanZerebecki reopened subtask T97423: (Re-)Naming our extension(s) as Open.May 18 2015, 2:21 PM
Andreasburmeister closed subtask T99353: Performance review of Wikibase-Quality as Invalid.May 24 2015, 7:21 PM
Yair_rand subscribed.May 28 2015, 8:04 AM
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Jun 12 2015, 10:57 AM
JanZerebecki subscribed.Jun 12 2015, 4:44 PM

Patch to include the extensions in the build: https://github.com/wmde/WikidataBuildResources/pull/27

JanZerebecki closed subtask T97423: (Re-)Naming our extension(s) as Resolved.Jun 18 2015, 5:37 PM
Tamslo subscribed.Jun 18 2015, 6:14 PM

Scripts, Maintenance Scripts and Databases for the Quality Extensions

Wikibase Quality

  • Database 'wbq_violations' [no need to do anything here]

Wikibase Quality Constraints T99354

  • Database 'wbqc_constraints'

Wikibase Quality External Validation T99357

  • Database 'wbqev_exernal_data'
  • Database 'wbqev_dump_information'
  • Database 'wbqev_identifier_properties'
    • parse external data and meta data to create csv-files with https://github.com/WikidataQuality/DumpConverter [instructions in Readme] (ca. 120 min, 2,500,000 lines)
    • the csv-files are compressed into a single tar-archive
    • insert into tables with maintenance/UpdateTable.php [usage: pass tar-file with --tar-file <path-to-tar-file]
JanZerebecki moved this task from Backlog to TODO on the Wikibase-Quality board.Jun 18 2015, 10:23 PM
Tamslo moved this task from TODO to Beyond our power on the Wikibase-Quality board.Jun 19 2015, 2:37 PM
• csteipp closed subtask T99352: Security review of Wikibase-Quality as Resolved.Jun 20 2015, 12:13 AM
gerritbot subscribed.Jun 21 2015, 5:14 PM

Change 219630 had a related patch set uploaded (by JanZerebecki):
Default wmgUseWikibaseQuality on beta to true.

https://gerrit.wikimedia.org/r/219630

gerritbot added a project: Patch-For-Review.Jun 21 2015, 5:14 PM
gerritbot added a comment.Jun 22 2015, 3:01 PM

Change 219630 merged by jenkins-bot:
Default wmgUseWikibaseQuality on beta to true.

https://gerrit.wikimedia.org/r/219630

JanZerebecki mentioned this in rOMWC11b97114f1f8: Default wmgUseWikibaseQuality on beta to true..Jun 22 2015, 3:01 PM
JanZerebecki added a comment.Jun 22 2015, 3:26 PM

WikibaseQuality is now enabled on beta, see http://wikidata.beta.wmflabs.org/wiki/Special:Version .

Tamslo updated the task description. (Show Details)Jun 23 2015, 9:13 AM
Tamslo added a comment.Jun 23 2015, 9:18 AM

The URL of the repository changed, see the description.

JanZerebecki added a project: Wikidata-Sprint-2015-06-16.Jun 23 2015, 12:51 PM
Tobi_WMDE_SW edited a custom field.Jun 24 2015, 10:08 AM
JanZerebecki moved this task from Backlog to Done on the Wikidata-Sprint-2015-06-16 board.Jun 25 2015, 10:51 AM
daniel closed subtask T100991: General code-review of WikidataQuality extension as Resolved.Jun 26 2015, 11:29 AM
Lydia_Pintscher moved this task from ready to go to consider for next sprint on the Wikidata board.Jun 29 2015, 12:54 PM
JanZerebecki closed subtask T103814: enable quality extensions on test.wikidata.org as Resolved.Jun 30 2015, 9:43 PM
gerritbot added a comment.Jul 6 2015, 11:33 AM

Change 223011 had a related patch set uploaded (by Hoo man):
Enable WikibaseQuality and WikibaseQualityConstraints on wikidata

https://gerrit.wikimedia.org/r/223011

gerritbot added a comment.Jul 6 2015, 12:16 PM

Change 223011 merged by jenkins-bot:
Enable WikibaseQuality and WikibaseQualityConstraints on wikidata

https://gerrit.wikimedia.org/r/223011

hoo mentioned this in rOMWC6d30d7f894e1: Enable WikibaseQuality and WikibaseQualityConstraints on wikidata.Jul 6 2015, 12:16 PM
JanZerebecki closed this task as Resolved.Jul 6 2015, 12:35 PM
JanZerebecki claimed this task.

https://www.wikidata.org/wiki/Special:ConstraintReport/Q146

JanZerebecki reopened this task as Open.Jul 6 2015, 12:36 PM

Wrong ticket.

JanZerebecki closed subtask T103815: enable quality extensions on www.wikidata.org as Resolved.Jul 6 2015, 12:36 PM
JanZerebecki removed JanZerebecki as the assignee of this task.Jul 23 2015, 4:50 PM
JanZerebecki moved this task from consider for next sprint to ready to go on the Wikidata board.Jul 23 2015, 4:54 PM
Lydia_Pintscher closed this task as Resolved.Aug 7 2015, 5:40 PM
Lydia_Pintscher claimed this task.
Liuxinyu970226 unsubscribed.Aug 7 2015, 10:03 PM
Lydia_Pintscher closed subtask T103817: [Epic] version 2 of the quality extensions as Invalid.Jul 5 2017, 9:53 AM
MarcoAurelio added a project: Wikimedia-extension-review-queue.Aug 26 2017, 9:39 AM
MarcoAurelio removed a parent task: T33235: [DO NOT USE] Extensions awaiting code review to be deployed on Wikimedia wikis (tracking) [superseded by #wikimedia-extension-review-queue].Aug 26 2017, 9:43 AM
MarcoAurelio moved this task from Backlog to Live in production on the Wikimedia-extension-review-queue board.Aug 26 2017, 9:52 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL