Maniphest T208631

Copy/Paste of images in Visual editor does not work browser page to browser page as expected
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Thedonquixotic
	Nov 2 2018, 9:17 PM

Description

Hi,

I hope I'm giving enough info on this issue. I'm new to the mediawiki community (and development in general) but I thought I'd log a bug I'd noticed.

Expected behavior: When I right click and "copy" an image in one tab of my browser, that I can go over to the Visual Editor and paste that image into a page that is being edited. Also expected is the ability to drag and drop an image from one tab to the next.

Actual behavior: it does nothing.

See attached video.

output2.mkv1 MBDownload

Also see previous discussion that led to creation of this issue. https://phabricator.wikimedia.org/T39932

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (1d9e3a217)	mediawiki/extensions/VisualEditor	master	+1 -1
	ve.ce.Surface: handles clipboard images with HTML	VisualEditor/VisualEditor	master	+101 -4

Customize query in gerrit

Related Objects

Mentioned Here: rGVED1d9e3a217eb5: ve.ce.Surface: Add more handleDataTransfer tests
T39932: VisualEditor: Upload-by-insertion of images via copy-paste

Event Timeline

Thedonquixotic created this task.Nov 2 2018, 9:17 PM

Restricted Application added a project: Multimedia. · View Herald TranscriptNov 2 2018, 9:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Sophivorus awarded a token.Nov 3 2018, 12:32 AM

This task seems to cover two different things? Drag and drop (which isn't shown in the video but mentioned in the task summary?), and also copying to your system's clipboard uploading and then pasting/uploading the "Media settings > Upload" dialog in VisualEditor (which does not seem to save the image?).

https://phabricator.wikimedia.org/T39932#4708223 is the relevant information for the latter.

@Aklapper Task has been renamed to reflect more focused/accurate issue.

@Thedonquixotic: I'm confused. Your video above does not show copying from browser page to browser page, but from some application called Paint (I think?) to a browser page instead.

@Aklapper Apologies again, I uploaded the wrong video. The original was also linked in the previous thread and I'll reupload it here and edit my original issue.

Thedonquixotic updated the task description. (Show Details)Nov 6 2018, 3:16 PM

In T39932#4708223, @matmarex wrote:
Interesting. Turns out that when you copy an image in the browser, it is stored in the clipboard in two formats: as the actual image, and as HTML like this:
<html>
<body>
<img src="https://apod.nasa.gov/apod/image/1705/Arp273Main_HubblePestana_3079.jpg" alt="Image result for galaxy"/>
</body>
</html>
When this is pasted into VisualEditor, we use the HTML instead of the image (ve.ce.Surface.prototype.handleDataTransfer), because:
	// Only look for files if HTML is not available:
	//  - If a file is pasted/dropped it is unlikely it will have HTML fallback (it will have plain text fallback though)
	//  - HTML generated from some clients has an image fallback(!) that is a screenshot of the HTML snippet (e.g. LibreOffice Calc)
Then our paste sanitization strips that HTML down to nothing (since <img> tags using external resources are not possible in wikitext), and then nothing is pasted.

@Thedonquixotic Can you file a separate task about this?

(As a workaround, I guess you can paste into Paint, then copy from Paint.)

Urfiner awarded a token.Nov 7 2018, 9:11 PM

Urfiner rescinded a token.

Urfiner awarded a token.

Urfiner subscribed.

osorio-juan-microsoft awarded a token.Jan 14 2019, 7:02 PM

osorio-juan-microsoft subscribed.Jan 15 2019, 5:13 PM

Pinging stakeholders: It seems to me that a good potential solution would be to use the image (rather than the HTML) if and only if the HTML content only contains metadata node, empty text nodes, and the image(s) themselves. In other words, if the HTML contains any actual content (text or otherwise) other than the image(s), it should be used instead of the image. I have some working fix that I validated by pasting a single image from multiple popular sources, such as Chrome, One Note, and Word. If nobody has objections to the implementation, I'll go ahead and submit a patch.

Sounds reasonable to me.

matmarex removed projects: SRE-swift-storage, UploadWizard.Feb 5 2019, 8:34 PM

Change 488993 had a related patch set uploaded (by Juan Osorio (Microsoft); owner: Juan Osorio (Microsoft)):
[VisualEditor/VisualEditor@master] ve.ce.Surface: handles clipboard images with HTML

https://gerrit.wikimedia.org/r/488993

gerritbot added a project: Patch-For-Review.Feb 7 2019, 6:58 PM

JTannerWMF edited projects, added VisualEditor (Current work); removed VisualEditor.Feb 12 2019, 4:30 PM

JTannerWMF moved this task from Incoming to Code review on the VisualEditor (Current work) board.

matmarex renamed this task from Copy/Paste in Visual editor does not work browser page to browser page as expected to Copy/Paste of images in Visual editor does not work browser page to browser page as expected.Feb 12 2019, 6:57 PM

Change 488993 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ce.Surface: handles clipboard images with HTML

https://gerrit.wikimedia.org/r/488993

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Feb 13 2019, 10:07 AM

matmarex removed a project: Multimedia.

JTannerWMF added a project: Editing QA.Feb 13 2019, 6:43 PM

Esanders moved this task from Inbox to Low Priority on the Editing QA board.Feb 13 2019, 6:47 PM

Change 490478 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1d9e3a217)

https://gerrit.wikimedia.org/r/490478

Change 490478 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1d9e3a217)

https://gerrit.wikimedia.org/r/490478

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.18; 2019-02-19).Feb 14 2019, 12:01 AM

Ryasmeen edited projects, added Verified; removed Editing QA, Patch-For-Review.Mar 1 2019, 1:08 AM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Mar 1 2019, 1:23 AM

ppelberg closed this task as Resolved.Mar 14 2019, 10:52 PM

ppelberg claimed this task.