| kaldari | |
| Jun 25 2021, 7:11 PM |
| F34560648: depicts_added2.gif | |
| Jul 23 2021, 1:39 AM |
| F34560645: depicts_added.gif | |
| Jul 23 2021, 1:39 AM |
| F34560611: image.png | |
| Jul 23 2021, 12:47 AM |
| F34548931: Screen Shot 2021-07-12 at 12.36.54 PM.png | |
| Jul 12 2021, 7:45 PM |
| F34548928: Screen Shot 2021-07-12 at 12.34.02 PM.png | |
| Jul 12 2021, 7:45 PM |
| F34548933: Screen Shot 2021-07-12 at 12.36.16 PM.png | |
| Jul 12 2021, 7:45 PM |
| F34534844: Screen Shot 2021-07-01 at 3.05.08 PM.png | |
| Jul 1 2021, 10:17 PM |
| F34534848: Screen Shot 2021-07-01 at 2.59.35 PM.png | |
| Jul 1 2021, 10:17 PM |
Bug report copied from Commons: "This used to show a search field for entry of Wikidata items. It now just has a link to "depicts" in Wikidata and if you click the "Add statement" field and enter a search term, even for one you know exists, its says "no results found"."
I confirmed that the bug report is accurate and the "Add data" step no longer works.
Confirmed, looks like this. (“Add a statement” finds no results because it’s searching for properties for other statements, not items as the “depicts” value, but I also fell for this before realizing that there must be an input field missing.)
Change 702105 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Seperate between <submit> and <edit> controls
Change 702105 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Seperate between <submit> and <edit> controls
Checked in betalabs - the depicts field is displayed:
Note: it seems that "No results found" for Add statement field works in commons wmf.12:
Change 702810 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.37.0-wmf.12] Seperate between <submit> and <edit> controls
I can deploy it if anyone from the team is around to verify the fix and check for further issues. Just ping me in IRC (Amir1) or here.
Change 702810 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.37.0-wmf.12] Seperate between <submit> and <edit> controls
Mentioned in SAL (#wikimedia-operations) [2021-07-02T10:33:11Z] <jforrester@deploy1002> Synchronized php-1.37.0-wmf.12/extensions/WikibaseMediaInfo: UploadWizard/WikibaseMediaInfo fix 3fd2873 for [[phab:T285579|T285579]] (duration: 00m 59s)
Not sure if this is part of this task, but the Add Meta-Data Step is in the UploadWizard is still not working as it was. Previously it asked which features were prominent in the image. It no longer appears to do that.
"Add data" step doesn't have an option to "Mark as prominent" until depicts would be saved, e.g.
| depicts are not added yet | depicts added but not published | depicts published, "Mark as prominent" is displayed |
|---|---|---|
 |  |  |
@Kerry_Raymond - Did "Mark as prominent" feature previously appear before publishing?
Yes. You were asked to add a "depicts". Once you had chosen one, it showed it with "Mark as prominent". You could either mark it as prominent at the point, or you could add further depicts and then mark the prominent ones later, prior to the final Publish. Since the problem that triggered this bug report, I do not see any "Mark as prominent" appearing any more. See this screen shot for the uploading I just did https://commons.wikimedia.org/wiki/File:Kuranda_Fig_Tree_Avenue,_Species_Map,_2018.jpg
Previously I would have seen the "Mark as prominent" option available on both "map" and "Kuranda". In this case I would have "marked as prominent" the "map" depicts.
Thanks @Kerry_Raymond - reopening since "Mark as prominent' should appear before depicts get published.
There is some inconsistency in displaying "Mark as prominent" between two cases: (1) when depicts are added to previously published depicts - then, "Mark as prominent" will be displayed before publishing and (2) when depicts are initially added (a file doesn't have previously published depicts) - "Mark as prominent" will be displayed only after some depicts are saved.
(1) when depicts are added to previously published depicts - then, "Mark as prominent" will be displayed before publishing, as soon as a depicts is selected (click yo see the animated gif below).
(2) when depicts are initially added (a file doesn't have previously published depicts) - "Mark as prominent" will be displayed only after some depicts are saved (click yo see the animated gif below).
Change 723439 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Re-enable \"mark as prominent\" in UW
Change 723439 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Re-enable \"mark as prominent\" in UW
Checked on commons wiki wmf.2 - works as expected.
@matthiasmullie - any additional work needs to be done here?