Page MenuHomePhabricator
Create Task
Maniphest T304127

InvalidArgumentException: The revision does not belong to the given page.
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   InvalidArgumentException: The revision does not belong to the given page.
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.26/includes/page/ParserOutputAccess.php(365)
#0 /srv/mediawiki/php-1.38.0-wmf.26/includes/page/ParserOutputAccess.php(267): MediaWiki\Page\ParserOutputAccess->checkPreconditions(FlaggableWikiPage, MediaWiki\Revision\RevisionStoreRecord, integer)
#1 /srv/mediawiki/php-1.38.0-wmf.26/extensions/FlaggedRevs/backend/FlaggedRevs.php(826): MediaWiki\Page\ParserOutputAccess->getParserOutput(FlaggableWikiPage, ParserOptions, MediaWiki\Revision\RevisionStoreRecord)
#2 /srv/mediawiki/php-1.38.0-wmf.26/extensions/FlaggedRevs/backend/FlaggedRevsHooks.php(505): FlaggedRevs::autoReviewEdit(FlaggableWikiPage, User, MediaWiki\Revision\RevisionStoreRecord, array)
#3 /srv/mediawiki/php-1.38.0-wmf.26/includes/HookContainer/HookContainer.php(338): FlaggedRevsHooks::maybeMakeEditReviewed(WikiPage, MediaWiki\Revision\RevisionStoreRecord, boolean, User, array)
#4 /srv/mediawiki/php-1.38.0-wmf.26/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#5 /srv/mediawiki/php-1.38.0-wmf.26/includes/HookContainer/HookRunner.php(3184): MediaWiki\HookContainer\HookContainer->run(string, array)
#6 /srv/mediawiki/php-1.38.0-wmf.26/includes/Storage/PageUpdater.php(1471): MediaWiki\HookContainer\HookRunner->onRevisionFromEditComplete(WikiPage, MediaWiki\Revision\RevisionStoreRecord, boolean, User, array)
#7 /srv/mediawiki/php-1.38.0-wmf.26/includes/Storage/PageUpdater.php(911): MediaWiki\Storage\PageUpdater->doCreate(CommentStoreComment)
#8 /srv/mediawiki/php-1.38.0-wmf.26/includes/MovePage.php(1007): MediaWiki\Storage\PageUpdater->saveRevision(CommentStoreComment)
#9 /srv/mediawiki/php-1.38.0-wmf.26/includes/MovePage.php(686): MovePage->moveToInternal(User, Title, string, boolean, array)
#10 /srv/mediawiki/php-1.38.0-wmf.26/includes/MovePage.php(532): MovePage->moveUnsafe(User, string, boolean, array)
#11 /srv/mediawiki/php-1.38.0-wmf.26/includes/specials/SpecialMovepage.php(721): MovePage->moveIfAllowed(User, string, boolean)
#12 /srv/mediawiki/php-1.38.0-wmf.26/includes/specials/SpecialMovepage.php(207): MovePageForm->doSubmit()
#13 /srv/mediawiki/php-1.38.0-wmf.26/includes/specialpage/SpecialPage.php(671): MovePageForm->execute(NULL)
#14 /srv/mediawiki/php-1.38.0-wmf.26/includes/specialpage/SpecialPageFactory.php(1378): SpecialPage->run(NULL)
#15 /srv/mediawiki/php-1.38.0-wmf.26/includes/MediaWiki.php(315): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#16 /srv/mediawiki/php-1.38.0-wmf.26/includes/MediaWiki.php(910): MediaWiki->performRequest()
#17 /srv/mediawiki/php-1.38.0-wmf.26/includes/MediaWiki.php(564): MediaWiki->main()
#18 /srv/mediawiki/php-1.38.0-wmf.26/index.php(53): MediaWiki->run()
#19 /srv/mediawiki/php-1.38.0-wmf.26/index.php(46): wfIndexMain()
#20 /srv/mediawiki/w/index.php(3): require(string)
#21 {main}
Impact
Notes

Details

Request URL
https://pl.wikipedia.org/w/index.php?title=*&action=submit
SubjectRepoBranchLines +/-
Don't pass the revision to PO access servicemediawiki/extensions/FlaggedRevsmaster+1 -2
Don't pass the revision to PO access servicemediawiki/extensions/FlaggedRevswmf/1.38.0-wmf.26+1 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasejeenaT300202 1.38.0-wmf.26 deployment blockers
 ResolvedPRODUCTION ERRORLadsgroupT304127 InvalidArgumentException: The revision does not belong to the given page.

Event Timeline

jeena created this task.Mar 17 2022, 10:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2022, 10:58 PM
Reedy added a project: MediaWiki-extensions-FlaggedRevs.Mar 18 2022, 1:14 AM
Ladsgroup merged a task: T304156: InvalidArgumentException when trying to move a page in the german language version.Mar 18 2022, 2:10 PM
Ladsgroup added subscribers: M2k_dewiki, alaa, Func, hgzh.
Ladsgroup subscribed.

This seems important. I try to make a patch soon.

Zabe subscribed.Mar 18 2022, 2:15 PM

wrong.png (177×663 px, 8 KB)

heavily went up with the train

Zabe added a parent task: T300202: 1.38.0-wmf.26 deployment blockers.Mar 18 2022, 2:18 PM
gerritbot added a comment.Mar 18 2022, 2:20 PM

Change 771900 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/FlaggedRevs@master] Don't pass the revision to PO access service

https://gerrit.wikimedia.org/r/771900

gerritbot added a project: Patch-For-Review.Mar 18 2022, 2:20 PM
Ladsgroup claimed this task.Mar 18 2022, 2:20 PM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMar 18 2022, 2:20 PM
gerritbot added a comment.Mar 18 2022, 2:21 PM

Change 771907 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/FlaggedRevs@wmf/1.38.0-wmf.26] Don't pass the revision to PO access service

https://gerrit.wikimedia.org/r/771907

Func unsubscribed.Mar 18 2022, 2:22 PM
gerritbot added a comment.Mar 18 2022, 2:25 PM

Change 771900 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Don't pass the revision to PO access service

https://gerrit.wikimedia.org/r/771900

gerritbot added a comment.Mar 18 2022, 2:25 PM

Change 771907 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@wmf/1.38.0-wmf.26] Don't pass the revision to PO access service

https://gerrit.wikimedia.org/r/771907

Stashbot added a comment.Mar 18 2022, 2:26 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-18T14:26:56Z] <ladsgroup@deploy1002> Synchronized php-1.38.0-wmf.26/extensions/FlaggedRevs/backend/FlaggedRevs.php: Backport: [[gerrit:771907|Don't pass the revision to PO access service (T304127)]] (duration: 00m 49s)

Ladsgroup added a comment.Mar 18 2022, 2:27 PM

It should be deployed now. Can you tell if it's fixed? And if the old and new page is in correct shape?

I generally suggest opting out of FlaggedRevs, it's a problematic codebase.

M2k_dewiki added a comment.Mar 18 2022, 2:34 PM

Moving of

https://de.wikipedia.org/wiki/Currents

to

https://de.wikipedia.org/wiki/Currents_(Band)

worked for me.

https://de.wikipedia.org/w/index.php?title=Currents_%28Band%29&type=revision&diff=221274897&oldid=216056739

Thanks a lot!

Ladsgroup closed this task as Resolved.Mar 18 2022, 2:35 PM

And all are [automatisch gesichtet]. Awesome. Calling it done.

alaa awarded a token.Mar 18 2022, 2:38 PM
ReleaseTaggerBot added projects: MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early), MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 18 2022, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 18 2022, 3:10 PM
Krinkle moved this task from Untriaged to Mar 2022 on the Wikimedia-production-error board.Mar 22 2022, 1:45 PM
Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Mar 22 2022, 2:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL