Page MenuHomePhabricator

Geoline is shown in the article, but not in full size map view
Closed, ResolvedPublic5 Estimated Story PointsBUG REPORT

Description

Seen on https://de.wikipedia.org/wiki/Benutzer:Albatros_58/Karten_2
("Kochelseebahn")

In the article, the map shows a line:

Bildschirmfoto 2022-07-13 um 10.31.16.png (802×2 px, 474 KB)

That line disappears when you open the map in full size:

Bildschirmfoto 2022-07-13 um 10.32.03.png (1×2 px, 2 MB)

Another example: https://de.wikipedia.org/w/index.php?title=Benutzerin:Johanna_Strodt_(WMDE)/Spielwiese/Kartentests

previewarticlefull size
Bildschirmfoto 2022-07-13 um 16.55.14.png (1×2 px, 508 KB)
Bildschirmfoto 2022-07-13 um 16.55.08.png (1×2 px, 637 KB)
Bildschirmfoto 2022-07-13 um 16.55.24.png (1×2 px, 877 KB)

Timeboxed: 5

Event Timeline

As of now, the 1st example works for me in both the thumbnail view as well as fullscreen.

I can't find the 2nd example anywhere in the history of https://de.wikipedia.org/wiki/Benutzerin:Johanna_Strodt_(WMDE)/Spielwiese/Kartentests.

I was playing around with this URL:

In other words: No wonder we have so many broken examples where either the thumbnail or the fullscreen map (or both) don't show the shape. Unfortunately I have no idea how to proceed from here.

As of now, the 1st example works for me in both the thumbnail view as well as fullscreen.

On my device, the problem currently exists:

Bildschirmfoto 2022-08-01 um 10.56.37.png (1×2 px, 892 KB)
Bildschirmfoto 2022-08-01 um 10.56.42.png (1×2 px, 2 MB)

I can't find the 2nd example anywhere in the history of https://de.wikipedia.org/wiki/Benutzerin:Johanna_Strodt_(WMDE)/Spielwiese/Kartentests.

It was hidden in the history, I have now added it back to the current version. My apologies for sending you searching.
For me, the line is currently not shown at all:

Bildschirmfoto 2022-08-01 um 10.58.47.png (1×2 px, 542 KB)
Bildschirmfoto 2022-08-01 um 10.58.51.png (1×2 px, 909 KB)
Bildschirmfoto 2022-08-01 um 10.59.04.png (1×2 px, 566 KB)
  • I also have seen empty results like {"type":"FeatureCollection","features":[]} but currently can't reproduce this any more.

@thiemowmde maybe T313844 is of interest as well?

I can confirm that the last example is because of the same "random failure". When I add a dummy parameter to the end of https://maps.wikimedia.org/geoline?getgeojson=1&ids=Q35333853 I sometimes get the data, sometimes empty GeoJSON as shown above, and sometimes a 404.

T313844 appears to be something else.

I assume there's some caching and replication involved in the entire setup (Is there any documentation of the architecture availble? Couldn't find it on first glimpse). Could it be related to a single rogue server in a load balanced farm behind some cache line? Because that's what it looks like to me. It works most of the time, sometime it breaks, but after a while, it is fine again.

I just did a sample:

13.1% of my requests end in a 404
47.6% of my requests return an empty geojson object {"type":"FeatureCollection","features":[]}
39.4% of my requests return the correct geojson object containing all the points from OSM.

So over 60% of the time, the rendering of the geojson data from OSM on the maps fails. This means that the chance is 1/6 that both the PNG and the full screen map show the OSM content.

thiemowmde set the point value for this task to 8.Aug 17 2022, 8:26 AM

We found T307671: High rate of 5XX errors from maps.wikimedia.org since 2022-05-05 ~03:20 where this small but significant change was made: https://gerrit.wikimedia.org/r/789598. It appears like this was merely silencing the log spam without actually fixing anything. What we get now are the empty {"type":"FeatureCollection","features":[]} described in this ticket here.

For reference, the code that creates this little snippet of GeoJSON is here: https://phabricator.wikimedia.org/diffusion/MSKA/browse/master/lib/snapshot/mapdataLoader.js$99. This is the same file touched in T307671. I suspect the error might be in this file.

thiemowmde removed the point value for this task.Sep 28 2022, 12:05 PM
thiemowmde moved this task from In sprint to Ready for story time on the WMDE-GeoInfo-FocusArea board.
lilients_WMDE set the point value for this task to 5.
WMDE-Fisch subscribed.

All examples mentioned seem to work now. Probably due to the latest server sync.