Page MenuHomePhabricator

[QB] Investigate moving Query Builder from Gerrit to GitLab
Open, Needs TriagePublic

Description

In order to maintain workflow consistency and minimize context switching for a team that mostly works on client side tools hosted on other tools than Gerrit, we would like to investigate the possibility of moving the Wikidata Query Builder's repository from Gerrit to Gitlab.

The investigation into this topic should at least address the following questions:

  • What steps do we need to take to perform the migration?
  • What would be the Impact on our current CI workflows?
  • Is it possible for us to migrate the CI workflows in their entirety?
  • Does the fact that Query Builder is deployed to microsites have any bearing on the potential move?
  • Is there an equivalent to Dependabot for Wikimedia GitLab?
  • How do we handle prior comments on Gerrit reviews? Can we migrate them to GitLab somehow?

Acceptance Criteria:

  • An investigation report is made available to the team
  • If applicable, tickets are created to begin the move to GitLab

Timebox: 10 Hrs.

Event Timeline

ItamarWMDE renamed this task from [QB] Investigate moving QG from Gerrit to GitLab to [QB] Investigate moving QB from Gerrit to GitLab.Nov 7 2023, 4:43 PM
ItamarWMDE created this task.
ItamarWMDE moved this task from Incoming to [QT] By Project on the wmde-wikidata-tech board.

Prio Notes:

Impact AreaAffected
production / end usersno
monitoringno
development effortsyes
onboarding effortsyes
additional stakeholdersmaybe
ItamarWMDE renamed this task from [QB] Investigate moving QB from Gerrit to GitLab to [SW] [QB] Investigate moving QB from Gerrit to GitLab.Nov 21 2023, 2:08 PM
ItamarWMDE moved this task from [QT] By Project to [QT] Prioritized on the wmde-wikidata-tech board.
ItamarWMDE renamed this task from [SW] [QB] Investigate moving QB from Gerrit to GitLab to [QB] Investigate moving QB from Gerrit to GitLab.Nov 22 2023, 9:58 AM
ItamarWMDE updated the task description. (Show Details)

We may contact the team in the WMF responsible for migrating from Gerrit to GitLab, in order to consult and assist us with this investigation.

ItamarWMDE renamed this task from [QB] Investigate moving QB from Gerrit to GitLab to [QB] Investigate moving Query Builder from Gerrit to GitLab.Dec 13 2023, 3:58 PM

See T350793: move commons-query.wikimedia.org and query.wikidata.org to kubernetes for a discussion about the microsites deployment pipeline for both QB and QS-GUI

Expanding on one of the comments I added in the report for documentation purposes:

The Gitlab Migration Guide specifies:

"This will create a complete copy of the repository, including all branches and review notes from Gerrit."

("This" being importing the project to Gitlab by URL).

I spent some time looking through projects already ported to Gitlab (see list of repos in miscweb) and I couldn't find evidence that review notes are migrated as well.
For example, see this change on Gerrit and its migrated equivalent on Gitlab. In this case the final commit was migrated, but the previous commits in the Gerrit patch and the review notes for those commits have not been included and are nowhere to be found in the Gitlab migrated project.

It might be worth to at least find out what the Gitlab team's approach to this is. The review data isn't lost, it's still on Gerrit and will probably remain there until the foundation stops using Gerrit altogether which I don't see happening any time soon.