Investigation results: https://docs.google.com/document/d/1Uh1mSTYBht75XmvI26f8oJN0xWV0e8Q_--B-jIIENsk/edit?usp=sharing

Relevant PR: https://github.com/wmde/wikidata-mismatch-finder/pull/880

Update: v1.3.1 of codex can't be installed because the current version of MMF is 3.3.8 and this updates required a minimum version of vue 3.3.9.
See run here: https://github.com/wmde/wikidata-mismatch-finder/actions/runs/7700640277/job/20984902948#step:4:11

T356410 was created to investigate why netlify-cli can't be updated.

Discoveries, stylelint can't be upgraded to v16 until there is a new version of stylelint-use-logical that supports it. Our current installed version of stylelint-use-logical: 2.1.0, supports:

There is a merge issue in this dependabot PR https://github.com/wmde/wikidata-mismatch-finder/pull/858 caused by a conflict with the version of @vue-compat required by codex. Since we are in the process of removing the compat build in T351812 i will move this ticket to stalled and try to merge the new version of codex afterwards.

Relevant PR: https://github.com/wmde/wikidata-mismatch-finder/pull/865

Relevant PRs:
Upgrade eslint-plugin-vue - https://github.com/wmde/wikidata-mismatch-finder/pull/860/files
Upgrade SASS: https://github.com/wmde/wikidata-mismatch-finder/pull/862
Upgrade ts-loader: https://github.com/wmde/wikidata-mismatch-finder/pull/863

The report can be found here: https://docs.google.com/document/d/1A6dSDuF2uSpbS75HWSenEnF2KcSKKpj-ZRAsX38n-nY/edit

After doing some research, I have found that ESLint has deprecated all formatting rules: https://eslint.org/blog/2023/10/deprecating-formatting-rules/, the deprecated rules will still be available in a new package called stylistic.

After all the back and forth I have just noticed we do have an editorconfig file already in the project, I still think it is a better idea to install stylelint. Now I am not sure what to do with that file, though. Do we leave it there? @ItamarWMDE @noarave @HasanAkgun_WMDE .

PR adding vue/vue3-strongly-recommended: https://github.com/wmde/wikidata-mismatch-finder/pull/836
PR adding stylelint to project https://github.com/wmde/wikidata-mismatch-finder/pull/841/

@HasanAkgun_WMDE @ItamarWMDE @noarave we still have the issue that SCSS files are not being checked by the any linter. I just realized that PostCSS converts to CSS but doesn't lint the files. I would suggest we install stylelint since it could also check other potential violations in the CSS. It seems to the editorconfig file would only check the indentation. What do you think? To sum it up, my suggestion here is to replace the A/C of an editorconfig file by installing stylelint in the project.

In T351644#9468109, @ItamarWMDE wrote:

I don't necessarily mind either or. Although, I'm not sure indentation (or tabs v. spaces) is actually covered by the vue3-strongly-recommended plugin. At least, I could not find it in the documentation: https://eslint.vuejs.org/rules/

Hello, @Sarai-WMDE I guess more of a question for UX: if the log in link in the AuthWidget is not supposed to have a visited state (aka purple color after visited)... is it supposed to have a visited state when it is part of the message component?

@HasanAkgun_WMDE @ItamarWMDE Hello, since the indenting rules are reinforced by Vue 3's strongly-recommended plugin, I don't see what would be the benefit of adding a .editorconfig file. In my opinion we don't need it. What do you think?

Relevant PR: https://github.com/wmde/wikidata-mismatch-finder/pull/836

Relevant PR: https://github.com/wmde/wikidata-mismatch-finder/pull/831

Hello, @Sarai-WMDE , the white space below the footer is not related to the textarea, it is an issue of the height of the page... Don't know if it makes sense to put in these changes. We had already worked on this issue but it seems like the solution wasn't bulletproof. :/

Relevant PR: https://github.com/wmde/wikidata-mismatch-finder/pull/826

Relevant PR: https://github.com/wmde/wikidata-mismatch-finder/pull/828

Stall until Mismatches Table and Results Page refactorings to Vue3 are merged. Otherwise there are test errors in this component.