Now that T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) is done, this extension should migrate away from building and passing around raw SQL to expression builders.
It improves readability and security of the code and is more aligned with industry practices easing onboarding.
For more information check T210206 and T350075.
Calls to Database::addQuotes(), ::buildLike(), ::makeList() indicate that raw SQL is being built and passed around.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Migrate to IReadableDatabase::newSelectQueryBuilder | mediawiki/extensions/GrowthExperiments | master | +125 -120 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T350075 Migrate raw SQL building in conditions to expression builder in WMF-deployed extensions | |||
| Resolved | Umherirrender | T350954 Use expression builder instead of raw SQL in GrowthExperiments |
Change #1024904 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/extensions/GrowthExperiments@master] Migrate to IReadableDatabase::newSelectQueryBuilder
Change #1024904 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Migrate to IReadableDatabase::newSelectQueryBuilder