Page MenuHomePhabricator

Use expression builder instead of raw SQL in Newsletter
Closed, ResolvedPublic

Description

Now that T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) is done, this extension should migrate away from building and passing around raw SQL to expression builders.

It improves readability and security of the code and is more aligned with industry practices easing onboarding.

For more information check T210206 and T350075.

Calls to Database::addQuotes(), ::buildLike(), ::makeList() indicate that raw SQL is being built and passed around.

Event Timeline

Change 1004327 had a related patch set uploaded (by 01tonythomas; author: 01tonythomas):

[mediawiki/extensions/Newsletter@master] WIP: Use experssion builder instead

https://gerrit.wikimedia.org/r/1004327

Change #1024814 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Newsletter@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1024814

Change #1024814 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1024814

Change #1004327 abandoned by Umherirrender:

[mediawiki/extensions/Newsletter@master] WIP: Use experssion builder instead

Reason:

Done via I1f49f19af2071253b555bcc94ceb8712c97c9e1b

https://gerrit.wikimedia.org/r/1004327