| Jdlrobson | |
| Tue, May 14, 1:21 AM |
| F54742274: Screenshot 2024-05-30 at 13.58 1.png | |
| Thu, May 30, 7:17 PM |
| F54742982: Screenshot 2024-05-30 at 16.13 1.png | |
| Thu, May 30, 7:17 PM |
| F54742227: Read proposal (1).png | |
| Thu, May 30, 7:17 PM |
| F54741905: Screenshot 2024-05-30 at 13.55 1.png | |
| Thu, May 30, 7:17 PM |
| F54742104: Screenshot 2024-05-30 at 15.59 2.png | |
| Thu, May 30, 7:17 PM |
| F54740269: Unread proposal.png | |
| Thu, May 30, 7:17 PM |
| F53049476: screenshot 337.png | |
| Wed, May 15, 2:08 AM |
| F53049473: screenshot 335.png | |
| Wed, May 15, 2:08 AM |
From T363779#9792848
Steps to replicate the issue (include links if applicable):
What happens?:
Lots of color contrast issues
{F53052951}
(the screenshots below are added from T363779#9792848
What should have happened instead?:
No color contrast issues.
Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | BUG REPORT | JFernandez-WMF | T364805 Echo has color contrast issues in standard theme and night theme | ||
| Open | None | T366322 Fix Echo color contrast issues in standard theme & night mode |
I'm marking this as lower priority since it doesn't relate to our current work, however Echo notifications are a widely used feature so it makes sense work on this. I think first we'll need @JFernandez-WMF to take a look and suggest colors that remove the contrast / accessibility issue before engineers can work on this.
Thanks for filing this task @Jdlrobson! This is my suggestion:
| Proposal | Contrast | Contrast |
| Unread proposal | background-color/interactive + text-color/base | background-color/interactive + text-color/subtle |
 |  |  |
| Read proposal | background-color/base + text-color/base | background-color/base + text-color/subtle |
 |  |  |
Hopefully, the table is understandable, if not I am happy to re-phrase or jump on a quick call. I propose using our text color tokens, specifically base and subtle.
Thanks, @JFernandez-WMF.
I've created the following task for the associated engineering work: T366322: Fix Echo color contrast issues in standard theme & night mode, so I think we can consider this task (the design task) resolved.
@Jdlrobson I'm assuming Growth owns the fix for the standard theme, but Web is handling making sure night theme contrast passes accessibility tests. Is that correct?
Yes ideally Growth team would fix this (and web team is available for anything you get stuck on or any advice you need). My hope is that you could also verify and resolve any color contrast issues yourselves within the Echo notification dialog - https://night-mode-checker.wmcloud.org/ provides various tooling that can help with that - we're happy to QA this if you need it. For general accessibility issues e.g. ones that appear outside the Echo dialog, those are web team responsibility. Hope this makes sense?
Follow-up engineering task: T366322: Fix Echo color contrast issues in standard theme & night mode