⚓ T88258 Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registration

Subject	Repo	Branch	Lines +/-
[WIP] Switch to load extension using MediaWiki's extension registration	mediawiki/extensions/Wikibase	master	+2 K -2 K
Move repo hooks to extension registration	mediawiki/extensions/Wikibase	master	+49 -50
Move two jobs to extension registration	mediawiki/extensions/Wikibase	master	+4 -7
PSR-4 autoload more of Wikibase Client	mediawiki/extensions/Wikibase	master	+6 -41
[BREAKING CHANGE] Wikibase: Convet lib, client, repo to extension.json, empty php entry point	mediawiki/extensions/Wikibase	master	+715 -517
Wikibase Client: Add extension.json, empty PHP entry point	mediawiki/extensions/Wikibase	master	+205 -136
Wikibase Lib: Add extension.json, empty PHP entry point	mediawiki/extensions/Wikibase	master	+97 -77
Wikibase Repo: Add extension.json, empty PHP entry point	mediawiki/extensions/Wikibase	master	+325 -251

Status	Assigned	Task
		· · ·
Resolved	None	T87875 Convert all Wikimedia-deployed extensions and skins to use extension registration
Invalid	None	T92980 [Story] Convert all extensions that are part of the Wikidata build to use the new extension registration
Open	None	T88567 [Task] Remove support for old extension registration/loading endpoint in Wikibase-related extensions
Open	None	T239137 Replace individual wfLoadExtension calls with a loop operating over an array
Resolved	None	T88258 Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registration
Resolved	Victorbarbu	T119766 Composer's autoloader should be autoloaded in extension registry (if configured)
Resolved	Lucas_Werkmeister_WMDE	T223214 Start converting Wikibase extensions to use extension registration
Resolved	Ladsgroup	T256228 Convert WikibaseClient to use extension registration
Resolved	Ladsgroup	T257431 Copy Lib extension.json content to Repo
Resolved	Ladsgroup	T257432 Remove Lib extension.json
Resolved	Ladsgroup	T257433 Convert Repo to use Extension Registration
Resolved	Ladsgroup	T257436 Deploy Repo using extension registration to Beta
		· · ·

Addshore awarded a token.Jun 26 2018, 10:07 AM

Removing the story point as I can't see when it was actually added and I don't believe it is comparable to our current story points

Addshore renamed this task from [Task] Convert WikibaseClient, WikibaseLib and WikibaseRepository to use extension registration to Convert WikibaseClient, WikibaseLib and WikibaseRepository to use extension registration.Jul 31 2018, 11:46 AM

Addshore removed WMDE-leszek as the assignee of this task.

Addshore added a subscriber: WMDE-leszek.

also related T201615

Addshore added a project: [DEPRECATED] wdwb-tech.Aug 18 2018, 4:42 PM

Addshore moved this task from Inbox to Research on the [DEPRECATED] wdwb-tech board.

Addshore added a project: Technical-Debt.Aug 18 2018, 5:15 PM

Addshore updated the task description. (Show Details)

Addshore moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.

Addshore added a project: Story.

Addshore moved this task from Research to Goals on the [DEPRECATED] wdwb-tech board.

Another potentially related task semi-blocked on this one: T188717

hashar subscribed.Sep 4 2018, 10:32 AM

Izno mentioned this in T140852: Load all Wikimedia-deployed extensions and skins via extension registration.Sep 11 2018, 7:52 PM

Krinkle edited parent tasks, added: T140852: Load all Wikimedia-deployed extensions and skins via extension registration; removed: T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.Sep 11 2018, 9:31 PM

Krinkle added a parent task: T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.Sep 12 2018, 6:29 AM

Krinkle removed a parent task: T140852: Load all Wikimedia-deployed extensions and skins via extension registration.

Liuxinyu970226 unsubscribed.Sep 12 2018, 10:49 AM

Addshore moved this task from Goals to Legacy Inbox on the [DEPRECATED] wdwb-tech board.Oct 8 2018, 12:40 PM

Jdforrester-WMF mentioned this in T201615: Wikibase on Vagrant: Class 'Wikibase\DataModel\Entity\ItemId' not found.Oct 9 2018, 10:45 PM

Jdforrester-WMF subscribed.

hashar mentioned this in T188717: Move Wikibase to using the normal mediawiki extension (quibble) jobs.Oct 16 2018, 10:28 AM

Jdforrester-WMF added a parent task: T88567: [Task] Remove support for old extension registration/loading endpoint in Wikibase-related extensions.Nov 15 2018, 11:19 PM

Mvolz awarded a token.Mar 15 2019, 10:12 AM

Lucas_Werkmeister_WMDE renamed this task from Convert WikibaseClient, WikibaseLib and WikibaseRepository to use extension registration to Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registration.Apr 16 2019, 11:26 AM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

hashar awarded a token.Apr 17 2019, 9:47 AM

T87985: Convert Translate to use extension registration has an interesting proposal for how to do the migration: instead of trying to convert the whole file at once, which results in a huge patch that’s hard to review and grows stale quickly, start with an empty extension-wip.json file, load that from the PHP entrypoint, and then start moving parts of the extension registration from PHP to JSON one by one, until the PHP file is just the wfLoadExtension() call and extension-wip.json can be renamed to a proper extension.json. It looks like that approach was pretty successful for the Translate extension, so I think we should follow it here as well.

That sounds like a great idea :)

Lucas_Werkmeister_WMDE closed subtask T223214: Start converting Wikibase extensions to use extension registration as Resolved.Jun 12 2019, 3:45 PM

Addshore added a project: Wikidata-Trailblazing-Exploration.Jun 20 2019, 10:52 PM

Addshore moved this task from Backlog to In Process / Picked Up on the Wikidata-Trailblazing-Exploration board.

Addshore moved this task from In Process / Picked Up to In Investigation (cost/impact) on the Wikidata-Trailblazing-Exploration board.

Removing this form the campsite, until it has gone through the exploration we are currently doing

Addshore moved this task from In Investigation (cost/impact) to Campsite Candidates on the Wikidata-Trailblazing-Exploration board.Jun 21 2019, 10:02 PM

Needs a breakdown for each thing we are going to move.
Will do this soon.

In T88258#5118855, @Lucas_Werkmeister_WMDE wrote:

T87985: Convert Translate to use extension registration has an interesting proposal for how to do the migration: instead of trying to convert the whole file at once, which results in a huge patch that’s hard to review and grows stale quickly, start with an empty extension-wip.json file...

+1, this approach was relatively painless for the Translate extension, and has been validated by successful, incremental deployment.

Tgr mentioned this in T228593: Wikibase on Vagrant: composer-merge-plugin does not install wikibase/data-model anymore.Jul 21 2019, 2:15 PM

WMDE-leszek removed a project: Wikidata-Campsite.Aug 12 2019, 1:21 PM

• alaa_wmde moved this task from Campsite Candidates to In Investigation (cost/impact) on the Wikidata-Trailblazing-Exploration board.Aug 13 2019, 12:31 PM

• Mholloway awarded a token.Aug 29 2019, 3:40 PM

• Mholloway subscribed.

Change 535546 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] PSR-4 autoload more of Wikibase Client

https://gerrit.wikimedia.org/r/535546

gerritbot added a project: Patch-For-Review.Sep 10 2019, 11:04 AM

Change 535546 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] PSR-4 autoload more of Wikibase Client

https://gerrit.wikimedia.org/r/535546

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.23; 2019-09-17).Sep 11 2019, 11:00 AM

Lucas_Werkmeister_WMDE mentioned this in T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.Oct 16 2019, 11:53 AM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

• alaa_wmde moved this task from In Investigation (cost/impact) to Campsite Candidates on the Wikidata-Trailblazing-Exploration board.Oct 22 2019, 2:09 PM

Wikibase is now the last remaining WMF deployed extension that needs to switch over :)

Change 551613 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Move two jobs to extension registration

https://gerrit.wikimedia.org/r/551613

Change 551900 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Move repo hooks to extension registration

https://gerrit.wikimedia.org/r/551900

Addshore mentioned this in T239137: Replace individual wfLoadExtension calls with a loop operating over an array.Nov 26 2019, 9:38 AM

Change 551613 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move two jobs to extension registration

https://gerrit.wikimedia.org/r/551613

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Nov 27 2019, 7:00 PM

Jdforrester-WMF added a parent task: T239137: Replace individual wfLoadExtension calls with a loop operating over an array.Dec 5 2019, 11:22 PM

Michael subscribed.Jan 7 2020, 12:35 PM

Addshore added a project: Wikidata-Campsite.Jan 29 2020, 11:33 AM

Krinkle awarded a token.Apr 8 2020, 11:13 PM

Reedy mentioned this in T232875: The "ResourceLoaderTestModules" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet.May 17 2020, 9:59 PM

Change 551900 abandoned by Lucas Werkmeister (WMDE):
Move repo hooks to extension registration

Reason:
not pursued in this form, instead we should migrate the hooks more individually

https://gerrit.wikimedia.org/r/551900

Lucas_Werkmeister_WMDE closed subtask T257431: Copy Lib extension.json content to Repo as Resolved.Jul 13 2020, 4:11 PM

Lucas_Werkmeister_WMDE closed subtask T257432: Remove Lib extension.json as Resolved.

I just wanted to say we are this (🤏) close to finishing this. Client is already there and repo will follow suit in a week or two. We are waiting for deployments of the changes so we can change them in extension-list.

Thank you so much for moving forward on this task :]

In T88258#6308719, @hashar wrote:

Thank you so much for moving forward on this task :]

Oh it's mostly work of @Lucas_Werkmeister_WMDE @ItamarWMDE and @Tarrow. I mostly hit shiny +2 buttons.

Change 399437 abandoned by Ladsgroup:
[mediawiki/extensions/Wikibase@master] [WIP] Switch to load extension using MediaWiki's extension registration

Reason:
This is done already through many many patches.

https://gerrit.wikimedia.org/r/399437

Ladsgroup added a subtask: T257433: Convert Repo to use Extension Registration.Jul 21 2020, 9:54 PM

Mentioned in SAL (#wikimedia-operations) [2020-07-23T18:29:21Z] <ladsgroup@deploy1001> Synchronized wmf-config/Wikibase.php: [[gerrit:613235|Load WikibaseClient from extension.json file instead of php one (T257437 T256228 T88258)]] (duration: 01m 05s)

Stashbot mentioned this in T257437: Deploy Client to production using extension registration.Jul 23 2020, 6:29 PM

Stashbot mentioned this in T256228: Convert WikibaseClient to use extension registration.

Ladsgroup added a subtask: T257436: Deploy Repo using extension registration to Beta.Jul 23 2020, 7:19 PM

In T88258#6308719, @hashar wrote:

Thank you so much for moving forward on this task :]

Feel free to follow the progress here

Ladsgroup closed subtask T257436: Deploy Repo using extension registration to Beta as Resolved.Aug 4 2020, 11:56 AM

Ladsgroup closed subtask T256228: Convert WikibaseClient to use extension registration as Resolved.

Ladsgroup closed subtask T257433: Convert Repo to use Extension Registration as Resolved.Aug 4 2020, 12:00 PM

This is done, you can now load Wikibase extensions using extension.json, the mediawiki.org documentation has been updated but we will write announcements soon and won't break php entry point for now.

For repo:

wfLoadExtension( 'WikibaseRepository', "$IP/extensions/Wikibase/extension-repo.json" );
require_once "$IP/extensions/Wikibase/repo/ExampleSettings.php";
$wgWBRepoSettings['siteLinkGroups'] = [ 'mywikigroup' ];
$wgLocalDatabases = [ 'enwiki', 'fawiki' ];
$wgWBRepoSettings['localClientDatabases'] = array(
    'en' => 'enwiki',
    'fa' => 'fawiki'
);

For client:

wfLoadExtension( 'WikibaseClient', "$IP/extensions/Wikibase/extension-client.json" );
require_once "$IP/extensions/Wikibase/client/ExampleSettings.php";
$wgWBClientSettings['repoUrl'] = 'https://pool.my.wiki';
...

Shout out to @Lucas_Werkmeister_WMDE @Tarrow @ItamarWMDE for their great work.

Congrats all! :)

Jdlrobson awarded a token.Aug 4 2020, 3:31 PM

Krenair awarded a token.Aug 4 2020, 5:50 PM

Thank you @darthmon_wmde for the link to Wikibase Extension Decoupling and Registration :] To everyone involved:

antoine-approve

comment best seen via the web interface

Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registration
Closed, ResolvedPublic
Actions

Description

Details

Related Objects
Search...

Event Timeline

	Liuxinyu970226
	Feb 2 2015, 4:10 AM

Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registrationClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registration
Closed, ResolvedPublic
Actions

Related Objects
Search...