Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F2333
badmime.diff
Public
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Authored By
•
bzimport
Nov 21 2014, 8:50 PM
2014-11-21 20:50:49 (UTC+0)
Size
1 KB
Referenced Files
None
Subscribers
None
badmime.diff
View Options
Index: SpecialUpload.php
===================================================================
RCS file: /cvsroot/wikipedia/phase3/includes/SpecialUpload.php,v
retrieving revision 1.88
diff -u -r1.88 SpecialUpload.php
--- SpecialUpload.php 30 Sep 2005 15:54:35 -0000 1.88
+++ SpecialUpload.php 7 Oct 2005 14:13:09 -0000
@@ -752,13 +752,19 @@
function verifyExtension( $mime, $extension ) {
$fname = 'SpecialUpload::verifyExtension';
+ $magic=& wfGetMimeMagic();
+
if (!$mime || $mime=="unknown" || $mime=="unknown/unknown") {
- wfDebug( "$fname: passing file with unknown mime type\n" );
- return true;
+ if (!$magic->getTypesForExtension($extension)) {
+ wfDebug( "$fname: passing file with unknown mime type and unknown extension\n" );
+ return true;
+ }
+ else {
+ wfDebug( "$fname: rejecting file with unknown mime type but known extension\n" );
+ return false;
+ }
}
- $magic=& wfGetMimeMagic();
-
$match= $magic->isMatchingExtension($extension,$mime);
if ($match===NULL) {
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1909
Default Alt Text
badmime.diff (1 KB)
Attached To
Mode
T5641: files with a bad extension are not rejected if their true mime type can not be determined (PATCH)
Attached
Detach File
Event Timeline
Log In to Comment