Page MenuHomePhabricator

badmime.diff

Authored By
bzimport
Nov 21 2014, 8:50 PM
Size
1 KB
Referenced Files
None
Subscribers
None

badmime.diff

Index: SpecialUpload.php
===================================================================
RCS file: /cvsroot/wikipedia/phase3/includes/SpecialUpload.php,v
retrieving revision 1.88
diff -u -r1.88 SpecialUpload.php
--- SpecialUpload.php 30 Sep 2005 15:54:35 -0000 1.88
+++ SpecialUpload.php 7 Oct 2005 14:13:09 -0000
@@ -752,13 +752,19 @@
function verifyExtension( $mime, $extension ) {
$fname = 'SpecialUpload::verifyExtension';
+ $magic=& wfGetMimeMagic();
+
if (!$mime || $mime=="unknown" || $mime=="unknown/unknown") {
- wfDebug( "$fname: passing file with unknown mime type\n" );
- return true;
+ if (!$magic->getTypesForExtension($extension)) {
+ wfDebug( "$fname: passing file with unknown mime type and unknown extension\n" );
+ return true;
+ }
+ else {
+ wfDebug( "$fname: rejecting file with unknown mime type but known extension\n" );
+ return false;
+ }
}
- $magic=& wfGetMimeMagic();
-
$match= $magic->isMatchingExtension($extension,$mime);
if ($match===NULL) {

File Metadata

Mime Type
text/x-diff
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1909
Default Alt Text
badmime.diff (1 KB)

Event Timeline