Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F6162
AbuseFilter.class.php.patch
Public
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Authored By
•
bzimport
Nov 21 2014, 10:51 PM
2014-11-21 22:51:16 (UTC+0)
Size
2 KB
Referenced Files
None
Subscribers
None
AbuseFilter.class.php.patch
View Options
Index: /trunk/extensions/AbuseFilter
===================================================================
--- /trunk/extensions/AbuseFilter/AbuseFilter.class.php (revision 76446)
+++ /trunk/extensions/AbuseFilter/AbuseFilter.class.php (working copy)
@@ -1347,47 +1347,49 @@
$rules = rtrim( $rules ) . "\n";
$rules = Xml::textarea( $textName, $rules, 40, 5, $readOnlyAttrib );
+
+ if ($canEdit) {
+ $dropDown = self::getBuilderValues();
+ // Generate builder drop-down
+ $builder = '';
- $dropDown = self::getBuilderValues();
- // Generate builder drop-down
- $builder = '';
+ $builder .= Xml::option( wfMsg( 'abusefilter-edit-builder-select' ) );
- $builder .= Xml::option( wfMsg( 'abusefilter-edit-builder-select' ) );
+ foreach ( $dropDown as $group => $values ) {
+ $builder .=
+ Xml::openElement(
+ 'optgroup',
+ array( 'label' => wfMsg( "abusefilter-edit-builder-group-$group" ) )
+ ) . "\n";
- foreach ( $dropDown as $group => $values ) {
- $builder .=
- Xml::openElement(
- 'optgroup',
- array( 'label' => wfMsg( "abusefilter-edit-builder-group-$group" ) )
- ) . "\n";
+ foreach ( $values as $content => $name ) {
+ $builder .=
+ Xml::option(
+ wfMsg( "abusefilter-edit-builder-$group-$name" ),
+ $content
+ ) . "\n";
+ }
- foreach ( $values as $content => $name ) {
- $builder .=
- Xml::option(
- wfMsg( "abusefilter-edit-builder-$group-$name" ),
- $content
- ) . "\n";
+ $builder .= Xml::closeElement( 'optgroup' ) . "\n";
}
- $builder .= Xml::closeElement( 'optgroup' ) . "\n";
+ $rules .=
+ Xml::tags(
+ 'select',
+ array( 'id' => 'wpFilterBuilder', 'onchange' => 'addText();' ),
+ $builder
+ ) . ' ';
+
+ // Add syntax checking
+ $rules .= Xml::element( 'input',
+ array(
+ 'type' => 'button',
+ 'onclick' => 'doSyntaxCheck()',
+ 'value' => wfMsg( 'abusefilter-edit-check' ),
+ 'id' => 'mw-abusefilter-syntaxcheck'
+ ) + $noTestAttrib );
}
- $rules .=
- Xml::tags(
- 'select',
- array( 'id' => 'wpFilterBuilder', 'onchange' => 'addText();' ),
- $builder
- ) . ' ';
-
- // Add syntax checking
- $rules .= Xml::element( 'input',
- array(
- 'type' => 'button',
- 'onclick' => 'doSyntaxCheck()',
- 'value' => wfMsg( 'abusefilter-edit-check' ),
- 'id' => 'mw-abusefilter-syntaxcheck'
- ) + $noTestAttrib );
-
if ( $addResultDiv )
$rules .= Xml::element( 'div',
array( 'id' => 'mw-abusefilter-syntaxresult', 'style' => 'display: none;' ),
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
5710
Default Alt Text
AbuseFilter.class.php.patch (2 KB)
Attached To
Mode
T22472: AbuseFilter: disable "add at cursor" selection box when user can't edit filters
Attached
Detach File
Event Timeline
Log In to Comment