Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F7874
bug28642_abutting_comments.patch
Public
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Authored By
•
bzimport
Nov 21 2014, 11:35 PM
2014-11-21 23:35:24 (UTC+0)
Size
1 KB
Referenced Files
None
Subscribers
None
bug28642_abutting_comments.patch
View Options
Index: Preprocessor_DOM.php
===================================================================
--- Preprocessor_DOM.php (Revision 86705)
+++ Preprocessor_DOM.php (Arbeitskopie)
@@ -343,11 +343,11 @@
if ( $stack->top ) {
$part = $stack->top->getCurrentPart();
- $part->commentEnd = $endPos;
if ( ! (isset( $part->commentEnd ) && $part->commentEnd == $wsStart - 1 )) {
$part->visualEnd = $wsStart;
}
// Else comments abutting, no change in visual end
+ $part->commentEnd = $endPos;
}
$i = $endPos + 1;
$inner = substr( $text, $startPos, $endPos - $startPos + 1 );
Index: Preprocessor_Hash.php
===================================================================
--- Preprocessor_Hash.php (Revision 86705)
+++ Preprocessor_Hash.php (Arbeitskopie)
@@ -304,13 +304,11 @@
if ( $stack->top ) {
$part = $stack->top->getCurrentPart();
- if ( isset( $part->commentEnd ) && $part->commentEnd == $wsStart - 1 ) {
- // Comments abutting, no change in visual end
- $part->commentEnd = $wsEnd;
- } else {
+ if ( ! (isset( $part->commentEnd ) && $part->commentEnd == $wsStart - 1 )) {
$part->visualEnd = $wsStart;
- $part->commentEnd = $endPos;
}
+ // Else comments abutting, no change in visual end
+ $part->commentEnd = $endPos;
}
$i = $endPos + 1;
$inner = substr( $text, $startPos, $endPos - $startPos + 1 );
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
7402
Default Alt Text
bug28642_abutting_comments.patch (1 KB)
Attached To
Mode
T30642: wrong part->commentEnd set to atributting comments
Attached
Detach File
Event Timeline
Log In to Comment