Page MenuHomePhabricator
Paste P11656

Core creation of Revision objects, 6/25/20
ArchivedPublic

Authored by DannyS712 on Thu, Jun 25, 3:09 AM.
Every time `new Revision( ... )` is used in core, as of 6/25/20
* Does not include the Revision class's static constructors, all of which are deprecated
* Does not include tests
EditPage::getBaseRevision - method is hard deprecated
MovePage::moveUnsafe - needed for a hook (TitleMoveCompleting, soft deprecated)
MovePage::moveUnsafe - needed for a hook (TitleMoveComplete, soft deprecated)
MovePage::moveToInternal - needed for a hook (x2, NewRevisionFromEditComplete, hard deprecated)
RevisionStore::insertRevisionOn - needed for a hook (RevisionInsertComplete, hard deprecated)
PageUpdater::doModify - needed for a hook (NewRevisionFromEditComplete, hard deprecated), and returned (via DeprecatablePropertyArray, soft deprecated)
PageUpdater::doCreate - needed for a hook (NewRevisionFromEditComplete, hard deprecated), and returned (via DeprecatablePropertyArray, soft deprecated)
PageUpdater::getAtomicSectionUpdate - needed for two hooks (PageContentInsertComplete, soft deprecated, and PageContentSaveComplete, soft deprecated)
Title::getFirstRevision - method is hard deprecated
HistoryPager::historyLine - needed for a hook (x2, HistoryRevisionTools, hard deprecated)
ApiQueryRevisions::run - needed for token functions (FIXME)
LinksUpdate::getRevision - method is hard deprecated
DifferenceEngine::showDiffPage - needed for a hook (x4, DiffViewHeader, hard deprecated, and DiffRevisionTools, hard deprecated)
LocalFile::recordUpload2 - needed for a hook (NewRevisionFromEditComplete, hard deprecated)
Article::getRevisionFetched - method is hard deprecated
Article::__get (mRevision) - hard deprecated
PageArchive::getRevision - method is hard deprecated
PageArchive::getArchivedRevision - method is hard deprecated
PageArchive::getPreviousRevision - method is hard deprecated
PageArchive::undeleteRevisions - needed for a hook (ArticleRevisionUndeleted, hard deprecated)
WikiPage::getOldestRevision - method is hard deprecated
WikiPage::getRevision - method is hard deprecated
WikiPage::getUndoContent - method is hard deprecated
WikiPage::doUpdateRestrictions - needed for a hook (NewRevisionFromEditComplete, hard deprecated)
WikiPage::insertProtectNullRevision - method is hard deprecated
WikiPage::commitRollback - "returned" by modifying array passed by reference (FIXME)
Parser::fetchCurrentRevisionOfTitle - hard deprecated
Parser::statelessFetchRevision - hard deprecated
Parser::statelessFetchTemplate - needed for a hook (ParserFetchTemplate, hard deprecated)
Parser::statelessFetchTemplate - returned (via DeprecatablePropertyArray, soft deprecated)
Parser::getRevisionObject - hard deprecated
ParserOptions::getCurrentRevisionCallback - hard deprecated
ImportReporter::reportPage - needed for a hook (NewRevisionFromEditComplete, hard deprecated)
ContribsPager::tryToCreateValidRevision - method is hard deprecated
User::getNewMessageLinks - method is hard deprecated

Event Timeline

DannyS712 created this paste.Thu, Jun 25, 3:09 AM

TODOs:

MovePage::moveUnsafe - needed for a hook (TitleMoveCompleting, soft deprecated)
MovePage::moveUnsafe - needed for a hook (TitleMoveComplete, soft deprecated)

PageUpdater::doModify - needed for a hook (NewRevisionFromEditComplete, hard deprecated), and returned (via DeprecatablePropertyArray, soft deprecated)
PageUpdater::doCreate - needed for a hook (NewRevisionFromEditComplete, hard deprecated), and returned (via DeprecatablePropertyArray, soft deprecated)
PageUpdater::getAtomicSectionUpdate - needed for two hooks (PageContentInsertComplete, soft deprecated, and PageContentSaveComplete, soft deprecated)

ApiQueryRevisions::run - needed for token functions (FIXME)

WikiPage::commitRollback - "returned" by modifying array passed by reference (FIXME)

Parser::statelessFetchTemplate - returned (via DeprecatablePropertyArray, soft deprecated)

DannyS712 archived this paste.Thu, Jul 2, 2:43 AM