Page MenuHomePhabricator

Special:PageTranslation diff says "no difference" when no wikitext changes from marking for the first time
Closed, ResolvedPublic

Description

We added a note if there are no changes in the text when remarking a page. This notice is incorrectly shown when marking page for translation the first time.

Event Timeline

Nikerabbit raised the priority of this task from to Needs Triage.
Nikerabbit updated the task description. (Show Details)
Nikerabbit subscribed.

I can't reproduce on mediawiki.org. On marking a page for translation the first time, I got the correct

"tpt-saveok": "The page [[:$1]] has been marked up for translation with $2 {{PLURAL:$2|translation unit|translation units}}.\nThe page can now be <span class=\"plainlinks\">[$3 translated]</span>.",

and no sign of

"tpt-mark-nochanges": "There is no difference between this revision and the last marked revision.",

But I think I understand what you mean.

Nemo_bis renamed this task from Incorrect "no changes to the previous version" warning on Special:PageTranslation when marking page for the first time to Special:PageTranslation diff says "no difference" when no wikitext changes from marking for the first time.May 24 2015, 11:28 AM
Nemo_bis set Security to None.

Change 213238 had a related patch set uploaded (by Nemo bis):
Make tpt-mark-nochanges impervious to manual addition of <!--T...-->

https://gerrit.wikimedia.org/r/213238

Change 213238 merged by jenkins-bot:
Make tpt-mark-nochanges impervious to manual addition of <!--T...-->

https://gerrit.wikimedia.org/r/213238